From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions() Date: Wed, 06 Dec 2017 14:25:42 -0500 (EST) Message-ID: <20171206.142542.491013112912141715.davem@davemloft.net> References: <20171205143752.cymsw7fzlqn6ejeq@mwanda> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: dan.carpenter@oracle.com, sathya.perla@broadcom.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: michael.chan@broadcom.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:53932 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610AbdLFTZq (ORCPT ); Wed, 6 Dec 2017 14:25:46 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Michael Chan Date: Wed, 6 Dec 2017 11:16:55 -0800 > On Tue, Dec 5, 2017 at 6:37 AM, Dan Carpenter wrote: >> Smatch warns that: >> >> drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions() >> error: uninitialized symbol 'rc'. >> >> "rc" is either uninitialized or set to zero here so we can just remove >> the check. >> >> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload") >> Signed-off-by: Dan Carpenter > > Thanks. > > Acked-by: Michael Chan Applied to net-next, thanks everyone. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Wed, 06 Dec 2017 19:25:42 +0000 Subject: Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions() Message-Id: <20171206.142542.491013112912141715.davem@davemloft.net> List-Id: References: <20171205143752.cymsw7fzlqn6ejeq@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: michael.chan@broadcom.com Cc: dan.carpenter@oracle.com, sathya.perla@broadcom.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org From: Michael Chan Date: Wed, 6 Dec 2017 11:16:55 -0800 > On Tue, Dec 5, 2017 at 6:37 AM, Dan Carpenter wrote: >> Smatch warns that: >> >> drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions() >> error: uninitialized symbol 'rc'. >> >> "rc" is either uninitialized or set to zero here so we can just remove >> the check. >> >> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload") >> Signed-off-by: Dan Carpenter > > Thanks. > > Acked-by: Michael Chan Applied to net-next, thanks everyone.