From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch net-next] mlxsw: spectrum: handle NETIF_F_HW_TC changes correctly Date: Wed, 06 Dec 2017 15:11:30 -0500 (EST) Message-ID: <20171206.151130.1584808862028101813.davem@davemloft.net> References: <20171206084112.2727-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, idosch@mellanox.com, mlxsw@mellanox.com To: jiri@resnulli.us Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:54608 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbdLFULc (ORCPT ); Wed, 6 Dec 2017 15:11:32 -0500 In-Reply-To: <20171206084112.2727-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Wed, 6 Dec 2017 09:41:12 +0100 > From: Jiri Pirko > > Currently, whenever the NETIF_F_HW_TC feature changes, we silently > always allow it, but we actually do not disable the flows in HW > on disable. That breaks user's expectations. So just forbid > the feature disable in case there are any filters offloaded. > > Signed-off-by: Jiri Pirko > Reviewed-by: Ido Schimmel Applied, thanks Jiri.