From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by ml01.01.org (Postfix) with ESMTP id B2FED20352A87 for ; Tue, 5 Dec 2017 16:25:16 -0800 (PST) Date: Wed, 6 Dec 2017 11:29:46 +1100 From: Dave Chinner Subject: Re: [xfsprogs PATCH v2 3/3] xfs_io: add a new 'log_writes' command Message-ID: <20171206002946.GD5858@dastard> References: <20171205235651.17102-1-ross.zwisler@linux.intel.com> <20171205235651.17102-4-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20171205235651.17102-4-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Ross Zwisler Cc: linux-xfs , Jan Kara , fstests , linux-nvdimm List-ID: On Tue, Dec 05, 2017 at 04:56:51PM -0700, Ross Zwisler wrote: > Add a new 'log_writes' command to xfs_io so that we can add dm-log-writes > log marks. It's helpful to allow users of xfs_io to adds these marks from > within xfs_io instead of waiting until after xfs_io exits because then they > are able to replay the dm-log-writes log up to immediately after another > xfs_io operation such as mwrite. This isolates the log replay from other > operations that happen as part of xfs_io exiting (file handles being > closed, mmaps being torn down, etc.). This also allows users to insert > multiple marks between different xfs_io commands. > > Signed-off-by: Ross Zwisler > Suggested-by: Dave Chinner having just looked at the xfs_io mess, this new command needs to set "exitcode = 1" on failure. I haven't looked at anything else in the patch. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:38902 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbdLFA3t (ORCPT ); Tue, 5 Dec 2017 19:29:49 -0500 Date: Wed, 6 Dec 2017 11:29:46 +1100 From: Dave Chinner Subject: Re: [xfsprogs PATCH v2 3/3] xfs_io: add a new 'log_writes' command Message-ID: <20171206002946.GD5858@dastard> References: <20171205235651.17102-1-ross.zwisler@linux.intel.com> <20171205235651.17102-4-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171205235651.17102-4-ross.zwisler@linux.intel.com> Sender: fstests-owner@vger.kernel.org To: Ross Zwisler Cc: linux-xfs , linux-nvdimm , fstests , Jan Kara , Dan Williams List-ID: On Tue, Dec 05, 2017 at 04:56:51PM -0700, Ross Zwisler wrote: > Add a new 'log_writes' command to xfs_io so that we can add dm-log-writes > log marks. It's helpful to allow users of xfs_io to adds these marks from > within xfs_io instead of waiting until after xfs_io exits because then they > are able to replay the dm-log-writes log up to immediately after another > xfs_io operation such as mwrite. This isolates the log replay from other > operations that happen as part of xfs_io exiting (file handles being > closed, mmaps being torn down, etc.). This also allows users to insert > multiple marks between different xfs_io commands. > > Signed-off-by: Ross Zwisler > Suggested-by: Dave Chinner having just looked at the xfs_io mess, this new command needs to set "exitcode = 1" on failure. I haven't looked at anything else in the patch. Cheers, Dave. -- Dave Chinner david@fromorbit.com