From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:55677 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753400AbdLFAmS (ORCPT ); Tue, 5 Dec 2017 19:42:18 -0500 From: Matthew Wilcox Cc: Matthew Wilcox , Ross Zwisler , Jens Axboe , Rehas Sachdeva , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 65/73] dax: Fix sparse warning Date: Tue, 5 Dec 2017 16:41:51 -0800 Message-Id: <20171206004159.3755-66-willy@infradead.org> In-Reply-To: <20171206004159.3755-1-willy@infradead.org> References: <20171206004159.3755-1-willy@infradead.org> To: unlisted-recipients:; (no To-header on input) Sender: linux-btrfs-owner@vger.kernel.org List-ID: From: Matthew Wilcox sparse doesn't know that follow_pte_pmd conditionally acquires the ptl, so add an annotation to let it know what's going on. Signed-off-by: Matthew Wilcox --- fs/dax.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/dax.c b/fs/dax.c index c663d82e8ba3..7a86ff1153dd 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -531,6 +531,7 @@ static void dax_mapping_entry_mkclean(struct address_space *mapping, */ if (follow_pte_pmd(vma->vm_mm, address, &start, &end, &ptep, &pmdp, &ptl)) continue; + __acquire(ptl); /* Conditionally acquired above */ /* * No need to call mmu_notifier_invalidate_range() as we are -- 2.15.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Matthew Wilcox To: Cc: Matthew Wilcox , Ross Zwisler , Jens Axboe , Rehas Sachdeva , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 65/73] dax: Fix sparse warning Date: Tue, 5 Dec 2017 16:41:51 -0800 Message-Id: <20171206004159.3755-66-willy@infradead.org> In-Reply-To: <20171206004159.3755-1-willy@infradead.org> References: <20171206004159.3755-1-willy@infradead.org> Sender: owner-linux-mm@kvack.org List-ID: From: Matthew Wilcox sparse doesn't know that follow_pte_pmd conditionally acquires the ptl, so add an annotation to let it know what's going on. Signed-off-by: Matthew Wilcox --- fs/dax.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/dax.c b/fs/dax.c index c663d82e8ba3..7a86ff1153dd 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -531,6 +531,7 @@ static void dax_mapping_entry_mkclean(struct address_space *mapping, */ if (follow_pte_pmd(vma->vm_mm, address, &start, &end, &ptep, &pmdp, &ptl)) continue; + __acquire(ptl); /* Conditionally acquired above */ /* * No need to call mmu_notifier_invalidate_range() as we are -- 2.15.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:55677 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753400AbdLFAmS (ORCPT ); Tue, 5 Dec 2017 19:42:18 -0500 From: Matthew Wilcox Subject: [PATCH v4 65/73] dax: Fix sparse warning Date: Tue, 5 Dec 2017 16:41:51 -0800 Message-Id: <20171206004159.3755-66-willy@infradead.org> In-Reply-To: <20171206004159.3755-1-willy@infradead.org> References: <20171206004159.3755-1-willy@infradead.org> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs Cc: Matthew Wilcox , Ross Zwisler , Jens Axboe , Rehas Sachdeva , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Matthew Wilcox sparse doesn't know that follow_pte_pmd conditionally acquires the ptl, so add an annotation to let it know what's going on. Signed-off-by: Matthew Wilcox --- fs/dax.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/dax.c b/fs/dax.c index c663d82e8ba3..7a86ff1153dd 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -531,6 +531,7 @@ static void dax_mapping_entry_mkclean(struct address_space *mapping, */ if (follow_pte_pmd(vma->vm_mm, address, &start, &end, &ptep, &pmdp, &ptl)) continue; + __acquire(ptl); /* Conditionally acquired above */ /* * No need to call mmu_notifier_invalidate_range() as we are -- 2.15.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f72.google.com (mail-pg0-f72.google.com [74.125.83.72]) by kanga.kvack.org (Postfix) with ESMTP id F1F216B028A for ; Tue, 5 Dec 2017 19:42:16 -0500 (EST) Received: by mail-pg0-f72.google.com with SMTP id i14so1500249pgf.13 for ; Tue, 05 Dec 2017 16:42:16 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [65.50.211.133]) by mx.google.com with ESMTPS id b73si912130pli.441.2017.12.05.16.42.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Dec 2017 16:42:15 -0800 (PST) From: Matthew Wilcox Subject: [PATCH v4 65/73] dax: Fix sparse warning Date: Tue, 5 Dec 2017 16:41:51 -0800 Message-Id: <20171206004159.3755-66-willy@infradead.org> In-Reply-To: <20171206004159.3755-1-willy@infradead.org> References: <20171206004159.3755-1-willy@infradead.org> Sender: owner-linux-mm@kvack.org List-ID: Cc: Matthew Wilcox , Ross Zwisler , Jens Axboe , Rehas Sachdeva , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Matthew Wilcox sparse doesn't know that follow_pte_pmd conditionally acquires the ptl, so add an annotation to let it know what's going on. Signed-off-by: Matthew Wilcox --- fs/dax.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/dax.c b/fs/dax.c index c663d82e8ba3..7a86ff1153dd 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -531,6 +531,7 @@ static void dax_mapping_entry_mkclean(struct address_space *mapping, */ if (follow_pte_pmd(vma->vm_mm, address, &start, &end, &ptep, &pmdp, &ptl)) continue; + __acquire(ptl); /* Conditionally acquired above */ /* * No need to call mmu_notifier_invalidate_range() as we are -- 2.15.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: [PATCH v4 65/73] dax: Fix sparse warning Date: Tue, 5 Dec 2017 16:41:51 -0800 Message-ID: <20171206004159.3755-66-willy@infradead.org> References: <20171206004159.3755-1-willy@infradead.org> Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jxcHLOxiA4QqUpiowHNo7PL7PKPF7K7FHtc1VFFYRM0=; b=pRTYGJi5uTMca0Pl4jeNSxxkz HIWbmybn/nqVPNOtuFft5nkfsDdUuZ+H3DdEjja8L4Fc5o12XfjP7mGbsNwc5L7rWYublJyWOaII3 Sm8Nf2MMOPGUrcuJZXjOzGfNuNdVNPsXccRlbJ7SgnMI6PVjq8OBSxBPf3sM/fLXxfepOznahiwou dv6cnYY2UCAn3YDW5zrIaTkVrqMRTGQXK/lICN6h/2vYWv9li9OYoly0/VEFsGHAMvp29nHr7cTqs Cx5Pgc3ZZ0PnVSZ7J/5VwVTlV0zWV6Zgj4s2x8jItsa6cmGaLt0HBEb23yMXd/lln/tOu5y1g/eHK In-Reply-To: <20171206004159.3755-1-willy@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Cc: Matthew Wilcox , Ross Zwisler , Jens Axboe , Rehas Sachdeva , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Matthew Wilcox sparse doesn't know that follow_pte_pmd conditionally acquires the ptl, so add an annotation to let it know what's going on. Signed-off-by: Matthew Wilcox --- fs/dax.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/dax.c b/fs/dax.c index c663d82e8ba3..7a86ff1153dd 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -531,6 +531,7 @@ static void dax_mapping_entry_mkclean(struct address_space *mapping, */ if (follow_pte_pmd(vma->vm_mm, address, &start, &end, &ptep, &pmdp, &ptl)) continue; + __acquire(ptl); /* Conditionally acquired above */ /* * No need to call mmu_notifier_invalidate_range() as we are -- 2.15.0