From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754774AbdLFEyn (ORCPT ); Tue, 5 Dec 2017 23:54:43 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:34965 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754730AbdLFEyk (ORCPT ); Tue, 5 Dec 2017 23:54:40 -0500 Date: Tue, 5 Dec 2017 20:54:35 -0800 From: Matthew Wilcox To: Michael Ellerman Cc: Cyril Hrubis , Michal Hocko , Kees Cook , Linux API , Khalid Aziz , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Abdul Haleem , Joel Stanley Subject: Re: [PATCH 0/2] mm: introduce MAP_FIXED_SAFE Message-ID: <20171206045433.GQ26021@bombadil.infradead.org> References: <20171129144219.22867-1-mhocko@kernel.org> <20171130065835.dbw4ajh5q5whikhf@dhcp22.suse.cz> <20171201152640.GA3765@rei> <87wp20e9wf.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wp20e9wf.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 06, 2017 at 03:51:44PM +1100, Michael Ellerman wrote: > Cyril Hrubis writes: > > > Hi! > >> > MAP_FIXED_UNIQUE > >> > MAP_FIXED_ONCE > >> > MAP_FIXED_FRESH > >> > >> Well, I can open a poll for the best name, but none of those you are > >> proposing sound much better to me. Yeah, naming sucks... > > > > Given that MAP_FIXED replaces the previous mapping MAP_FIXED_NOREPLACE > > would probably be a best fit. > > Yeah that could work. > > I prefer "no clobber" as I just suggested, because the existing > MAP_FIXED doesn't politely "replace" a mapping, it destroys the current > one - which you or another thread may be using - and clobbers it with > the new one. It's longer than MAP_FIXED_WEAK :-P You'd have to be pretty darn strong to clobber an existing mapping. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 0/2] mm: introduce MAP_FIXED_SAFE Date: Tue, 5 Dec 2017 20:54:35 -0800 Message-ID: <20171206045433.GQ26021@bombadil.infradead.org> References: <20171129144219.22867-1-mhocko@kernel.org> <20171130065835.dbw4ajh5q5whikhf@dhcp22.suse.cz> <20171201152640.GA3765@rei> <87wp20e9wf.fsf@concordia.ellerman.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87wp20e9wf.fsf@concordia.ellerman.id.au> Sender: owner-linux-mm@kvack.org To: Michael Ellerman Cc: Cyril Hrubis , Michal Hocko , Kees Cook , Linux API , Khalid Aziz , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Abdul Haleem , Joel Stanley List-Id: linux-api@vger.kernel.org On Wed, Dec 06, 2017 at 03:51:44PM +1100, Michael Ellerman wrote: > Cyril Hrubis writes: > > > Hi! > >> > MAP_FIXED_UNIQUE > >> > MAP_FIXED_ONCE > >> > MAP_FIXED_FRESH > >> > >> Well, I can open a poll for the best name, but none of those you are > >> proposing sound much better to me. Yeah, naming sucks... > > > > Given that MAP_FIXED replaces the previous mapping MAP_FIXED_NOREPLACE > > would probably be a best fit. > > Yeah that could work. > > I prefer "no clobber" as I just suggested, because the existing > MAP_FIXED doesn't politely "replace" a mapping, it destroys the current > one - which you or another thread may be using - and clobbers it with > the new one. It's longer than MAP_FIXED_WEAK :-P You'd have to be pretty darn strong to clobber an existing mapping. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org