From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-mtd@lists.infradead.org
Cc: Richard Weinberger <richard@nod.at>,
kernel@pengutronix.de, Han Xu <han.xu@nxp.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: GPMI nand driver cleanup
Date: Wed, 6 Dec 2017 10:19:15 +0100 [thread overview]
Message-ID: <20171206091925.5810-1-s.hauer@pengutronix.de> (raw)
This series contains several cleanup patches for the GPMI nand driver.
The code is unnecessarily complicated in several places. For example
the private driver data struct contains variables which should better
be passed around between functions to make the lifetime of these
variables clear. Also there are functions which take up to eight
arguements and are so trivial that they are shorter and easier to
read if open coded in the caller.
The series also contains the bugfix in 1/10 which I previously sent
separately.
The driver has more room for cleanups. The splitting up into gpmi-lib
and gpmi-nand seems rather unnecessary. The gpmi-lib functions call
back into gpmi-nand which contradicts the principle of a lib. Also
the functions in gpmi-lib all have a proper gpmi_ prefix, but the
functions exported from gpmi-nand.c do not have a prefix at all. In
several cases gpmi-nand.c only contains a wrapper around functions
in gpmi-lib.c. I tend to merge gpmi-nand.c and gpmi-lib.c into a
single file (which would be around 3.7k lines then). I think this
would make the driver a lot more readable, but of course also produces
some churn. Before doing this I want to ask for other opinions to avoid
putting the work to /dev/null later.
Sascha
----------------------------------------------------------------
Sascha Hauer (10):
mtd: nand: gpmi: Fix failure when a erased page has a bitflip at BBM
mtd: nand: gpmi: Utilize hardware to detect bitflips in erased blocks
mtd: nand: gpmi: drop dma_ops_type
mtd: nand: gpmi: pass buffer and len around
mtd: nand: gpmi: put only once used functions inline
mtd: nand: gpmi: remove direct_dma_map_ok from driver data struct
mtd: nand: gpmi: return valid value from bch_set_geometry()
mtd: nand: gpmi: remove unnecessary variables
mtd: nand: gpmi: rework gpmi_ecc_write_page
mtd: nand: gpmi: return error code from gpmi_ecc_write_page
drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 55 +++--
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 383 ++++++++-------------------------
drivers/mtd/nand/gpmi-nand/gpmi-nand.h | 24 +--
3 files changed, 128 insertions(+), 334 deletions(-)
next reply other threads:[~2017-12-06 9:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 9:19 Sascha Hauer [this message]
2017-12-06 9:19 ` [PATCH 01/10] mtd: nand: gpmi: Fix failure when a erased page has a bitflip at BBM Sascha Hauer
2017-12-06 9:19 ` [PATCH 02/10] mtd: nand: gpmi: Utilize hardware to detect bitflips in erased blocks Sascha Hauer
2017-12-06 9:27 ` Boris Brezillon
2017-12-06 15:28 ` Sascha Hauer
2017-12-06 15:34 ` Boris Brezillon
2017-12-08 10:21 ` Sascha Hauer
2017-12-08 10:35 ` Boris Brezillon
2017-12-08 10:57 ` Sascha Hauer
2017-12-06 9:19 ` [PATCH 03/10] mtd: nand: gpmi: drop dma_ops_type Sascha Hauer
2017-12-06 9:19 ` [PATCH 04/10] mtd: nand: gpmi: pass buffer and len around Sascha Hauer
2017-12-06 9:19 ` [PATCH 05/10] mtd: nand: gpmi: put only once used functions inline Sascha Hauer
2017-12-06 9:19 ` [PATCH 06/10] mtd: nand: gpmi: remove direct_dma_map_ok from driver data struct Sascha Hauer
2017-12-06 9:19 ` [PATCH 07/10] mtd: nand: gpmi: return valid value from bch_set_geometry() Sascha Hauer
2017-12-06 9:19 ` [PATCH 08/10] mtd: nand: gpmi: remove unnecessary variables Sascha Hauer
2017-12-06 9:19 ` [PATCH 09/10] mtd: nand: gpmi: rework gpmi_ecc_write_page Sascha Hauer
2017-12-06 14:57 ` Sascha Hauer
2017-12-06 9:19 ` [PATCH 10/10] mtd: nand: gpmi: return error code from gpmi_ecc_write_page Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206091925.5810-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=boris.brezillon@free-electrons.com \
--cc=han.xu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.