From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752079AbdLFNxw (ORCPT ); Wed, 6 Dec 2017 08:53:52 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:53090 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680AbdLFNxt (ORCPT ); Wed, 6 Dec 2017 08:53:49 -0500 Date: Wed, 6 Dec 2017 14:53:55 +0100 From: Greg Kroah-Hartman To: Heiko Carstens Cc: Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Christian Borntraeger , Martin Schwidefsky Subject: Re: [PATCH 4.4 02/96] s390/runtime instrumention: fix possible memory corruption Message-ID: <20171206135355.GA32566@kroah.com> References: <20171128100503.067621614@linuxfoundation.org> <20171128100503.204142514@linuxfoundation.org> <1512493352.18523.180.camel@codethink.co.uk> <20171205170847.GA22747@kroah.com> <20171205181534.GA3092@osiris> <20171206074453.GB31086@kroah.com> <20171206133058.GB6933@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171206133058.GB6933@osiris> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 06, 2017 at 02:30:58PM +0100, Heiko Carstens wrote: > On Wed, Dec 06, 2017 at 08:44:53AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Dec 05, 2017 at 07:15:34PM +0100, Heiko Carstens wrote: > > > On Tue, Dec 05, 2017 at 06:08:47PM +0100, Greg Kroah-Hartman wrote: > > > > On Tue, Dec 05, 2017 at 05:02:32PM +0000, Ben Hutchings wrote: > > > > > On Tue, 2017-11-28 at 11:22 +0100, Greg Kroah-Hartman wrote: > > > > > > 4.4-stable review patch.  If anyone has any objections, please let me know. > > > > > > > > > > > > ------------------ > > > > > > > > > > > > From: Heiko Carstens > > > > > > > > > > > > commit d6e646ad7cfa7034d280459b2b2546288f247144 upstream. > > > > > [...] > > > > > > --- a/arch/s390/kernel/runtime_instr.c > > > > > > +++ b/arch/s390/kernel/runtime_instr.c > > > > > > @@ -47,11 +47,13 @@ void exit_thread_runtime_instr(void) > > > > > >  { > > > > > >   struct task_struct *task = current; > > > > > >   > > > > > > + preempt_disable(); > > > > > >   if (!task->thread.ri_cb) > > > > > >   return; > > > > > > > > > > This return path now leaves preemption disabled. This seems to have > > > > > been fixed upstream by commit 8d9047f8b967 "s390/runtime > > > > > instrumentation: simplify task exit handling". > > > > > > > > "simplify" doesn't seem to imply "fixes a bug" :) > > > > > > Indeed ;) That where two subsequent patches, but incorrectly split by me... > > > > > > > Heiko, should I also queue this patch up? > > > > > > Yes, please. > > > > It doesn't apply to 4.9-stable or 4.4-stable, can you provide a working > > backport? > > Below is the patch against 4.4-stable: This and the 4.9 patch now queued up, thanks. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:53090 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680AbdLFNxt (ORCPT ); Wed, 6 Dec 2017 08:53:49 -0500 Date: Wed, 6 Dec 2017 14:53:55 +0100 From: Greg Kroah-Hartman To: Heiko Carstens Cc: Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Christian Borntraeger , Martin Schwidefsky Subject: Re: [PATCH 4.4 02/96] s390/runtime instrumention: fix possible memory corruption Message-ID: <20171206135355.GA32566@kroah.com> References: <20171128100503.067621614@linuxfoundation.org> <20171128100503.204142514@linuxfoundation.org> <1512493352.18523.180.camel@codethink.co.uk> <20171205170847.GA22747@kroah.com> <20171205181534.GA3092@osiris> <20171206074453.GB31086@kroah.com> <20171206133058.GB6933@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171206133058.GB6933@osiris> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Dec 06, 2017 at 02:30:58PM +0100, Heiko Carstens wrote: > On Wed, Dec 06, 2017 at 08:44:53AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Dec 05, 2017 at 07:15:34PM +0100, Heiko Carstens wrote: > > > On Tue, Dec 05, 2017 at 06:08:47PM +0100, Greg Kroah-Hartman wrote: > > > > On Tue, Dec 05, 2017 at 05:02:32PM +0000, Ben Hutchings wrote: > > > > > On Tue, 2017-11-28 at 11:22 +0100, Greg Kroah-Hartman wrote: > > > > > > 4.4-stable review patch.��If anyone has any objections, please let me know. > > > > > > > > > > > > ------------------ > > > > > > > > > > > > From: Heiko Carstens > > > > > > > > > > > > commit d6e646ad7cfa7034d280459b2b2546288f247144 upstream. > > > > > [...] > > > > > > --- a/arch/s390/kernel/runtime_instr.c > > > > > > +++ b/arch/s390/kernel/runtime_instr.c > > > > > > @@ -47,11 +47,13 @@ void exit_thread_runtime_instr(void) > > > > > > �{ > > > > > > � struct task_struct *task = current; > > > > > > � > > > > > > + preempt_disable(); > > > > > > � if (!task->thread.ri_cb) > > > > > > � return; > > > > > > > > > > This return path now leaves preemption disabled. This seems to have > > > > > been fixed upstream by commit 8d9047f8b967 "s390/runtime > > > > > instrumentation: simplify task exit handling". > > > > > > > > "simplify" doesn't seem to imply "fixes a bug" :) > > > > > > Indeed ;) That where two subsequent patches, but incorrectly split by me... > > > > > > > Heiko, should I also queue this patch up? > > > > > > Yes, please. > > > > It doesn't apply to 4.9-stable or 4.4-stable, can you provide a working > > backport? > > Below is the patch against 4.4-stable: This and the 4.9 patch now queued up, thanks. greg k-h