From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5F8042217CE28 for ; Wed, 6 Dec 2017 12:43:28 -0800 (PST) Date: Wed, 6 Dec 2017 12:47:49 -0800 From: "Darrick J. Wong" Subject: Re: [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code Message-ID: <20171206204749.GM19219@magnolia> References: <20171205235651.17102-1-ross.zwisler@linux.intel.com> <20171205235651.17102-2-ross.zwisler@linux.intel.com> <20171206002743.GC5858@dastard> <20171206201014.GA27401@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20171206201014.GA27401@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Ross Zwisler Cc: Jan Kara , linux-nvdimm , Dave Chinner , fstests , linux-xfs List-ID: T24gV2VkLCBEZWMgMDYsIDIwMTcgYXQgMDE6MTA6MTRQTSAtMDcwMCwgUm9zcyBad2lzbGVyIHdy b3RlOgo+IE9uIFdlZCwgRGVjIDA2LCAyMDE3IGF0IDExOjI3OjQzQU0gKzExMDAsIERhdmUgQ2hp bm5lciB3cm90ZToKPiA+IE9uIFR1ZSwgRGVjIDA1LCAyMDE3IGF0IDA0OjU2OjQ5UE0gLTA3MDAs IFJvc3MgWndpc2xlciB3cm90ZToKPiA+ID4gSSByZWNlbnRseSB1cGdyYWRlZCBteSBjb21waWxl ciBmcm9tCj4gPiA+IAlnY2MgKEdDQykgNi40LjEgMjAxNzA3MjcgKFJlZCBIYXQgNi40LjEtMSkK PiA+ID4gdG8KPiA+ID4gCWdjYyAoR0NDKSA3LjIuMSAyMDE3MDkxNSAoUmVkIEhhdCA3LjIuMS0y KQo+ID4gPiBhbmQgc3RhcnRlZCBnZXR0aW5nIGEgYnVuY2ggb2YgY29tcGlsZXIgd2FybmluZ3Mg aW4gaW8vZnNtYXAuYzoKPiA+ID4gCj4gPiA+ICAgZnNtYXAuYzogSW4gZnVuY3Rpb24g4oCYZnNt YXBfZuKAmToKPiA+ID4gICBmc21hcC5jOjIyODo0MDogd2FybmluZzog4oCYJWxsZOKAmSBkaXJl Y3RpdmUgb3V0cHV0IG1heSBiZSB0cnVuY2F0ZWQgd3JpdGluZwo+ID4gPiAgIGJldHdlZW4gMSBh bmQgMTcgYnl0ZXMgaW50byBhIHJlZ2lvbiBvZiBzaXplIGJldHdlZW4gMTIgYW5kIDI4Cj4gPiA+ ICAgWy1XZm9ybWF0LXRydW5jYXRpb249XQo+ID4gPiAgICAgIHNucHJpbnRmKGJidWYsIHNpemVv ZihiYnVmKSwgIlslbGxkLi4lbGxkXToiLAo+ID4gPiAgIF5+fn4KPiA+ID4gICBmc21hcC5jOjIy ODozMjogbm90ZTogZGlyZWN0aXZlIGFyZ3VtZW50IGluIHRoZSByYW5nZSBbMCwgMzYwMjg3OTcw MTg5NjM5NjddCj4gPiA+ICAgICAgc25wcmludGYoYmJ1Ziwgc2l6ZW9mKGJidWYpLCAiWyVsbGQu LiVsbGRdOiIsCj4gPiA+ICAgXn5+fn5+fn5+fn5+fn5+Cj4gPiA+ICAgZnNtYXAuYzoyMjg6Mzog bm90ZTog4oCYc25wcmludGbigJkgb3V0cHV0IGJldHdlZW4gOCBhbmQgNDAgYnl0ZXMgaW50byBh Cj4gPiA+ICAgZGVzdGluYXRpb24gb2Ygc2l6ZSAzMgo+ID4gPiAgICAgIHNucHJpbnRmKGJidWYs IHNpemVvZihiYnVmKSwgIlslbGxkLi4lbGxkXToiLAo+ID4gPiAgICAgIF5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+ID4gPiAgIChsb25nIGxvbmcpQlRPQkJU KHAtPmZtcl9waHlzaWNhbCksCj4gPiA+ICAgfn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fgo+ID4gPiAgIChsb25nIGxvbmcpQlRPQkJUKHAtPmZtcl9waHlzaWNhbCArIHAtPmZtcl9s ZW5ndGggLSAxKSk7Cj4gPiA+ICAgfn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+Cj4gPiA+IAo+ID4gPiBUaGUgaXNzdWUgaXMgdGhhdCAnYmJ1Zicg aXMgb25seSBkZWZpbmVkIHRvIGJlIDMyIGNoYXJhY3RlcnMgd2lkZSwgYnV0IGVhY2gKPiA+ID4g c2lnbmVkIGxvbmcgbG9uZyBjYW4gcG90ZW50aWFsbHkgcHJpbnQgYXMgbWFueSBhcyAxOSBjaGFy YWN0ZXJzCj4gPiA+ICg5MjIzMzcyMDM2ODU0Nzc1ODA3IGlzIHRoZSBtYXggdmFsdWUpLiAgVGhl IGZvcm1hdCB3ZSdyZSB1c2luZyBmb3IgYmJ1ZiBpcwo+ID4gPiAiWyVsbGQuLiVsbGRdOiIgd2hp Y2ggaGFzIDIgc2lnbmVkIGxvbmcgbG9uZ3MgcGx1cyA2IG90aGVyIGNoYXJhY3RlcnMKPiA+ID4g IlsuLl06XDAiLCB3aGljaCBtZWFucyBpdCdzIHBvc3NpYmxlIHdlJ2xsIHByaW50IHVwIHRvIDQ0 IGNoYXJhY3RlcnMsCj4gPiA+IG92ZXJmbG93aW5nIG91ciAzMiBjaGFyIGJ1ZmZlci4KPiA+ID4g Cj4gPiA+IEZpeCB0aGlzIGJ5IGJ1bXBpbmcgYWxsIHRoZSBidWZmZXIgc2l6ZXMgaW4gZHVtcF9t YXBfdmVyYm9zZSgpIHRvIDY0Cj4gPiA+IGNoYXJhY3RlcnMuCj4gPiA+IAo+ID4gPiBTaWduZWQt b2ZmLWJ5OiBSb3NzIFp3aXNsZXIgPHJvc3Muendpc2xlckBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ IENjOiBEYXJyaWNrIEouIFdvbmcgPGRhcnJpY2sud29uZ0BvcmFjbGUuY29tPgo+ID4gPiBGaXhl czogM2ZjYWI1NDlhMjM0ICgieGZzX2lvOiBzdXBwb3J0IHRoZSBuZXcgZ2V0ZnNtYXAgaW9jdGwi KQo+ID4gCj4gPiBGWUksIEkgcG9zdGVkIGEgZml4IGZvciB0aGlzIHdlZWtzIGFnby4gSSB0aGlu ayBFcmljIGhhcyBhbHJlYWR5Cj4gPiBwaWNrZWQgaXQgdXAsIGJ1dCBpdCBoYXNuJ3QgYmVlbiBw dXNoZWQgb3V0IGludG8gdGhlIGZvci1uZXh0IGJyYW5jaAo+ID4geWV0Lgo+IAo+IEknbSBzZWVp bmcgc2ltaWxhciBuZXcgY29tcGlsZXIgd2FybmluZ3Mgd2hlbiBjb21waWxpbmcgeGZzdGVzdHM6 Cj4gCj4gd3JpdGVfbG9nLmM6IEluIGZ1bmN0aW9uIOKAmHdsb2dfb3BlbuKAmToKPiB3cml0ZV9s b2cuYzoxMjQ6Mzc6IHdhcm5pbmc6IOKAmCVz4oCZIGRpcmVjdGl2ZSB3cml0aW5nIHVwIHRvIDEw MjMgYnl0ZXMgaW50byBhIHJlZ2lvbiBvZiBzaXplIDIyNCBbLVdmb3JtYXQtb3ZlcmZsb3c9XQo+ ICAgICAiQ291bGQgbm90IG9wZW4gd3JpdGVfbG9nIC0gb3BlbiglcywgJSNvLCAlI28pIGZhaWxl ZDogICVzXG4iLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefgo+IHdy aXRlX2xvZy5jOjEyNDo0OiBub3RlOiBkaXJlY3RpdmUgYXJndW1lbnQgaW4gdGhlIHJhbmdlIFsx MDg5LCAyMDQ3XQo+ICAgICAiQ291bGQgbm90IG9wZW4gd3JpdGVfbG9nIC0gb3BlbiglcywgJSNv LCAlI28pIGZhaWxlZDogICVzXG4iLAo+ICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4gCj4gZXRjLgo+IAo+IEkgZG9uJ3Qg c2VlIGFueSBwYXRjaGVzIHBvc3RlZCB0aGF0IGZpeCB0aGVzZSwgYXMgb2YgeWV0LiAgQXMgZmFy IGFzIHlvdSBrbm93LAo+IGFtIEkgY29ycmVjdCBpbiB0aGlua2luZyB0aGF0IHRoZXNlIHN0aWxs IG5lZWQgdG8gYmUgZml4ZWQ/CgpJdCBzdXJlIGxvb2tzIHRoYXQgd2F5LgoKLS1ECgo+IC0gUm9z cwo+IC0tCj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVu c3Vic2NyaWJlIGxpbnV4LXhmcyIgaW4KPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jk b21vQHZnZXIua2VybmVsLm9yZwo+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1udmRpbW0gbWFpbGluZyBsaXN0CkxpbnV4LW52 ZGltbUBsaXN0cy4wMS5vcmcKaHR0cHM6Ly9saXN0cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1udmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from userp2120.oracle.com ([156.151.31.85]:47864 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752212AbdLFUsE (ORCPT ); Wed, 6 Dec 2017 15:48:04 -0500 Date: Wed, 6 Dec 2017 12:47:49 -0800 From: "Darrick J. Wong" Subject: Re: [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code Message-ID: <20171206204749.GM19219@magnolia> References: <20171205235651.17102-1-ross.zwisler@linux.intel.com> <20171205235651.17102-2-ross.zwisler@linux.intel.com> <20171206002743.GC5858@dastard> <20171206201014.GA27401@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171206201014.GA27401@linux.intel.com> Sender: fstests-owner@vger.kernel.org Content-Transfer-Encoding: quoted-printable To: Ross Zwisler Cc: Dave Chinner , linux-xfs , linux-nvdimm , fstests , Jan Kara , Dan Williams List-ID: On Wed, Dec 06, 2017 at 01:10:14PM -0700, Ross Zwisler wrote: > On Wed, Dec 06, 2017 at 11:27:43AM +1100, Dave Chinner wrote: > > On Tue, Dec 05, 2017 at 04:56:49PM -0700, Ross Zwisler wrote: > > > I recently upgraded my compiler from > > > gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1) > > > to > > > gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2) > > > and started getting a bunch of compiler warnings in io/fsmap.c: > > >=20 > > > fsmap.c: In function =E2=80=98fsmap_f=E2=80=99: > > > fsmap.c:228:40: warning: =E2=80=98%lld=E2=80=99 directive output = may be truncated writing > > > between 1 and 17 bytes into a region of size between 12 and 28 > > > [-Wformat-truncation=3D] > > > snprintf(bbuf, sizeof(bbuf), "[%lld..%lld]:", > > > ^~~~ > > > fsmap.c:228:32: note: directive argument in the range [0, 3602879= 7018963967] > > > snprintf(bbuf, sizeof(bbuf), "[%lld..%lld]:", > > > ^~~~~~~~~~~~~~~ > > > fsmap.c:228:3: note: =E2=80=98snprintf=E2=80=99 output between 8 = and 40 bytes into a > > > destination of size 32 > > > snprintf(bbuf, sizeof(bbuf), "[%lld..%lld]:", > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > (long long)BTOBBT(p->fmr_physical), > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > (long long)BTOBBT(p->fmr_physical + p->fmr_length - 1)); > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > >=20 > > > The issue is that 'bbuf' is only defined to be 32 characters wide, = but each > > > signed long long can potentially print as many as 19 characters > > > (9223372036854775807 is the max value). The format we're using for= bbuf is > > > "[%lld..%lld]:" which has 2 signed long longs plus 6 other characte= rs > > > "[..]:\0", which means it's possible we'll print up to 44 character= s, > > > overflowing our 32 char buffer. > > >=20 > > > Fix this by bumping all the buffer sizes in dump_map_verbose() to 6= 4 > > > characters. > > >=20 > > > Signed-off-by: Ross Zwisler > > > Cc: Darrick J. Wong > > > Fixes: 3fcab549a234 ("xfs_io: support the new getfsmap ioctl") > >=20 > > FYI, I posted a fix for this weeks ago. I think Eric has already > > picked it up, but it hasn't been pushed out into the for-next branch > > yet. >=20 > I'm seeing similar new compiler warnings when compiling xfstests: >=20 > write_log.c: In function =E2=80=98wlog_open=E2=80=99: > write_log.c:124:37: warning: =E2=80=98%s=E2=80=99 directive writing up = to 1023 bytes into a region of size 224 [-Wformat-overflow=3D] > "Could not open write_log - open(%s, %#o, %#o) failed: %s\n", > ^~ > write_log.c:124:4: note: directive argument in the range [1089, 2047] > "Could not open write_log - open(%s, %#o, %#o) failed: %s\n", > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > etc. >=20 > I don't see any patches posted that fix these, as of yet. As far as yo= u know, > am I correct in thinking that these still need to be fixed? It sure looks that way. --D > - Ross > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html