From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BBF5E2217CE25 for ; Wed, 6 Dec 2017 12:53:41 -0800 (PST) Date: Wed, 6 Dec 2017 13:58:12 -0700 From: Ross Zwisler Subject: Re: [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code Message-ID: <20171206205812.GA32648@linux.intel.com> References: <20171205235651.17102-1-ross.zwisler@linux.intel.com> <20171205235651.17102-2-ross.zwisler@linux.intel.com> <20171206002743.GC5858@dastard> <20171206201014.GA27401@linux.intel.com> <20171206204749.GM19219@magnolia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20171206204749.GM19219@magnolia> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Darrick J. Wong" Cc: Jan Kara , linux-nvdimm , Dave Chinner , fstests , linux-xfs List-ID: T24gV2VkLCBEZWMgMDYsIDIwMTcgYXQgMTI6NDc6NDlQTSAtMDgwMCwgRGFycmljayBKLiBXb25n IHdyb3RlOgo+IE9uIFdlZCwgRGVjIDA2LCAyMDE3IGF0IDAxOjEwOjE0UE0gLTA3MDAsIFJvc3Mg Wndpc2xlciB3cm90ZToKPiA+IE9uIFdlZCwgRGVjIDA2LCAyMDE3IGF0IDExOjI3OjQzQU0gKzEx MDAsIERhdmUgQ2hpbm5lciB3cm90ZToKPiA+ID4gT24gVHVlLCBEZWMgMDUsIDIwMTcgYXQgMDQ6 NTY6NDlQTSAtMDcwMCwgUm9zcyBad2lzbGVyIHdyb3RlOgo+ID4gPiA+IEkgcmVjZW50bHkgdXBn cmFkZWQgbXkgY29tcGlsZXIgZnJvbQo+ID4gPiA+IAlnY2MgKEdDQykgNi40LjEgMjAxNzA3Mjcg KFJlZCBIYXQgNi40LjEtMSkKPiA+ID4gPiB0bwo+ID4gPiA+IAlnY2MgKEdDQykgNy4yLjEgMjAx NzA5MTUgKFJlZCBIYXQgNy4yLjEtMikKPiA+ID4gPiBhbmQgc3RhcnRlZCBnZXR0aW5nIGEgYnVu Y2ggb2YgY29tcGlsZXIgd2FybmluZ3MgaW4gaW8vZnNtYXAuYzoKPiA+ID4gPiAKPiA+ID4gPiAg IGZzbWFwLmM6IEluIGZ1bmN0aW9uIOKAmGZzbWFwX2bigJk6Cj4gPiA+ID4gICBmc21hcC5jOjIy ODo0MDogd2FybmluZzog4oCYJWxsZOKAmSBkaXJlY3RpdmUgb3V0cHV0IG1heSBiZSB0cnVuY2F0 ZWQgd3JpdGluZwo+ID4gPiA+ICAgYmV0d2VlbiAxIGFuZCAxNyBieXRlcyBpbnRvIGEgcmVnaW9u IG9mIHNpemUgYmV0d2VlbiAxMiBhbmQgMjgKPiA+ID4gPiAgIFstV2Zvcm1hdC10cnVuY2F0aW9u PV0KPiA+ID4gPiAgICAgIHNucHJpbnRmKGJidWYsIHNpemVvZihiYnVmKSwgIlslbGxkLi4lbGxk XToiLAo+ID4gPiA+ICAgXn5+fgo+ID4gPiA+ICAgZnNtYXAuYzoyMjg6MzI6IG5vdGU6IGRpcmVj dGl2ZSBhcmd1bWVudCBpbiB0aGUgcmFuZ2UgWzAsIDM2MDI4Nzk3MDE4OTYzOTY3XQo+ID4gPiA+ ICAgICAgc25wcmludGYoYmJ1Ziwgc2l6ZW9mKGJidWYpLCAiWyVsbGQuLiVsbGRdOiIsCj4gPiA+ ID4gICBefn5+fn5+fn5+fn5+fn4KPiA+ID4gPiAgIGZzbWFwLmM6MjI4OjM6IG5vdGU6IOKAmHNu cHJpbnRm4oCZIG91dHB1dCBiZXR3ZWVuIDggYW5kIDQwIGJ5dGVzIGludG8gYQo+ID4gPiA+ICAg ZGVzdGluYXRpb24gb2Ygc2l6ZSAzMgo+ID4gPiA+ICAgICAgc25wcmludGYoYmJ1Ziwgc2l6ZW9m KGJidWYpLCAiWyVsbGQuLiVsbGRdOiIsCj4gPiA+ID4gICAgICBefn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KPiA+ID4gPiAgIChsb25nIGxvbmcpQlRPQkJUKHAt PmZtcl9waHlzaWNhbCksCj4gPiA+ID4gICB+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+Cj4gPiA+ID4gICAobG9uZyBsb25nKUJUT0JCVChwLT5mbXJfcGh5c2ljYWwgKyBwLT5mbXJf bGVuZ3RoIC0gMSkpOwo+ID4gPiA+ICAgfn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4gPiA+ID4gCj4gPiA+ID4gVGhlIGlzc3VlIGlzIHRoYXQg J2JidWYnIGlzIG9ubHkgZGVmaW5lZCB0byBiZSAzMiBjaGFyYWN0ZXJzIHdpZGUsIGJ1dCBlYWNo Cj4gPiA+ID4gc2lnbmVkIGxvbmcgbG9uZyBjYW4gcG90ZW50aWFsbHkgcHJpbnQgYXMgbWFueSBh cyAxOSBjaGFyYWN0ZXJzCj4gPiA+ID4gKDkyMjMzNzIwMzY4NTQ3NzU4MDcgaXMgdGhlIG1heCB2 YWx1ZSkuICBUaGUgZm9ybWF0IHdlJ3JlIHVzaW5nIGZvciBiYnVmIGlzCj4gPiA+ID4gIlslbGxk Li4lbGxkXToiIHdoaWNoIGhhcyAyIHNpZ25lZCBsb25nIGxvbmdzIHBsdXMgNiBvdGhlciBjaGFy YWN0ZXJzCj4gPiA+ID4gIlsuLl06XDAiLCB3aGljaCBtZWFucyBpdCdzIHBvc3NpYmxlIHdlJ2xs IHByaW50IHVwIHRvIDQ0IGNoYXJhY3RlcnMsCj4gPiA+ID4gb3ZlcmZsb3dpbmcgb3VyIDMyIGNo YXIgYnVmZmVyLgo+ID4gPiA+IAo+ID4gPiA+IEZpeCB0aGlzIGJ5IGJ1bXBpbmcgYWxsIHRoZSBi dWZmZXIgc2l6ZXMgaW4gZHVtcF9tYXBfdmVyYm9zZSgpIHRvIDY0Cj4gPiA+ID4gY2hhcmFjdGVy cy4KPiA+ID4gPiAKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBSb3NzIFp3aXNsZXIgPHJvc3Muendp c2xlckBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gQ2M6IERhcnJpY2sgSi4gV29uZyA8ZGFycmlj ay53b25nQG9yYWNsZS5jb20+Cj4gPiA+ID4gRml4ZXM6IDNmY2FiNTQ5YTIzNCAoInhmc19pbzog c3VwcG9ydCB0aGUgbmV3IGdldGZzbWFwIGlvY3RsIikKPiA+ID4gCj4gPiA+IEZZSSwgSSBwb3N0 ZWQgYSBmaXggZm9yIHRoaXMgd2Vla3MgYWdvLiBJIHRoaW5rIEVyaWMgaGFzIGFscmVhZHkKPiA+ ID4gcGlja2VkIGl0IHVwLCBidXQgaXQgaGFzbid0IGJlZW4gcHVzaGVkIG91dCBpbnRvIHRoZSBm b3ItbmV4dCBicmFuY2gKPiA+ID4geWV0Lgo+ID4gCj4gPiBJJ20gc2VlaW5nIHNpbWlsYXIgbmV3 IGNvbXBpbGVyIHdhcm5pbmdzIHdoZW4gY29tcGlsaW5nIHhmc3Rlc3RzOgo+ID4gCj4gPiB3cml0 ZV9sb2cuYzogSW4gZnVuY3Rpb24g4oCYd2xvZ19vcGVu4oCZOgo+ID4gd3JpdGVfbG9nLmM6MTI0 OjM3OiB3YXJuaW5nOiDigJglc+KAmSBkaXJlY3RpdmUgd3JpdGluZyB1cCB0byAxMDIzIGJ5dGVz IGludG8gYSByZWdpb24gb2Ygc2l6ZSAyMjQgWy1XZm9ybWF0LW92ZXJmbG93PV0KPiA+ICAgICAi Q291bGQgbm90IG9wZW4gd3JpdGVfbG9nIC0gb3BlbiglcywgJSNvLCAlI28pIGZhaWxlZDogICVz XG4iLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+Cj4gPiB3cml0 ZV9sb2cuYzoxMjQ6NDogbm90ZTogZGlyZWN0aXZlIGFyZ3VtZW50IGluIHRoZSByYW5nZSBbMTA4 OSwgMjA0N10KPiA+ICAgICAiQ291bGQgbm90IG9wZW4gd3JpdGVfbG9nIC0gb3BlbiglcywgJSNv LCAlI28pIGZhaWxlZDogICVzXG4iLAo+ID4gICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KPiA+IAo+ID4gZXRjLgo+ID4gCj4g PiBJIGRvbid0IHNlZSBhbnkgcGF0Y2hlcyBwb3N0ZWQgdGhhdCBmaXggdGhlc2UsIGFzIG9mIHll dC4gIEFzIGZhciBhcyB5b3Uga25vdywKPiA+IGFtIEkgY29ycmVjdCBpbiB0aGlua2luZyB0aGF0 IHRoZXNlIHN0aWxsIG5lZWQgdG8gYmUgZml4ZWQ/Cj4gCj4gSXQgc3VyZSBsb29rcyB0aGF0IHdh eS4KCkNvb2wsIHRoYW5rcy4gIEknbGwgdGFrZSBhIGNyYWNrIGF0IHRoZW0uCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW52ZGltbSBtYWlsaW5n IGxpc3QKTGludXgtbnZkaW1tQGxpc3RzLjAxLm9yZwpodHRwczovL2xpc3RzLjAxLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LW52ZGltbQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com ([134.134.136.100]:34940 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbdLFU6O (ORCPT ); Wed, 6 Dec 2017 15:58:14 -0500 Date: Wed, 6 Dec 2017 13:58:12 -0700 From: Ross Zwisler Subject: Re: [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code Message-ID: <20171206205812.GA32648@linux.intel.com> References: <20171205235651.17102-1-ross.zwisler@linux.intel.com> <20171205235651.17102-2-ross.zwisler@linux.intel.com> <20171206002743.GC5858@dastard> <20171206201014.GA27401@linux.intel.com> <20171206204749.GM19219@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171206204749.GM19219@magnolia> Sender: fstests-owner@vger.kernel.org Content-Transfer-Encoding: quoted-printable To: "Darrick J. Wong" Cc: Ross Zwisler , Dave Chinner , linux-xfs , linux-nvdimm , fstests , Jan Kara , Dan Williams List-ID: On Wed, Dec 06, 2017 at 12:47:49PM -0800, Darrick J. Wong wrote: > On Wed, Dec 06, 2017 at 01:10:14PM -0700, Ross Zwisler wrote: > > On Wed, Dec 06, 2017 at 11:27:43AM +1100, Dave Chinner wrote: > > > On Tue, Dec 05, 2017 at 04:56:49PM -0700, Ross Zwisler wrote: > > > > I recently upgraded my compiler from > > > > gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1) > > > > to > > > > gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2) > > > > and started getting a bunch of compiler warnings in io/fsmap.c: > > > >=20 > > > > fsmap.c: In function =E2=80=98fsmap_f=E2=80=99: > > > > fsmap.c:228:40: warning: =E2=80=98%lld=E2=80=99 directive outpu= t may be truncated writing > > > > between 1 and 17 bytes into a region of size between 12 and 28 > > > > [-Wformat-truncation=3D] > > > > snprintf(bbuf, sizeof(bbuf), "[%lld..%lld]:", > > > > ^~~~ > > > > fsmap.c:228:32: note: directive argument in the range [0, 36028= 797018963967] > > > > snprintf(bbuf, sizeof(bbuf), "[%lld..%lld]:", > > > > ^~~~~~~~~~~~~~~ > > > > fsmap.c:228:3: note: =E2=80=98snprintf=E2=80=99 output between = 8 and 40 bytes into a > > > > destination of size 32 > > > > snprintf(bbuf, sizeof(bbuf), "[%lld..%lld]:", > > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > (long long)BTOBBT(p->fmr_physical), > > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > (long long)BTOBBT(p->fmr_physical + p->fmr_length - 1)); > > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > >=20 > > > > The issue is that 'bbuf' is only defined to be 32 characters wide= , but each > > > > signed long long can potentially print as many as 19 characters > > > > (9223372036854775807 is the max value). The format we're using f= or bbuf is > > > > "[%lld..%lld]:" which has 2 signed long longs plus 6 other charac= ters > > > > "[..]:\0", which means it's possible we'll print up to 44 charact= ers, > > > > overflowing our 32 char buffer. > > > >=20 > > > > Fix this by bumping all the buffer sizes in dump_map_verbose() to= 64 > > > > characters. > > > >=20 > > > > Signed-off-by: Ross Zwisler > > > > Cc: Darrick J. Wong > > > > Fixes: 3fcab549a234 ("xfs_io: support the new getfsmap ioctl") > > >=20 > > > FYI, I posted a fix for this weeks ago. I think Eric has already > > > picked it up, but it hasn't been pushed out into the for-next branc= h > > > yet. > >=20 > > I'm seeing similar new compiler warnings when compiling xfstests: > >=20 > > write_log.c: In function =E2=80=98wlog_open=E2=80=99: > > write_log.c:124:37: warning: =E2=80=98%s=E2=80=99 directive writing u= p to 1023 bytes into a region of size 224 [-Wformat-overflow=3D] > > "Could not open write_log - open(%s, %#o, %#o) failed: %s\n", > > ^~ > > write_log.c:124:4: note: directive argument in the range [1089, 2047] > > "Could not open write_log - open(%s, %#o, %#o) failed: %s\n", > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >=20 > > etc. > >=20 > > I don't see any patches posted that fix these, as of yet. As far as = you know, > > am I correct in thinking that these still need to be fixed? >=20 > It sure looks that way. Cool, thanks. I'll take a crack at them.