From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbdLGJSv (ORCPT ); Thu, 7 Dec 2017 04:18:51 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:51466 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbdLGJSs (ORCPT ); Thu, 7 Dec 2017 04:18:48 -0500 Date: Thu, 7 Dec 2017 10:18:47 +0100 From: Maxime Ripard To: Takuo Koguchi Cc: linux-kernel@vger.kernel.org, khoroshilov@ispras.ru, takuo.koguchi.sw@hitachi.com, Mark Brown , Chen-Yu Tsai , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3] spi: sun4i: disable clocks in the remove function Message-ID: <20171207091847.rf76dol6iqcfeomr@flea.lan> References: <20171206152005.yfbyylu6tbe5gnnv@flea.lan> <1512631227-27334-1-git-send-email-takuo.koguchi.sw@hitachi.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ndm6iijuv74uzg3v" Content-Disposition: inline In-Reply-To: <1512631227-27334-1-git-send-email-takuo.koguchi.sw@hitachi.com> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ndm6iijuv74uzg3v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Dec 07, 2017 at 04:20:14PM +0900, Takuo Koguchi wrote: > mclk and hclk need to be disabled. Since pm_runtime_disable does > not disable the clocks, use pm_runtime_force_suspend instead. >=20 > Found by Linux Driver Verification project (linuxtesting.org). >=20 > Signed-off-by: Takuo Koguchi Acked-by: Maxime Ripard Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --ndm6iijuv74uzg3v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlopB3MACgkQ0rTAlCFN r3SFuA//eCEZdN9jbaMftCBmzcFq8MFBDRAAIojv1OVchrVfPtJiPC2TSJS+TCgv tioughQ6X96UkFJr7hQjO6KGK8NxaH6cHbUPQ+TwK4iN1Y0p/oibBx6xIl/b7sW2 Sl/e8g6XWN4jGNz9JgfFyCgGQhI8efQUQKn0qxUWixs/OCjymDxMfLzgN45wCRNj yDH3ueM/qtuVz72dt0VOgJ0dgrf1u+s8uKRESQnQ4xBn3g6hcR7oRApAmF68102C bOdlXXeDiQZ9n8TPRayrgy9N1wDc4l6kawWzu63hbIyNw/j8BEhFUMW+HiyveTOn zDlr3BAtpxSHdkwRXpV5PqxOypTbwu7bI1k1w0RJ8Vm6Fliewk4+UyoXPoNQOIw9 8NXs1YgimXvnWQ9IKpsfWt935Sx2iUe12uSXIbkKFXfklPOcJTCm5cmfcytnTOaV 3IkHQnxekZVdguJ7c9LyJak8c28pq2BbTi3YRIe/ZiYh2vyfQsWrudvydNk5BFnH SDgdRg+uUmBOc8aLbJYZgkhePmHG3GqypQm329HgZZD0bFqg/NbZKtRP2ifvdjfm QWM9Fz171dD/gSMPkj3PcZ1ZeEa3A3yvSjTyIGdCkLX97wcqlqYM8h5VgjFAdjzT 0mxLavG4mFWSqtQ+YTfuFRLMjaIW9b54oFtF95iBnIUNMRLN/pA= =Ilyd -----END PGP SIGNATURE----- --ndm6iijuv74uzg3v-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH V3] spi: sun4i: disable clocks in the remove function Date: Thu, 7 Dec 2017 10:18:47 +0100 Message-ID: <20171207091847.rf76dol6iqcfeomr@flea.lan> References: <20171206152005.yfbyylu6tbe5gnnv@flea.lan> <1512631227-27334-1-git-send-email-takuo.koguchi.sw@hitachi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ndm6iijuv74uzg3v" Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, khoroshilov-ufN2psIa012HXe+LvDLADg@public.gmane.org, takuo.koguchi.sw-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org, Mark Brown , Chen-Yu Tsai , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Takuo Koguchi Return-path: Content-Disposition: inline In-Reply-To: <1512631227-27334-1-git-send-email-takuo.koguchi.sw-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: --ndm6iijuv74uzg3v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Dec 07, 2017 at 04:20:14PM +0900, Takuo Koguchi wrote: > mclk and hclk need to be disabled. Since pm_runtime_disable does > not disable the clocks, use pm_runtime_force_suspend instead. >=20 > Found by Linux Driver Verification project (linuxtesting.org). >=20 > Signed-off-by: Takuo Koguchi Acked-by: Maxime Ripard Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --ndm6iijuv74uzg3v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlopB3MACgkQ0rTAlCFN r3SFuA//eCEZdN9jbaMftCBmzcFq8MFBDRAAIojv1OVchrVfPtJiPC2TSJS+TCgv tioughQ6X96UkFJr7hQjO6KGK8NxaH6cHbUPQ+TwK4iN1Y0p/oibBx6xIl/b7sW2 Sl/e8g6XWN4jGNz9JgfFyCgGQhI8efQUQKn0qxUWixs/OCjymDxMfLzgN45wCRNj yDH3ueM/qtuVz72dt0VOgJ0dgrf1u+s8uKRESQnQ4xBn3g6hcR7oRApAmF68102C bOdlXXeDiQZ9n8TPRayrgy9N1wDc4l6kawWzu63hbIyNw/j8BEhFUMW+HiyveTOn zDlr3BAtpxSHdkwRXpV5PqxOypTbwu7bI1k1w0RJ8Vm6Fliewk4+UyoXPoNQOIw9 8NXs1YgimXvnWQ9IKpsfWt935Sx2iUe12uSXIbkKFXfklPOcJTCm5cmfcytnTOaV 3IkHQnxekZVdguJ7c9LyJak8c28pq2BbTi3YRIe/ZiYh2vyfQsWrudvydNk5BFnH SDgdRg+uUmBOc8aLbJYZgkhePmHG3GqypQm329HgZZD0bFqg/NbZKtRP2ifvdjfm QWM9Fz171dD/gSMPkj3PcZ1ZeEa3A3yvSjTyIGdCkLX97wcqlqYM8h5VgjFAdjzT 0mxLavG4mFWSqtQ+YTfuFRLMjaIW9b54oFtF95iBnIUNMRLN/pA= =Ilyd -----END PGP SIGNATURE----- --ndm6iijuv74uzg3v-- -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Thu, 7 Dec 2017 10:18:47 +0100 Subject: [PATCH V3] spi: sun4i: disable clocks in the remove function In-Reply-To: <1512631227-27334-1-git-send-email-takuo.koguchi.sw@hitachi.com> References: <20171206152005.yfbyylu6tbe5gnnv@flea.lan> <1512631227-27334-1-git-send-email-takuo.koguchi.sw@hitachi.com> Message-ID: <20171207091847.rf76dol6iqcfeomr@flea.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thu, Dec 07, 2017 at 04:20:14PM +0900, Takuo Koguchi wrote: > mclk and hclk need to be disabled. Since pm_runtime_disable does > not disable the clocks, use pm_runtime_force_suspend instead. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Takuo Koguchi Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: