From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dr. David Alan Gilbert" Subject: Re: [PATCH v5 23/23] sev: add migration blocker Date: Thu, 7 Dec 2017 11:03:43 +0000 Message-ID: <20171207110342.GB2439@work-vm> References: <20171206200346.116537-1-brijesh.singh@amd.com> <20171206200346.116537-24-brijesh.singh@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, Alistair Francis , Christian Borntraeger , Cornelia Huck , "Daniel P . Berrange" , "Edgar E . Iglesias " , Eduardo Habkost , Eric Blake , kvm@vger.kernel.org, Marcel Apfelbaum , Markus Armbruster , "Michael S. Tsirkin" , Paolo Bonzini , Peter Crosthwaite , Peter Maydell , Richard Henderson , Richard Henderson , Stefan Hajnoczi , Thomas Lendacky , To: Brijesh Singh Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36518 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752860AbdLGLD6 (ORCPT ); Thu, 7 Dec 2017 06:03:58 -0500 Content-Disposition: inline In-Reply-To: <20171206200346.116537-24-brijesh.singh@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: * Brijesh Singh (brijesh.singh@amd.com) wrote: > SEV guest migration is not yet implemented yet. > > Signed-off-by: Brijesh Singh > --- > accel/kvm/sev.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/accel/kvm/sev.c b/accel/kvm/sev.c > index 3edfb5b08416..10647645eacd 100644 > --- a/accel/kvm/sev.c > +++ b/accel/kvm/sev.c > @@ -19,6 +19,7 @@ > #include "sysemu/sev.h" > #include "sysemu/sysemu.h" > #include "qapi-event.h" > +#include "migration/blocker.h" > > #define DEFAULT_GUEST_POLICY 0x1 /* disable debug */ > #define DEFAULT_SEV_DEVICE "/dev/sev" > @@ -36,6 +37,7 @@ > static int sev_fd; > static SEVState *sev_state; > static MemoryRegionRAMReadWriteOps sev_ops; > +static Error *sev_mig_blocker; > > #define SEV_FW_MAX_ERROR 0x17 > > @@ -460,6 +462,7 @@ static void > sev_launch_finish(SEVState *s) > { > int ret, error; > + Error *local_err = NULL; > > ret = sev_ioctl(KVM_SEV_LAUNCH_FINISH, 0, &error); > if (ret) { > @@ -470,6 +473,16 @@ sev_launch_finish(SEVState *s) > > s->cur_state = SEV_STATE_RUNNING; > DPRINTF("SEV: LAUNCH_FINISH\n"); (from a previous patch) Please use the tracing facility rather than new DPRINTF's if possible - if you've not used it before, then --enable-trace-backends=log is the easy way to get going and you can turn on and off the stuff you're interested in tracing at run time without having to rebuild. > + > + /* add migration blocker */ > + error_setg(&sev_mig_blocker, > + "SEV: Migration is not implemented"); > + ret = migrate_add_blocker(sev_mig_blocker, &local_err); > + if (local_err) { > + error_report_err(local_err); > + error_free(sev_mig_blocker); > + exit(1); > + } Yep, reasonable: Reviewed-by: Dr. David Alan Gilbert > } > > static void > -- > 2.9.5 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMtyJ-0003AS-7w for qemu-devel@nongnu.org; Thu, 07 Dec 2017 06:04:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMtyB-00061G-73 for qemu-devel@nongnu.org; Thu, 07 Dec 2017 06:04:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42744) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMtyB-00060Y-0B for qemu-devel@nongnu.org; Thu, 07 Dec 2017 06:03:59 -0500 Date: Thu, 7 Dec 2017 11:03:43 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20171207110342.GB2439@work-vm> References: <20171206200346.116537-1-brijesh.singh@amd.com> <20171206200346.116537-24-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171206200346.116537-24-brijesh.singh@amd.com> Subject: Re: [Qemu-devel] [PATCH v5 23/23] sev: add migration blocker List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brijesh Singh Cc: qemu-devel@nongnu.org, Alistair Francis , Christian Borntraeger , Cornelia Huck , "Daniel P . Berrange" , "Edgar E . Iglesias " , Eduardo Habkost , Eric Blake , kvm@vger.kernel.org, Marcel Apfelbaum , Markus Armbruster , "Michael S. Tsirkin" , Paolo Bonzini , Peter Crosthwaite , Peter Maydell , Richard Henderson , Richard Henderson , Stefan Hajnoczi , Thomas Lendacky , Borislav Petkov * Brijesh Singh (brijesh.singh@amd.com) wrote: > SEV guest migration is not yet implemented yet. > > Signed-off-by: Brijesh Singh > --- > accel/kvm/sev.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/accel/kvm/sev.c b/accel/kvm/sev.c > index 3edfb5b08416..10647645eacd 100644 > --- a/accel/kvm/sev.c > +++ b/accel/kvm/sev.c > @@ -19,6 +19,7 @@ > #include "sysemu/sev.h" > #include "sysemu/sysemu.h" > #include "qapi-event.h" > +#include "migration/blocker.h" > > #define DEFAULT_GUEST_POLICY 0x1 /* disable debug */ > #define DEFAULT_SEV_DEVICE "/dev/sev" > @@ -36,6 +37,7 @@ > static int sev_fd; > static SEVState *sev_state; > static MemoryRegionRAMReadWriteOps sev_ops; > +static Error *sev_mig_blocker; > > #define SEV_FW_MAX_ERROR 0x17 > > @@ -460,6 +462,7 @@ static void > sev_launch_finish(SEVState *s) > { > int ret, error; > + Error *local_err = NULL; > > ret = sev_ioctl(KVM_SEV_LAUNCH_FINISH, 0, &error); > if (ret) { > @@ -470,6 +473,16 @@ sev_launch_finish(SEVState *s) > > s->cur_state = SEV_STATE_RUNNING; > DPRINTF("SEV: LAUNCH_FINISH\n"); (from a previous patch) Please use the tracing facility rather than new DPRINTF's if possible - if you've not used it before, then --enable-trace-backends=log is the easy way to get going and you can turn on and off the stuff you're interested in tracing at run time without having to rebuild. > + > + /* add migration blocker */ > + error_setg(&sev_mig_blocker, > + "SEV: Migration is not implemented"); > + ret = migrate_add_blocker(sev_mig_blocker, &local_err); > + if (local_err) { > + error_report_err(local_err); > + error_free(sev_mig_blocker); > + exit(1); > + } Yep, reasonable: Reviewed-by: Dr. David Alan Gilbert > } > > static void > -- > 2.9.5 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK