From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v3 1/2] virtio_mmio: add cleanup for virtio_mmio_probe Date: Thu, 7 Dec 2017 12:08:58 +0100 Message-ID: <20171207120858.5a6b67bf.cohuck@redhat.com> References: <9fc4a1dd52c99edfccdf4c710445ed9a43aad66a.1512568542.git.zhangweiping@didichuxing.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9fc4a1dd52c99edfccdf4c710445ed9a43aad66a.1512568542.git.zhangweiping@didichuxing.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: weiping zhang Cc: virtualization@lists.linux-foundation.org, mst@redhat.com List-Id: virtualization@lists.linuxfoundation.org On Wed, 6 Dec 2017 21:59:16 +0800 weiping zhang wrote: > As mentioned at drivers/base/core.c: > /* > * NOTE: _Never_ directly free @dev after calling this function, even > * if it returned an error! Always use put_device() to give up the > * reference initialized in this function instead. > */ > so we don't free vm_dev until vm_dev.dev.release be called. > > Signed-off-by: weiping zhang > --- > drivers/virtio/virtio_mmio.c | 51 +++++++++++++++++++++++++++++++++++--------- > 1 file changed, 41 insertions(+), 10 deletions(-) Reviewed-by: Cornelia Huck