From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback Date: Thu, 7 Dec 2017 14:10:29 +0100 Message-ID: <20171207141029.575c0a03@karo-electronics.de> References: <1512493493-6464-1-git-send-email-okaya@codeaurora.org> <1512493493-6464-5-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1512493493-6464-5-git-send-email-okaya@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sinan Kaya Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, timur@codeaurora.org, open list , linux-acpi@vger.kernel.org, Rob Herring , dmaengine@vger.kernel.org, Frank Rowand , linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org SGksCgpPbiBUdWUsICA1IERlYyAyMDE3IDEyOjA0OjQ5IC0wNTAwIFNpbmFuIEtheWEgd3JvdGU6 Cj4gTm93IHRoYXQgd2UgaGF2ZSBhIGdldF9tYXRjaF9kYXRhKCkgY2FsbGJhY2sgYXMgcGFydCBv ZiB0aGUgZmlybXdhcmUgbm9kZSwKPiBpbXBsZW1lbnQgdGhlIE9GIHNwZWNpZmljIHBpZWNlIGZv ciBpdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTaW5hbiBLYXlhIDxva2F5YUBjb2RlYXVyb3JhLm9y Zz4KPiAtLS0KPiAgZHJpdmVycy9vZi9wcm9wZXJ0eS5jIHwgNyArKysrKysrCj4gIDEgZmlsZSBj aGFuZ2VkLCA3IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9vZi9wcm9w ZXJ0eS5jIGIvZHJpdmVycy9vZi9wcm9wZXJ0eS5jCj4gaW5kZXggMjY0YzM1NS4uOTk2NDE2OSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL29mL3Byb3BlcnR5LmMKPiArKysgYi9kcml2ZXJzL29mL3By b3BlcnR5LmMKPiBAQCAtOTgxLDYgKzk4MSwxMiBAQCBzdGF0aWMgaW50IG9mX2Z3bm9kZV9ncmFw aF9wYXJzZV9lbmRwb2ludChjb25zdCBzdHJ1Y3QgZndub2RlX2hhbmRsZSAqZndub2RlLAo+ICAJ cmV0dXJuIDA7Cj4gIH0KPiAgCj4gK3ZvaWQgKm9mX2Z3bm9kZV9nZXRfbWF0Y2hfZGF0YShjb25z dCBzdHJ1Y3QgZndub2RlX2hhbmRsZSAqZndub2RlLAo+ICsJCQkgICAgICAgc3RydWN0IGRldmlj ZSAqZGV2KQpTaG91bGRuJ3QgdGhpcyBiZSAnY29uc3Qgdm9pZCAqb2ZfZndub2RlX2dldF9tYXRj aF9kYXRhJwoKCgpMb3RoYXIgV2HDn21hbm4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932093AbdLGNyM convert rfc822-to-8bit (ORCPT ); Thu, 7 Dec 2017 08:54:12 -0500 Received: from smtprelay03.ispgateway.de ([80.67.31.37]:10577 "EHLO smtprelay03.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754613AbdLGNyH (ORCPT ); Thu, 7 Dec 2017 08:54:07 -0500 X-Greylist: delayed 2613 seconds by postgrey-1.27 at vger.kernel.org; Thu, 07 Dec 2017 08:54:06 EST Date: Thu, 7 Dec 2017 14:10:29 +0100 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Sinan Kaya Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-msm@vger.kernel.org, open list , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback Message-ID: <20171207141029.575c0a03@karo-electronics.de> In-Reply-To: <1512493493-6464-5-git-send-email-okaya@codeaurora.org> References: <1512493493-6464-1-git-send-email-okaya@codeaurora.org> <1512493493-6464-5-git-send-email-okaya@codeaurora.org> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Df-Sender: bHdAa2Fyby1lbGVjdHJvbmljcy5kZQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, 5 Dec 2017 12:04:49 -0500 Sinan Kaya wrote: > Now that we have a get_match_data() callback as part of the firmware node, > implement the OF specific piece for it. > > Signed-off-by: Sinan Kaya > --- > drivers/of/property.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index 264c355..9964169 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -981,6 +981,12 @@ static int of_fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode, > return 0; > } > > +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, > + struct device *dev) Shouldn't this be 'const void *of_fwnode_get_match_data' Lothar Waßmann From mboxrd@z Thu Jan 1 00:00:00 1970 From: LW@KARO-electronics.de (Lothar =?UTF-8?B?V2HDn21hbm4=?=) Date: Thu, 7 Dec 2017 14:10:29 +0100 Subject: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback In-Reply-To: <1512493493-6464-5-git-send-email-okaya@codeaurora.org> References: <1512493493-6464-1-git-send-email-okaya@codeaurora.org> <1512493493-6464-5-git-send-email-okaya@codeaurora.org> Message-ID: <20171207141029.575c0a03@karo-electronics.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Tue, 5 Dec 2017 12:04:49 -0500 Sinan Kaya wrote: > Now that we have a get_match_data() callback as part of the firmware node, > implement the OF specific piece for it. > > Signed-off-by: Sinan Kaya > --- > drivers/of/property.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index 264c355..9964169 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -981,6 +981,12 @@ static int of_fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode, > return 0; > } > > +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, > + struct device *dev) Shouldn't this be 'const void *of_fwnode_get_match_data' Lothar Wa?mann