From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753531AbdLGOTd (ORCPT ); Thu, 7 Dec 2017 09:19:33 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:52128 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298AbdLGOTc (ORCPT ); Thu, 7 Dec 2017 09:19:32 -0500 Date: Thu, 7 Dec 2017 14:19:27 +0000 From: Patrick Bellasi To: Viresh Kumar Cc: Juri Lelli , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Peter Zijlstra , "Rafael J . Wysocki" , Vincent Guittot , Dietmar Eggemann , Morten Rasmussen , Todd Kjos , Joel Fernandes Subject: Re: [PATCH v3 3/6] cpufreq: schedutil: update CFS util only if used Message-ID: <20171207141927.GR31247@e110439-lin> References: <20171130114723.29210-1-patrick.bellasi@arm.com> <20171130114723.29210-4-patrick.bellasi@arm.com> <20171130132234.GC9903@localhost.localdomain> <20171130155728.GF31247@e110439-lin> <20171207051540.larfamrdflctn5pn@vireshk-mac-ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207051540.larfamrdflctn5pn@vireshk-mac-ubuntu> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07-Dec 10:45, Viresh Kumar wrote: > On 30-11-17, 15:57, Patrick Bellasi wrote: > > Yes, that's a pretty trivial update with a confusing changelog. > > > > If we think it's worth to keep (and correct as well) I'll update the > > commit message. > > We also need to update the commit log based on feedback from Vikram on > V2. Which said that the utilization can't change around the lock here > as we are within rq lock section, though max can change (maybe). So > this patch only takes care of locking before reading max. Ok, right... will do. Thus you are still of the opinion to keep this patch in the series? -- #include Patrick Bellasi