All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Paul Clarke <pc@us.ibm.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	bhargavb <bhargavaramudu@gmail.com>,
	linux-kernel@vger.kernel.org,
	Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
	linux-rt-users@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 2/5] perf-probe: Cut off the version suffix from event name
Date: Thu, 7 Dec 2017 14:55:29 -0300	[thread overview]
Message-ID: <20171207175529.GI3173@kernel.org> (raw)
In-Reply-To: <8f1f552c-c5d0-40e3-14d9-96a4a38b33c6@us.ibm.com>

Em Thu, Dec 07, 2017 at 11:24:47AM -0600, Paul Clarke escreveu:
> On 12/07/2017 10:56 AM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Dec 07, 2017 at 04:20:28PM +0900, Masami Hiramatsu escreveu:
> > See also Paul Clarke's question and suggestion, which I agree, i.e.
> > instead of chopping off the version, just replace the chars with valid
> > ones or better, do what Paul suggests, be more flexible in interpreting
> > @, i.e. if it is a number and/or fails to point to any file, interpret
> > it as versioning.
 
> It's a nit, and subjective, but I'd favor checking for versioning
> first, then file.  The namespaces are very unlikely to intersect, but
> I could foresee symbols like "sym@implA.c" and "sym@implB.c" more
> likely than a symbol in a file "GLIBC_2.2.5".
 
> Perhaps straying toward bikeshedding...

Nah, those are valid concerns, and I share them.

- Arnaldo

  reply	other threads:[~2017-12-07 17:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07  7:19 [PATCH v2 0/5] perf-probe: Improve probing on versioned symbols Masami Hiramatsu
2017-12-07  7:19 ` [PATCH v2 1/5] perf-probe: Add warning message if there is unexpected event name Masami Hiramatsu
2017-12-07 15:53   ` Arnaldo Carvalho de Melo
2017-12-08  2:48     ` Masami Hiramatsu
2017-12-07  7:20 ` [PATCH v2 2/5] perf-probe: Cut off the version suffix from " Masami Hiramatsu
2017-12-07 16:34   ` Paul Clarke
2017-12-08  3:01     ` Masami Hiramatsu
2017-12-08 14:49       ` Paul Clarke
2017-12-08 16:12         ` Masami Hiramatsu
2017-12-11 18:25         ` Arnaldo Carvalho de Melo
2017-12-12 15:02           ` Masami Hiramatsu
2017-12-07 16:56   ` Arnaldo Carvalho de Melo
2017-12-07 17:24     ` Paul Clarke
2017-12-07 17:55       ` Arnaldo Carvalho de Melo [this message]
2017-12-08  3:15     ` Masami Hiramatsu
2017-12-07  7:20 ` [PATCH v2 3/5] perf-probe: Add __return suffix for return events Masami Hiramatsu
2017-12-07  7:21 ` [PATCH v2 4/5] perf-probe: Find versioned symbols from map Masami Hiramatsu
2017-12-08 11:08   ` Thomas-Mich Richter
2017-12-08 14:22     ` Masami Hiramatsu
2017-12-07  7:21 ` [PATCH v2 5/5] perf-probe: Support escaped character in parser Masami Hiramatsu
2017-12-08 11:45   ` Thomas-Mich Richter
2017-12-08 15:54     ` Masami Hiramatsu
2017-12-07 12:47 ` [PATCH v2 0/5] perf-probe: Improve probing on versioned symbols Ravi Bangoria
2017-12-08 16:24   ` Masami Hiramatsu
2017-12-08 17:13     ` Ravi Bangoria
2017-12-08 11:56 ` Thomas-Mich Richter
2017-12-08 16:12   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171207175529.GI3173@kernel.org \
    --to=acme@kernel.org \
    --cc=bhargavaramudu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=pc@us.ibm.com \
    --cc=ravi.bangoria@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.