From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: Guneshwor Singh <guneshwor.o.singh@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>, Vinod Koul <vinod.koul@intel.com>,
ALSA <alsa-devel@alsa-project.org>,
Patches Audio <patches.audio@intel.com>
Subject: Re: [PATCH] ALSA: hda - Add vendor id for Cannonlake HDMI codec
Date: Fri, 8 Dec 2017 09:06:34 +0530 [thread overview]
Message-ID: <20171208033629.GA31207@subhransu-desktop> (raw)
In-Reply-To: <20171207123620.25640-1-guneshwor.o.singh@intel.com>
On Thu, Dec 07, 2017 at 06:06:20PM +0530, Guneshwor Singh wrote:
> Cannonlake HDMI codec has the same nid as Geminilake. This adds the
> codec entry for it.
CNL and GLK share the same vendor nid not the vendor id.
You may update the subject and commit message.
Regards,
Subhransu
>
> Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>
> ---
> sound/pci/hda/patch_hdmi.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index c19c81d230bd..b4f1b6e88305 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -55,10 +55,11 @@ MODULE_PARM_DESC(static_hdmi_pcm, "Don't restrict PCM parameters per ELD info");
> #define is_kabylake(codec) ((codec)->core.vendor_id == 0x8086280b)
> #define is_geminilake(codec) (((codec)->core.vendor_id == 0x8086280d) || \
> ((codec)->core.vendor_id == 0x80862800))
> +#define is_cannonlake(codec) ((codec)->core.vendor_id == 0x8086280c)
> #define is_haswell_plus(codec) (is_haswell(codec) || is_broadwell(codec) \
> || is_skylake(codec) || is_broxton(codec) \
> - || is_kabylake(codec)) || is_geminilake(codec)
> -
> + || is_kabylake(codec)) || is_geminilake(codec) \
> + || is_cannonlake(codec)
> #define is_valleyview(codec) ((codec)->core.vendor_id == 0x80862882)
> #define is_cherryview(codec) ((codec)->core.vendor_id == 0x80862883)
> #define is_valleyview_plus(codec) (is_valleyview(codec) || is_cherryview(codec))
> @@ -3841,6 +3842,7 @@ HDA_CODEC_ENTRY(0x80862808, "Broadwell HDMI", patch_i915_hsw_hdmi),
> HDA_CODEC_ENTRY(0x80862809, "Skylake HDMI", patch_i915_hsw_hdmi),
> HDA_CODEC_ENTRY(0x8086280a, "Broxton HDMI", patch_i915_hsw_hdmi),
> HDA_CODEC_ENTRY(0x8086280b, "Kabylake HDMI", patch_i915_hsw_hdmi),
> +HDA_CODEC_ENTRY(0x8086280c, "Cannonlake HDMI", patch_i915_glk_hdmi),
> HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI", patch_i915_glk_hdmi),
> HDA_CODEC_ENTRY(0x80862800, "Geminilake HDMI", patch_i915_glk_hdmi),
> HDA_CODEC_ENTRY(0x80862880, "CedarTrail HDMI", patch_generic_hdmi),
> --
> 2.15.1
>
--
next prev parent reply other threads:[~2017-12-08 3:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 12:36 [PATCH] ALSA: hda - Add vendor id for Cannonlake HDMI codec Guneshwor Singh
2017-12-07 12:45 ` Takashi Iwai
2017-12-08 3:36 ` Subhransu S. Prusty [this message]
2017-12-08 4:01 ` Singh, Guneshwor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208033629.GA31207@subhransu-desktop \
--to=subhransu.s.prusty@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=guneshwor.o.singh@intel.com \
--cc=patches.audio@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.