Hi Matthew, I love your patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v4.15-rc2 next-20171207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox/mm-Add-unmap_mapping_pages/20171208-072634 base: git://git.cmpxchg.org/linux-mmotm.git master config: i386-randconfig-a0-201749 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): In file included from include/linux/memcontrol.h:29:0, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/mm.h: In function 'unmap_shared_mapping_range': >> include/linux/mm.h:1328:2: error: implicit declaration of function 'unmap_mapping_range' [-Werror=implicit-function-declaration] unmap_mapping_range(mapping, holebegin, holelen, 0); ^ include/linux/mm.h: At top level: include/linux/mm.h:1347:6: warning: conflicting types for 'unmap_mapping_range' void unmap_mapping_range(struct address_space *mapping, ^ include/linux/mm.h:1328:2: note: previous implicit declaration of 'unmap_mapping_range' was here unmap_mapping_range(mapping, holebegin, holelen, 0); ^ cc1: some warnings being treated as errors make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [sub-make] Error 2 vim +/unmap_mapping_range +1328 include/linux/mm.h e6473092b Matt Mackall 2008-02-04 1307 2165009bd Dave Hansen 2008-06-12 1308 int walk_page_range(unsigned long addr, unsigned long end, 2165009bd Dave Hansen 2008-06-12 1309 struct mm_walk *walk); 900fc5f19 Naoya Horiguchi 2015-02-11 1310 int walk_page_vma(struct vm_area_struct *vma, struct mm_walk *walk); 42b777281 Jan Beulich 2008-07-23 1311 void free_pgd_range(struct mmu_gather *tlb, unsigned long addr, 3bf5ee956 Hugh Dickins 2005-04-19 1312 unsigned long end, unsigned long floor, unsigned long ceiling); ^1da177e4 Linus Torvalds 2005-04-16 1313 int copy_page_range(struct mm_struct *dst, struct mm_struct *src, ^1da177e4 Linus Torvalds 2005-04-16 1314 struct vm_area_struct *vma); 097963959 Ross Zwisler 2017-01-10 1315 int follow_pte_pmd(struct mm_struct *mm, unsigned long address, a4d1a8852 J�r�me Glisse 2017-08-31 1316 unsigned long *start, unsigned long *end, 097963959 Ross Zwisler 2017-01-10 1317 pte_t **ptepp, pmd_t **pmdpp, spinlock_t **ptlp); 3b6748e2d Johannes Weiner 2009-06-16 1318 int follow_pfn(struct vm_area_struct *vma, unsigned long address, 3b6748e2d Johannes Weiner 2009-06-16 1319 unsigned long *pfn); d87fe6607 venkatesh.pallipadi@intel.com 2008-12-19 1320 int follow_phys(struct vm_area_struct *vma, unsigned long address, d87fe6607 venkatesh.pallipadi@intel.com 2008-12-19 1321 unsigned int flags, unsigned long *prot, resource_size_t *phys); 28b2ee20c Rik van Riel 2008-07-23 1322 int generic_access_phys(struct vm_area_struct *vma, unsigned long addr, 28b2ee20c Rik van Riel 2008-07-23 1323 void *buf, int len, int write); ^1da177e4 Linus Torvalds 2005-04-16 1324 ^1da177e4 Linus Torvalds 2005-04-16 1325 static inline void unmap_shared_mapping_range(struct address_space *mapping, ^1da177e4 Linus Torvalds 2005-04-16 1326 loff_t const holebegin, loff_t const holelen) ^1da177e4 Linus Torvalds 2005-04-16 1327 { ^1da177e4 Linus Torvalds 2005-04-16 @1328 unmap_mapping_range(mapping, holebegin, holelen, 0); ^1da177e4 Linus Torvalds 2005-04-16 1329 } ^1da177e4 Linus Torvalds 2005-04-16 1330 :::::: The code at line 1328 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds :::::: CC: Linus Torvalds --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation