From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752500AbdLHI57 (ORCPT ); Fri, 8 Dec 2017 03:57:59 -0500 Received: from mx2.suse.de ([195.135.220.15]:39357 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142AbdLHI55 (ORCPT ); Fri, 8 Dec 2017 03:57:57 -0500 Date: Fri, 8 Dec 2017 09:57:55 +0100 From: Petr Mladek To: Sergey Senozhatsky Cc: Peter Zijlstra , Martin Schwidefsky , Steven Rostedt , LKML , linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCH] sched/autogroup: move sched.h include Message-ID: <20171208085755.GA3148@linux.suse> References: <20171208025616.16267-2-sergey.senozhatsky@gmail.com> <20171208082422.5021-1-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208082422.5021-1-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2017-12-08 17:24:22, Sergey Senozhatsky wrote: > Move local "sched.h" include to the bottom. sched.h defines > several macros that are getting redefined in ARCH-specific > code, for instance, finish_arch_post_lock_switch() and > prepare_arch_switch(), so we need ARCH-specific definitions > to come in first. This patch is needed to fix compilation error [1] caused by a patchset that deprecates %pf/%pF printk modifiers[2]. IMHO, we should make sure that this fix goes into Linus' tree before the printk-related patchset. What is the best practice, please? I see two reasonable possibilities. Either sched people could push this for-4.15-rcX. Or I could put it into printk.git for-4.16 in the right order. What do you think? Referece: [0] http://lkml.kernel.org/r/201712080259.tvO64XfA%fengguang.wu@intel.com [1] https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/commit/?h=for-next&id=98fff2c57b7e88d643cb42ffd910fe9905b33176 Best Regards, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f199.google.com (mail-pf0-f199.google.com [209.85.192.199]) by kanga.kvack.org (Postfix) with ESMTP id 30CFD6B0253 for ; Fri, 8 Dec 2017 03:58:02 -0500 (EST) Received: by mail-pf0-f199.google.com with SMTP id y62so8260074pfd.3 for ; Fri, 08 Dec 2017 00:58:02 -0800 (PST) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id p7si5208925pgs.362.2017.12.08.00.57.59 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 08 Dec 2017 00:58:00 -0800 (PST) Date: Fri, 8 Dec 2017 09:57:55 +0100 From: Petr Mladek Subject: Re: [PATCH] sched/autogroup: move sched.h include Message-ID: <20171208085755.GA3148@linux.suse> References: <20171208025616.16267-2-sergey.senozhatsky@gmail.com> <20171208082422.5021-1-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208082422.5021-1-sergey.senozhatsky@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Sergey Senozhatsky Cc: Peter Zijlstra , Martin Schwidefsky , Steven Rostedt , LKML , linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky On Fri 2017-12-08 17:24:22, Sergey Senozhatsky wrote: > Move local "sched.h" include to the bottom. sched.h defines > several macros that are getting redefined in ARCH-specific > code, for instance, finish_arch_post_lock_switch() and > prepare_arch_switch(), so we need ARCH-specific definitions > to come in first. This patch is needed to fix compilation error [1] caused by a patchset that deprecates %pf/%pF printk modifiers[2]. IMHO, we should make sure that this fix goes into Linus' tree before the printk-related patchset. What is the best practice, please? I see two reasonable possibilities. Either sched people could push this for-4.15-rcX. Or I could put it into printk.git for-4.16 in the right order. What do you think? Referece: [0] http://lkml.kernel.org/r/201712080259.tvO64XfA%fengguang.wu@intel.com [1] https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/commit/?h=for-next&id=98fff2c57b7e88d643cb42ffd910fe9905b33176 Best Regards, Petr -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org