* [Qemu-devel] [PATCH v2] qemu-img: Document --force-share / -U
@ 2017-12-08 1:44 Fam Zheng
2017-12-08 9:54 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-12-11 9:05 ` [Qemu-devel] " Kashyap Chamarthy
0 siblings, 2 replies; 5+ messages in thread
From: Fam Zheng @ 2017-12-08 1:44 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, Kevin Wolf, Max Reitz, qemu-block, kchamart
Signed-off-by: Fam Zheng <famz@redhat.com>
---
v2: - "code{qemu-img}". [Kashyap, Eric]
- "etc.." -> "etc.".
---
qemu-img.texi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/qemu-img.texi b/qemu-img.texi
index fdcf120f36..6b9f9adfc8 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -57,6 +57,15 @@ exclusive with the @var{-O} parameters. It is currently required to also use
the @var{-n} parameter to skip image creation. This restriction may be relaxed
in a future release.
+@item --force-share (-U)
+
+If specified, @code{qemu-img} will open the image with shared permissions,
+which makes it less likely to conflict with a running guest's permissions due
+to image locking. For example, this can be used to get the image information
+(with 'info' subcommand) when the image is used by a running guest. Note that
+this could produce inconsistent result because of concurrent metadata changes,
+etc.
+
@item fmt
is the disk image format. It is guessed automatically in most cases. See below
for a description of the supported disk formats.
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH v2] qemu-img: Document --force-share / -U
2017-12-08 1:44 [Qemu-devel] [PATCH v2] qemu-img: Document --force-share / -U Fam Zheng
@ 2017-12-08 9:54 ` Stefan Hajnoczi
2017-12-08 11:47 ` Kevin Wolf
2017-12-11 9:30 ` Fam Zheng
2017-12-11 9:05 ` [Qemu-devel] " Kashyap Chamarthy
1 sibling, 2 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2017-12-08 9:54 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, Kevin Wolf, kchamart, qemu-block, Max Reitz
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote:
> +@item --force-share (-U)
> +
> +If specified, @code{qemu-img} will open the image with shared permissions,
> +which makes it less likely to conflict with a running guest's permissions due
> +to image locking. For example, this can be used to get the image information
> +(with 'info' subcommand) when the image is used by a running guest. Note that
> +this could produce inconsistent result because of concurrent metadata changes,
> +etc.
The documentation isn't clear on whether read-write is supported or just
read-only.
Also, should it be declared a legacy option right away to discourage
use in new software?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH v2] qemu-img: Document --force-share / -U
2017-12-08 9:54 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
@ 2017-12-08 11:47 ` Kevin Wolf
2017-12-11 9:30 ` Fam Zheng
1 sibling, 0 replies; 5+ messages in thread
From: Kevin Wolf @ 2017-12-08 11:47 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Fam Zheng, qemu-devel, kchamart, qemu-block, Max Reitz
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
Am 08.12.2017 um 10:54 hat Stefan Hajnoczi geschrieben:
> On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote:
> > +@item --force-share (-U)
> > +
> > +If specified, @code{qemu-img} will open the image with shared permissions,
> > +which makes it less likely to conflict with a running guest's permissions due
> > +to image locking. For example, this can be used to get the image information
> > +(with 'info' subcommand) when the image is used by a running guest. Note that
> > +this could produce inconsistent result because of concurrent metadata changes,
> > +etc.
>
> The documentation isn't clear on whether read-write is supported or just
> read-only.
>
> Also, should it be declared a legacy option right away to discourage
> use in new software?
I don't think this is a legacy option. As long you know what you're
doing, using it is fine.
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] qemu-img: Document --force-share / -U
2017-12-08 1:44 [Qemu-devel] [PATCH v2] qemu-img: Document --force-share / -U Fam Zheng
2017-12-08 9:54 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
@ 2017-12-11 9:05 ` Kashyap Chamarthy
1 sibling, 0 replies; 5+ messages in thread
From: Kashyap Chamarthy @ 2017-12-11 9:05 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, eblake, Kevin Wolf, Max Reitz, qemu-block
On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
> v2: - "code{qemu-img}". [Kashyap, Eric]
> - "etc.." -> "etc.".
> ---
> qemu-img.texi | 9 +++++++++
> 1 file changed, 9 insertions(+)
Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com>
[...]
--
/kashyap
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH v2] qemu-img: Document --force-share / -U
2017-12-08 9:54 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-12-08 11:47 ` Kevin Wolf
@ 2017-12-11 9:30 ` Fam Zheng
1 sibling, 0 replies; 5+ messages in thread
From: Fam Zheng @ 2017-12-11 9:30 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Kevin Wolf, Max Reitz, qemu-devel, qemu-block, kchamart
On Fri, 12/08 09:54, Stefan Hajnoczi wrote:
> On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote:
> > +@item --force-share (-U)
> > +
> > +If specified, @code{qemu-img} will open the image with shared permissions,
> > +which makes it less likely to conflict with a running guest's permissions due
> > +to image locking. For example, this can be used to get the image information
> > +(with 'info' subcommand) when the image is used by a running guest. Note that
> > +this could produce inconsistent result because of concurrent metadata changes,
> > +etc.
>
> The documentation isn't clear on whether read-write is supported or just
> read-only.
block.c will emit an error if used with read-write. I will add a sentence for
that.
Fam
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-11 9:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-08 1:44 [Qemu-devel] [PATCH v2] qemu-img: Document --force-share / -U Fam Zheng
2017-12-08 9:54 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-12-08 11:47 ` Kevin Wolf
2017-12-11 9:30 ` Fam Zheng
2017-12-11 9:05 ` [Qemu-devel] " Kashyap Chamarthy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.