All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Mark Kanda <mark.kanda@oracle.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
	martin.petersen@oracle.com, konrad.wilk@oracle.com,
	ameya.more@oracle.com, stefanha@redhat.com,
	karl.heubaum@oracle.com
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-blk: make queue size configurable
Date: Fri, 8 Dec 2017 10:13:25 +0000	[thread overview]
Message-ID: <20171208101325.GD23880@stefanha-x1.localdomain> (raw)
In-Reply-To: <e7b259772e3e075ae4b08778a27139b9db8d3bf9.1512589016.git.mark.kanda@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

On Wed, Dec 06, 2017 at 01:54:00PM -0600, Mark Kanda wrote:
> Depending on the configuration, it can be beneficial to adjust the virtio-blk
> queue size to something other than the current default of 128. Add a new
> property to make the queue size configurable.
> 
> Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
> Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Reviewed-by: Ameya More <ameya.more@oracle.com>
> ---
>  hw/block/virtio-blk.c          | 7 ++++++-
>  include/hw/virtio/virtio-blk.h | 1 +
>  2 files changed, 7 insertions(+), 1 deletion(-)

Please see commit 9b02e1618cf26aa52cf786f215d757506dda14f8 ("virtio-net:
enable configurable tx queue size") for additional considerations.
QEMU's virtio implementation hardcodes the maximum queue size at 1024
and this limit must be checked.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2017-12-08 10:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 19:53 [Qemu-devel] [PATCH 0/2] virtio-blk: miscellaneous changes Mark Kanda
2017-12-06 19:54 ` [Qemu-devel] [PATCH 1/2] virtio-blk: make queue size configurable Mark Kanda
2017-12-08 10:13   ` Stefan Hajnoczi [this message]
2017-12-06 19:54 ` [Qemu-devel] [PATCH 2/2] virtio-blk: reject configs with logical block size > physical block size Mark Kanda
2017-12-06 20:41   ` Martin K. Petersen
2017-12-08 10:13   ` Stefan Hajnoczi
2017-12-08 15:57 ` [Qemu-devel] [PATCH v2 0/2] virtio-blk: miscellaneous changes Mark Kanda
2017-12-08 15:57   ` [Qemu-devel] [PATCH v2 1/2] virtio-blk: make queue size configurable Mark Kanda
2017-12-08 15:57   ` [Qemu-devel] [PATCH v2 2/2] virtio-blk: reject configs with logical block size > physical block size Mark Kanda
2017-12-11 10:30   ` [Qemu-devel] [PATCH v2 0/2] virtio-blk: miscellaneous changes Stefan Hajnoczi
2017-12-11 15:15     ` Mark Kanda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208101325.GD23880@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=ameya.more@oracle.com \
    --cc=karl.heubaum@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=mark.kanda@oracle.com \
    --cc=martin.petersen@oracle.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.