From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: "Liu, Changcheng" <changcheng.liu@intel.com>
Cc: sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell
Date: Fri, 8 Dec 2017 19:33:15 +0900 [thread overview]
Message-ID: <20171208103315.GF628@jagdpanzerIV> (raw)
In-Reply-To: <20171208093751.GA175471@sofia>
On (12/08/17 17:37), Liu, Changcheng wrote:
>
> On some linux distributions, the default link of sh
> is dash which deoesn't support split array like
> ${var//,/ }
> It's better to force to use bash shell directly.
>
> Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
> diff --git a/tools/vm/slabinfo-gnuplot.sh b/tools/vm/slabinfo-gnuplot.sh
> index 35b0398..0cf28aa 100644
> --- a/tools/vm/slabinfo-gnuplot.sh
> +++ b/tools/vm/slabinfo-gnuplot.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
>
> # Sergey Senozhatsky, 2015
> # sergey.senozhatsky.work@gmail.com
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-12-08 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 9:37 Liu, Changcheng
2017-12-08 10:33 ` Sergey Senozhatsky [this message]
2017-12-08 22:02 ` Andrew Morton
2017-12-08 22:20 ` Joe Perches
2017-12-08 23:59 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208103315.GF628@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=changcheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--subject='Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.