From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753371AbdLHKjj (ORCPT ); Fri, 8 Dec 2017 05:39:39 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:44034 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107AbdLHKjg (ORCPT ); Fri, 8 Dec 2017 05:39:36 -0500 X-Google-Smtp-Source: AGs4zMYYiVi7DrlcNG/0NYocNyD2PiiATMt9Q24wlXJOM5E9EomvJXjQjscsEA+Y/dWrZcZxaeON9g== Date: Fri, 8 Dec 2017 19:39:31 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Peter Zijlstra , Martin Schwidefsky , Steven Rostedt , LKML , linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCH] sched/autogroup: move sched.h include Message-ID: <20171208103931.GG628@jagdpanzerIV> References: <20171208025616.16267-2-sergey.senozhatsky@gmail.com> <20171208082422.5021-1-sergey.senozhatsky@gmail.com> <20171208085755.GA3148@linux.suse> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208085755.GA3148@linux.suse> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On (12/08/17 09:57), Petr Mladek wrote: > On Fri 2017-12-08 17:24:22, Sergey Senozhatsky wrote: > > Move local "sched.h" include to the bottom. sched.h defines > > several macros that are getting redefined in ARCH-specific > > code, for instance, finish_arch_post_lock_switch() and > > prepare_arch_switch(), so we need ARCH-specific definitions > > to come in first. > > This patch is needed to fix compilation error [1] caused by a patchset > that deprecates %pf/%pF printk modifiers[2]. > > IMHO, we should make sure that this fix goes into Linus' tree > before the printk-related patchset. What is the best practice, > please? as long as sched pull request goes before printk pull request we are fine. but I see your point. > I see two reasonable possibilities. Either sched people could > push this for-4.15-rcX. Or I could put it into printk.git for-4.16 > in the right order. agreed. > What do you think? either way is fine with me. we can have it in print.git (no objections from my side) or in sched tree and just make sure that sched pull request has "bigger priority", or it can go to Linus's tree as a potential fix (I'd prefer the last option, I think). -ss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f197.google.com (mail-pf0-f197.google.com [209.85.192.197]) by kanga.kvack.org (Postfix) with ESMTP id C21F86B0069 for ; Fri, 8 Dec 2017 05:39:37 -0500 (EST) Received: by mail-pf0-f197.google.com with SMTP id h18so8510392pfi.2 for ; Fri, 08 Dec 2017 02:39:37 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 7sor2928456pll.5.2017.12.08.02.39.36 for (Google Transport Security); Fri, 08 Dec 2017 02:39:36 -0800 (PST) Date: Fri, 8 Dec 2017 19:39:31 +0900 From: Sergey Senozhatsky Subject: Re: [PATCH] sched/autogroup: move sched.h include Message-ID: <20171208103931.GG628@jagdpanzerIV> References: <20171208025616.16267-2-sergey.senozhatsky@gmail.com> <20171208082422.5021-1-sergey.senozhatsky@gmail.com> <20171208085755.GA3148@linux.suse> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208085755.GA3148@linux.suse> Sender: owner-linux-mm@kvack.org List-ID: To: Petr Mladek Cc: Sergey Senozhatsky , Peter Zijlstra , Martin Schwidefsky , Steven Rostedt , LKML , linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Hi, On (12/08/17 09:57), Petr Mladek wrote: > On Fri 2017-12-08 17:24:22, Sergey Senozhatsky wrote: > > Move local "sched.h" include to the bottom. sched.h defines > > several macros that are getting redefined in ARCH-specific > > code, for instance, finish_arch_post_lock_switch() and > > prepare_arch_switch(), so we need ARCH-specific definitions > > to come in first. > > This patch is needed to fix compilation error [1] caused by a patchset > that deprecates %pf/%pF printk modifiers[2]. > > IMHO, we should make sure that this fix goes into Linus' tree > before the printk-related patchset. What is the best practice, > please? as long as sched pull request goes before printk pull request we are fine. but I see your point. > I see two reasonable possibilities. Either sched people could > push this for-4.15-rcX. Or I could put it into printk.git for-4.16 > in the right order. agreed. > What do you think? either way is fine with me. we can have it in print.git (no objections from my side) or in sched tree and just make sure that sched pull request has "bigger priority", or it can go to Linus's tree as a potential fix (I'd prefer the last option, I think). -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org