From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753567AbdLHK4r (ORCPT ); Fri, 8 Dec 2017 05:56:47 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:51971 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753196AbdLHK4p (ORCPT ); Fri, 8 Dec 2017 05:56:45 -0500 Date: Fri, 8 Dec 2017 11:56:40 +0100 From: Peter Zijlstra To: Sergey Senozhatsky Cc: Martin Schwidefsky , Steven Rostedt , Petr Mladek , LKML , linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCH] sched/autogroup: move sched.h include Message-ID: <20171208105640.2ovmvxpds6psdnnq@hirez.programming.kicks-ass.net> References: <20171208025616.16267-2-sergey.senozhatsky@gmail.com> <20171208082422.5021-1-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208082422.5021-1-sergey.senozhatsky@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2017 at 05:24:22PM +0900, Sergey Senozhatsky wrote: > Move local "sched.h" include to the bottom. sched.h defines > several macros that are getting redefined in ARCH-specific > code, for instance, finish_arch_post_lock_switch() and > prepare_arch_switch(), so we need ARCH-specific definitions > to come in first. > > Suggested-by: Martin Schwidefsky > Signed-off-by: Sergey Senozhatsky Acked-by: Peter Zijlstra (Intel) > --- > kernel/sched/autogroup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/autogroup.c b/kernel/sched/autogroup.c > index 0786227a3f48..bb4b9fe026a1 100644 > --- a/kernel/sched/autogroup.c > +++ b/kernel/sched/autogroup.c > @@ -1,12 +1,12 @@ > // SPDX-License-Identifier: GPL-2.0 > -#include "sched.h" > - > #include > #include > #include > #include > #include > > +#include "sched.h" > + > unsigned int __read_mostly sysctl_sched_autogroup_enabled = 1; > static struct autogroup autogroup_default; > static atomic_t autogroup_seq_nr; > -- > 2.15.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH] sched/autogroup: move sched.h include Date: Fri, 8 Dec 2017 11:56:40 +0100 Message-ID: <20171208105640.2ovmvxpds6psdnnq@hirez.programming.kicks-ass.net> References: <20171208025616.16267-2-sergey.senozhatsky@gmail.com> <20171208082422.5021-1-sergey.senozhatsky@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171208082422.5021-1-sergey.senozhatsky@gmail.com> Sender: owner-linux-mm@kvack.org To: Sergey Senozhatsky Cc: Martin Schwidefsky , Steven Rostedt , Petr Mladek , LKML , linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky List-Id: linux-pm@vger.kernel.org On Fri, Dec 08, 2017 at 05:24:22PM +0900, Sergey Senozhatsky wrote: > Move local "sched.h" include to the bottom. sched.h defines > several macros that are getting redefined in ARCH-specific > code, for instance, finish_arch_post_lock_switch() and > prepare_arch_switch(), so we need ARCH-specific definitions > to come in first. > > Suggested-by: Martin Schwidefsky > Signed-off-by: Sergey Senozhatsky Acked-by: Peter Zijlstra (Intel) > --- > kernel/sched/autogroup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/autogroup.c b/kernel/sched/autogroup.c > index 0786227a3f48..bb4b9fe026a1 100644 > --- a/kernel/sched/autogroup.c > +++ b/kernel/sched/autogroup.c > @@ -1,12 +1,12 @@ > // SPDX-License-Identifier: GPL-2.0 > -#include "sched.h" > - > #include > #include > #include > #include > #include > > +#include "sched.h" > + > unsigned int __read_mostly sysctl_sched_autogroup_enabled = 1; > static struct autogroup autogroup_default; > static atomic_t autogroup_seq_nr; > -- > 2.15.1 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org