Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

From: Roman Gushchin <guro@fb.com>
To: Philippe Ombredanne <pombredanne@nexb.com>
Cc: <netdev@vger.kernel.org>,
	Quentin Monnet <quentin.monnet@netronome.com>,
	LKML <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>,
	<ast@kernel.org>, <daniel@iogearbox.net>,
	<jakub.kicinski@netronome.com>, <kafai@fb.com>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations
Date: Fri, 8 Dec 2017 14:53:50 +0000	[thread overview]
Message-ID: <20171208145345.GA12685@castle> (raw)
In-Reply-To: <CAOFm3uEFF=7DuxsT-+45q2ZENDfhitUg18V53qtOo9fj7JHOvA@mail.gmail.com>

On Fri, Dec 08, 2017 at 02:56:15PM +0100, Philippe Ombredanne wrote:
> On Fri, Dec 8, 2017 at 11:34 AM, Quentin Monnet
> <quentin.monnet@netronome.com> wrote:
> > 2017-12-07 18:39 UTC+0000 ~ Roman Gushchin <guro@fb.com>
> >> This patch adds basic cgroup bpf operations to bpftool:
> >> cgroup list, attach and detach commands.
> 
> [...]
> >> --- /dev/null
> >> +++ b/tools/bpf/bpftool/cgroup.c
> >> @@ -0,0 +1,305 @@
> >> +/*
> >> + * Copyright (C) 2017 Facebook
> >> + *
> >> + * This program is free software; you can redistribute it and/or
> >> + * modify it under the terms of the GNU General Public License
> >> + * as published by the Free Software Foundation; either version
> >> + * 2 of the License, or (at your option) any later version.
> >> + *
> >> + *
> >> + */
> >> +
> 
> Roman,
> Have you considered using the simpler and new SPDX ids instead? e.g.:
> 
> // SPDX-License-Identifier: GPL-2.0+
> // Copyright (C) 2017 Facebook
> // Author: Roman Gushchin <guro@fb.com>
> 
> This would boost your code/comments ratio nicely IMHO.

Thanks, applied to v3!