All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH igt] igt/core_suspend: Exercise igt_system_suspend_autoresume()
@ 2017-12-08 19:39 Chris Wilson
  2017-12-08 20:48 ` ✓ Fi.CI.BAT: success for igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2) Patchwork
  2017-12-08 23:30 ` ✓ Fi.CI.IGT: " Patchwork
  0 siblings, 2 replies; 9+ messages in thread
From: Chris Wilson @ 2017-12-08 19:39 UTC (permalink / raw)
  To: intel-gfx

We have various basic suspend and debug modes, so iterate over them to
check they each work without test interference. This should help work out
the cause of any suspend bugs by isolating those that are independent of
the drivers.

v2: Smelling fixes.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/Makefile.sources |  1 +
 tests/core_suspend.c   | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 tests/core_suspend.c

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index d6d176596..36077a132 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -28,6 +28,7 @@ TESTS_progs = \
 	core_getversion \
 	core_prop_blob \
 	core_setmaster_vs_auth \
+	core_suspend \
 	debugfs_test \
 	drm_import_export \
 	drm_mm \
diff --git a/tests/core_suspend.c b/tests/core_suspend.c
new file mode 100644
index 000000000..2f5a3b7ff
--- /dev/null
+++ b/tests/core_suspend.c
@@ -0,0 +1,62 @@
+/*
+ * Copyright © 2017 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */
+
+#include "igt.h"
+#include "igt_kmod.h"
+
+igt_main
+{
+	const struct mode {
+		const char *name;
+		unsigned int mode;
+	} suspend[] = {
+		{ "freeze", SUSPEND_STATE_FREEZE },
+		{ "standby", SUSPEND_STATE_STANDBY },
+		{ "mem", SUSPEND_STATE_MEM },
+		{ "disk", SUSPEND_STATE_DISK },
+		{}
+	}, debug[] = {
+		{ "freezer", SUSPEND_TEST_FREEZER },
+		{ "devices", SUSPEND_TEST_DEVICES },
+		{ "platform", SUSPEND_TEST_PLATFORM },
+		{ "processors", SUSPEND_TEST_PROCESSORS },
+		{ "core", SUSPEND_TEST_CORE },
+		{ "full", SUSPEND_TEST_NONE },
+		{}
+	};
+
+	igt_skip_on_simulation();
+
+	/* unload all drivers? */
+	igt_fixture {
+		igt_i915_driver_unload();
+	}
+
+	for (const struct mode *s = suspend; s->name; s++) {
+		for (const struct mode *d = debug; d->name; d++) {
+			igt_subtest_f("suspend-%s-%s", s->name, d->name)
+				igt_system_suspend_autoresume(s->mode, d->mode);
+		}
+	}
+}
-- 
2.15.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* ✓ Fi.CI.BAT: success for igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2)
  2017-12-08 19:39 [PATCH igt] igt/core_suspend: Exercise igt_system_suspend_autoresume() Chris Wilson
@ 2017-12-08 20:48 ` Patchwork
  2017-12-08 23:30 ` ✓ Fi.CI.IGT: " Patchwork
  1 sibling, 0 replies; 9+ messages in thread
From: Patchwork @ 2017-12-08 20:48 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2)
URL   : https://patchwork.freedesktop.org/series/31986/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
37339e7171ee0bd6b45abf8cfef593ed9d8bf750 lib: Print other clients when DRM_SET_MASTER fails

with latest DRM-Tip kernel build CI_DRM_3486
3e49efc6d2d7 drm-tip: 2017y-12m-08d-18h-21m-46s UTC integration manifest

Testlist changes:
+igt@core_suspend@suspend-disk-core
+igt@core_suspend@suspend-disk-devices
+igt@core_suspend@suspend-disk-freezer
+igt@core_suspend@suspend-disk-full
+igt@core_suspend@suspend-disk-platform
+igt@core_suspend@suspend-disk-processors
+igt@core_suspend@suspend-freeze-core
+igt@core_suspend@suspend-freeze-devices
+igt@core_suspend@suspend-freeze-freezer
+igt@core_suspend@suspend-freeze-full
+igt@core_suspend@suspend-freeze-platform
+igt@core_suspend@suspend-freeze-processors
+igt@core_suspend@suspend-mem-core
+igt@core_suspend@suspend-mem-devices
+igt@core_suspend@suspend-mem-freezer
+igt@core_suspend@suspend-mem-full
+igt@core_suspend@suspend-mem-platform
+igt@core_suspend@suspend-mem-processors
+igt@core_suspend@suspend-standby-core
+igt@core_suspend@suspend-standby-devices
+igt@core_suspend@suspend-standby-freezer
+igt@core_suspend@suspend-standby-full
+igt@core_suspend@suspend-standby-platform
+igt@core_suspend@suspend-standby-processors

Test debugfs_test:
        Subgroup read_all_entries:
                dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989
Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:439s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:449s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:389s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:524s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:282s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:504s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:510s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:492s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:480s
fi-elk-e7500     total:224  pass:163  dwarn:14  dfail:1   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:271s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:545s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:373s
fi-hsw-4770r     total:288  pass:224  dwarn:0   dfail:0   fail:0   skip:64  time:263s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:398s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:483s
fi-ivb-3770      total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:451s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:493s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:526s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:475s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:534s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:595s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:452s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:544s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:568s
fi-skl-6700k     total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:525s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:509s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:450s
fi-snb-2520m     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:553s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:424s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:613s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:650s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:491s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_634/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* ✓ Fi.CI.IGT: success for igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2)
  2017-12-08 19:39 [PATCH igt] igt/core_suspend: Exercise igt_system_suspend_autoresume() Chris Wilson
  2017-12-08 20:48 ` ✓ Fi.CI.BAT: success for igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2) Patchwork
@ 2017-12-08 23:30 ` Patchwork
  2017-12-15 12:06   ` Arkadiusz Hiler
  1 sibling, 1 reply; 9+ messages in thread
From: Patchwork @ 2017-12-08 23:30 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2)
URL   : https://patchwork.freedesktop.org/series/31986/
State : success

== Summary ==

Test gem_eio:
        Subgroup in-flight-contexts:
                dmesg-warn -> PASS       (shard-snb) fdo#104058
Test gem_softpin:
        Subgroup noreloc-s3:
                pass       -> SKIP       (shard-snb) fdo#102365
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-c:
                incomplete -> PASS       (shard-hsw) fdo#103375
Test kms_flip:
        Subgroup dpms-vs-vblank-race:
                fail       -> PASS       (shard-hsw) fdo#103060
        Subgroup rcs-wf_vblank-vs-dpms:
                dmesg-warn -> PASS       (shard-hsw) fdo#102614
Test gem_tiled_swapping:
        Subgroup non-threaded:
                incomplete -> PASS       (shard-hsw) fdo#104009
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
                fail       -> PASS       (shard-snb) fdo#101623 +1
Test pm_rc6_residency:
        Subgroup rc6-accuracy:
                skip       -> PASS       (shard-snb)
Test gem_userptr_blits:
        Subgroup map-fixed-invalidate-gup:
                dmesg-warn -> PASS       (shard-hsw)
Test gem_mmap_wc:
        Subgroup set-cache-level:
                skip       -> PASS       (shard-hsw)

fdo#104058 https://bugs.freedesktop.org/show_bug.cgi?id=104058
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#104009 https://bugs.freedesktop.org/show_bug.cgi?id=104009
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623

shard-hsw        total:2636 pass:1511 dwarn:1   dfail:0   fail:11  skip:1111 time:8706s
shard-snb        total:2560 pass:1260 dwarn:1   dfail:0   fail:12  skip:1285 time:7178s
Blacklisted hosts:
shard-apl        total:2614 pass:1630 dwarn:1   dfail:0   fail:22  skip:958 time:12472s
shard-kbl        total:2636 pass:1756 dwarn:1   dfail:0   fail:25  skip:852 time:9857s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_634/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: ✓ Fi.CI.IGT: success for igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2)
  2017-12-08 23:30 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-12-15 12:06   ` Arkadiusz Hiler
  2017-12-15 12:15     ` Chris Wilson
  0 siblings, 1 reply; 9+ messages in thread
From: Arkadiusz Hiler @ 2017-12-15 12:06 UTC (permalink / raw)
  To: intel-gfx

On Fri, Dec 08, 2017 at 11:30:07PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2)
> URL   : https://patchwork.freedesktop.org/series/31986/
> State : success
> 
> == Summary ==

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_634/shards-all.html#igt@core_suspend@suspend-disk-core

igt@core_suspend@suspend-disk-full
fails on all platforms

igt@core_suspend@suspend-freeze-core
igt@core_suspend@suspend-freeze-processors
give us a system hand
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: ✓ Fi.CI.IGT: success for igt/core_suspend: Exercise  igt_system_suspend_autoresume() (rev2)
  2017-12-15 12:06   ` Arkadiusz Hiler
@ 2017-12-15 12:15     ` Chris Wilson
  0 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2017-12-15 12:15 UTC (permalink / raw)
  To: Arkadiusz Hiler, intel-gfx

Quoting Arkadiusz Hiler (2017-12-15 12:06:01)
> On Fri, Dec 08, 2017 at 11:30:07PM +0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2)
> > URL   : https://patchwork.freedesktop.org/series/31986/
> > State : success
> > 
> > == Summary ==
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_634/shards-all.html#igt@core_suspend@suspend-disk-core
> 
> igt@core_suspend@suspend-disk-full
> fails on all platforms
> 
> igt@core_suspend@suspend-freeze-core
> igt@core_suspend@suspend-freeze-processors
> give us a system hand

Somebody thought returning EAGAIN for an invalid parameter was a good
idea.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH igt] igt/core_suspend: Exercise igt_system_suspend_autoresume()
  2017-10-15 14:01 [PATCH igt] igt/core_suspend: Exercise igt_system_suspend_autoresume() Chris Wilson
  2017-10-16  7:47 ` Michał Winiarski
@ 2017-10-16 10:14 ` Petri Latvala
  1 sibling, 0 replies; 9+ messages in thread
From: Petri Latvala @ 2017-10-16 10:14 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

On Sun, Oct 15, 2017 at 03:01:28PM +0100, Chris Wilson wrote:
> We have various basic suspend and debug modes, so iterate over them to
> check they each work without test interference. This help work out the
> cause of any suspend bugs.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/Makefile.sources |  1 +
>  tests/core_suspend.c   | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 61 insertions(+)
>  create mode 100644 tests/core_suspend.c
> 
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 9c461353..c2f51a59 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -26,6 +26,7 @@ TESTS_progs = \
>  	core_getversion \
>  	core_prop_blob \
>  	core_setmaster_vs_auth \
> +	core_suspend \
>  	debugfs_test \
>  	drm_import_export \
>  	drm_mm \
> diff --git a/tests/core_suspend.c b/tests/core_suspend.c
> new file mode 100644
> index 00000000..eee2e1ab
> --- /dev/null
> +++ b/tests/core_suspend.c
> @@ -0,0 +1,60 @@
> +/*
> + * Copyright © 2017 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + */
> +
> +#include "igt.h"
> +
> +igt_main
> +{
> +	const struct mode {
> +		const char *name;
> +		unsigned int mode;
> +	} suspend[] = {
> +		{ "freze", SUSPEND_STATE_FREEZE },

"freeze"

> +		{ "standy", SUSPEND_STATE_STANDBY },

"standby"



-- 
Petri Latvala


> +		{ "mem", SUSPEND_STATE_MEM },
> +		{ "disk", SUSPEND_STATE_DISK },
> +		{}
> +	}, debug[] = {
> +		{ "freezer", SUSPEND_TEST_FREEZER },
> +		{ "devices", SUSPEND_TEST_DEVICES },
> +		{ "platform", SUSPEND_TEST_PLATFORM },
> +		{ "processors", SUSPEND_TEST_PROCESSORS },
> +		{ "core", SUSPEND_TEST_CORE },
> +		{ "full", SUSPEND_TEST_NONE },
> +		{}
> +	};
> +
> +	igt_skip_on_simulation();
> +
> +	/* unload all drivers? */
> +
> +	for (const struct mode *s = suspend; s->name; s++) {
> +		for (const struct mode *d = debug; d->name; d++) {
> +			igt_subtest_f("suspend-%s-%s", s->name, d->name)
> +				igt_system_suspend_autoresume(s->mode, d->mode);
> +		}
> +	}
> +
> +	/* again with drivers loaded? */
> +}
> -- 
> 2.15.0.rc0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH igt] igt/core_suspend: Exercise igt_system_suspend_autoresume()
  2017-10-16  7:47 ` Michał Winiarski
@ 2017-10-16  7:58   ` Chris Wilson
  0 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2017-10-16  7:58 UTC (permalink / raw)
  To: Michał Winiarski; +Cc: intel-gfx

Quoting Michał Winiarski (2017-10-16 08:47:08)
> On Sun, Oct 15, 2017 at 02:01:28PM +0000, Chris Wilson wrote:
> > We have various basic suspend and debug modes, so iterate over them to
> > check they each work without test interference. This help work out the
> > cause of any suspend bugs.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >  tests/Makefile.sources |  1 +
> >  tests/core_suspend.c   | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 61 insertions(+)
> >  create mode 100644 tests/core_suspend.c
> 
> Missing changes in meson.build

You mean it's not pulling in from the common list of source files?

Do not care.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH igt] igt/core_suspend: Exercise igt_system_suspend_autoresume()
  2017-10-15 14:01 [PATCH igt] igt/core_suspend: Exercise igt_system_suspend_autoresume() Chris Wilson
@ 2017-10-16  7:47 ` Michał Winiarski
  2017-10-16  7:58   ` Chris Wilson
  2017-10-16 10:14 ` Petri Latvala
  1 sibling, 1 reply; 9+ messages in thread
From: Michał Winiarski @ 2017-10-16  7:47 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

On Sun, Oct 15, 2017 at 02:01:28PM +0000, Chris Wilson wrote:
> We have various basic suspend and debug modes, so iterate over them to
> check they each work without test interference. This help work out the
> cause of any suspend bugs.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/Makefile.sources |  1 +
>  tests/core_suspend.c   | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 61 insertions(+)
>  create mode 100644 tests/core_suspend.c

Missing changes in meson.build

With that:
Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>

-Michał
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH igt] igt/core_suspend: Exercise igt_system_suspend_autoresume()
@ 2017-10-15 14:01 Chris Wilson
  2017-10-16  7:47 ` Michał Winiarski
  2017-10-16 10:14 ` Petri Latvala
  0 siblings, 2 replies; 9+ messages in thread
From: Chris Wilson @ 2017-10-15 14:01 UTC (permalink / raw)
  To: intel-gfx

We have various basic suspend and debug modes, so iterate over them to
check they each work without test interference. This help work out the
cause of any suspend bugs.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/Makefile.sources |  1 +
 tests/core_suspend.c   | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 61 insertions(+)
 create mode 100644 tests/core_suspend.c

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 9c461353..c2f51a59 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -26,6 +26,7 @@ TESTS_progs = \
 	core_getversion \
 	core_prop_blob \
 	core_setmaster_vs_auth \
+	core_suspend \
 	debugfs_test \
 	drm_import_export \
 	drm_mm \
diff --git a/tests/core_suspend.c b/tests/core_suspend.c
new file mode 100644
index 00000000..eee2e1ab
--- /dev/null
+++ b/tests/core_suspend.c
@@ -0,0 +1,60 @@
+/*
+ * Copyright © 2017 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */
+
+#include "igt.h"
+
+igt_main
+{
+	const struct mode {
+		const char *name;
+		unsigned int mode;
+	} suspend[] = {
+		{ "freze", SUSPEND_STATE_FREEZE },
+		{ "standy", SUSPEND_STATE_STANDBY },
+		{ "mem", SUSPEND_STATE_MEM },
+		{ "disk", SUSPEND_STATE_DISK },
+		{}
+	}, debug[] = {
+		{ "freezer", SUSPEND_TEST_FREEZER },
+		{ "devices", SUSPEND_TEST_DEVICES },
+		{ "platform", SUSPEND_TEST_PLATFORM },
+		{ "processors", SUSPEND_TEST_PROCESSORS },
+		{ "core", SUSPEND_TEST_CORE },
+		{ "full", SUSPEND_TEST_NONE },
+		{}
+	};
+
+	igt_skip_on_simulation();
+
+	/* unload all drivers? */
+
+	for (const struct mode *s = suspend; s->name; s++) {
+		for (const struct mode *d = debug; d->name; d++) {
+			igt_subtest_f("suspend-%s-%s", s->name, d->name)
+				igt_system_suspend_autoresume(s->mode, d->mode);
+		}
+	}
+
+	/* again with drivers loaded? */
+}
-- 
2.15.0.rc0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-12-15 12:15 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-08 19:39 [PATCH igt] igt/core_suspend: Exercise igt_system_suspend_autoresume() Chris Wilson
2017-12-08 20:48 ` ✓ Fi.CI.BAT: success for igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2) Patchwork
2017-12-08 23:30 ` ✓ Fi.CI.IGT: " Patchwork
2017-12-15 12:06   ` Arkadiusz Hiler
2017-12-15 12:15     ` Chris Wilson
  -- strict thread matches above, loose matches on Subject: below --
2017-10-15 14:01 [PATCH igt] igt/core_suspend: Exercise igt_system_suspend_autoresume() Chris Wilson
2017-10-16  7:47 ` Michał Winiarski
2017-10-16  7:58   ` Chris Wilson
2017-10-16 10:14 ` Petri Latvala

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.