From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 3/8] app/eventdev: add pktmbuf pool for ethdev
Date: Sun, 10 Dec 2017 17:31:21 +0530
Message-ID: <20171210120120.GD11770@jerin>
References: <1508330348-30060-1-git-send-email-pbhagavatula@caviumnetworks.com>
 <1508330348-30060-4-git-send-email-pbhagavatula@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: bruce.richardson@intel.com, harry.van.haaren@intel.com,
 gage.eads@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
 nikhil.rao@intel.com, santosh.shukla@caviumnetworks.com, dev@dpdk.org
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0062.outbound.protection.outlook.com [104.47.32.62])
 by dpdk.org (Postfix) with ESMTP id 1237D29C8
 for <dev@dpdk.org>; Sun, 10 Dec 2017 13:01:43 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1508330348-30060-4-git-send-email-pbhagavatula@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Wed, 18 Oct 2017 18:09:03 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: bruce.richardson@intel.com, harry.van.haaren@intel.com,
>  gage.eads@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
>  nikhil.rao@intel.com, santosh.shukla@caviumnetworks.com,
>  jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [PATCH 3/8] app/eventdev: add pktmbuf pool for ethdev
> X-Mailer: git-send-email 2.7.4
> 
> Add pktmbuf pool creation used when configuring ethernet device as event
> producer.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  app/test-eventdev/test_perf_common.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
> index f7961be..b26d694 100644
> --- a/app/test-eventdev/test_perf_common.c
> +++ b/app/test-eventdev/test_perf_common.c
> @@ -413,13 +413,24 @@ perf_mempool_setup(struct evt_test *test, struct evt_options *opt)
>  {
>  	struct test_perf *t = evt_test_priv(test);
>  
> -	t->pool = rte_mempool_create(test->name, /* mempool name */
> +	if (opt->prod_type == EVT_PROD_TYPE_SYNT) {
> +		t->pool = rte_mempool_create(test->name, /* mempool name */
>  				opt->pool_sz, /* number of elements*/
>  				sizeof(struct perf_elt), /* element size*/
>  				512, /* cache size*/
>  				0, NULL, NULL,
>  				perf_elt_init, /* obj constructor */
>  				NULL, opt->socket_id, 0); /* flags */
> +	} else {
> +		t->pool = rte_pktmbuf_pool_create(test->name, /* mempool name */
> +				opt->pool_sz, /* number of elements*/
> +				0, /* cache size*/

Please change the cache size to 512.

With above change:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> +				0,
> +				RTE_MBUF_DEFAULT_BUF_SIZE,
> +				opt->socket_id); /* flags */
> +
> +	}
> +
>  	if (t->pool == NULL) {
>  		evt_err("failed to create mempool");
>  		return -ENOMEM;
> -- 
> 2.7.4
>