From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753229AbdLKQ6p (ORCPT <rfc822;w@1wt.eu>);
        Mon, 11 Dec 2017 11:58:45 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:36748 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753038AbdLKQ6k (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Dec 2017 11:58:40 -0500
Date: Mon, 11 Dec 2017 11:58:37 -0500 (EST)
Message-Id: <20171211.115837.1416336431532133035.davem@davemloft.net>
To: mkubecek@suse.cz
Cc: cernekee@chromium.org, johannes.berg@intel.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, daniel@iogearbox.net, dsahern@gmail.com
Subject: Re: [PATCH V2] netlink: Add netns check on taps
From: David Miller <davem@davemloft.net>
In-Reply-To: <20171211161350.s5ki6peee2oxpric@unicorn.suse.cz>
References: <1512591147-29618-1-git-send-email-cernekee@chromium.org>
        <20171206.155714.908446002721815545.davem@davemloft.net>
        <20171211161350.s5ki6peee2oxpric@unicorn.suse.cz>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Dec 2017 08:58:39 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Michal Kubecek <mkubecek@suse.cz>
Date: Mon, 11 Dec 2017 17:13:50 +0100

> On Wed, Dec 06, 2017 at 03:57:14PM -0500, David Miller wrote:
>> From: Kevin Cernekee <cernekee@chromium.org>
>> Date: Wed,  6 Dec 2017 12:12:27 -0800
>> 
>> > Currently, a nlmon link inside a child namespace can observe systemwide
>> > netlink activity.  Filter the traffic so that nlmon can only sniff
>> > netlink messages from its own netns.
>> > 
>> > Test case:
>> > 
>> >     vpnns -- bash -c "ip link add nlmon0 type nlmon; \
>> >                       ip link set nlmon0 up; \
>> >                       tcpdump -i nlmon0 -q -w /tmp/nlmon.pcap -U" &
>> >     sudo ip xfrm state add src 10.1.1.1 dst 10.1.1.2 proto esp \
>> >         spi 0x1 mode transport \
>> >         auth sha1 0x6162633132330000000000000000000000000000 \
>> >         enc aes 0x00000000000000000000000000000000
>> >     grep --binary abc123 /tmp/nlmon.pcap
>> > 
>> > Signed-off-by: Kevin Cernekee <cernekee@chromium.org>
>> 
>> Applied and queued up for -stable, thanks Kevin.
> 
> David,
> 
> this patch is marked as accepted in patchworks and listed in
> 
>   http://patchwork.ozlabs.org/bundle/davem/stable/?state=*
> 
> but it's not in the net tree. Is there a problem with it?

Sorry, it should be there now.

Thanks.