From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm: clean up internally created framebuffer on CRTC disable Date: Mon, 11 Dec 2017 10:13:06 +0100 Message-ID: <20171211091306.stg7oethfq2lyawc@phenom.ffwll.local> References: <20171207030159.3007-1-gurchetansingh@chromium.org> <20171207091648.iyxv7hzznpswgenh@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5429B898C7 for ; Mon, 11 Dec 2017 09:13:10 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id y82so12294239wmg.1 for ; Mon, 11 Dec 2017 01:13:10 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gurchetan Singh Cc: ML dri-devel List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBEZWMgMDgsIDIwMTcgYXQgMDI6MTc6MzlQTSAtMDgwMCwgR3VyY2hldGFuIFNpbmdo IHdyb3RlOgo+IFRoZSBwcm9ibGVtIEknbSB0cnlpbmcgdG8gc29sdmUgaXMgdGhhdCB0aGUgaW50 ZXJuYWwgY3Vyc29yIGZiIGlzIGxlYWt5IGFuZAo+IGV2ZW4gcHJlc2VudCBhZnRlciBjbG9zaW5n IHRoZSBkcm0gZHJpdmVyIGZkLiAgVGhpcyBjYW4gYmUgc2VlbiBieSBydW5uaW5nCj4gbW9kZXRl c3QgYWZ0ZXIgdGhpcyB0ZXN0IGNhc2U6Cj4gCj4gaHR0cHM6Ly9jaHJvbWl1bS5nb29nbGVzb3Vy Y2UuY29tL2Nocm9taXVtb3MvcGxhdGZvcm0vZHJtLXRlc3RzLysvbWFzdGVyL2RybV9jdXJzb3Jf dGVzdC5jCj4gCj4gSG93ZXZlciwgYXMgeW91IG1lbnRpb25lZCwgdGhlIGFwcHJvYWNoIGluIHRo aXMgcGF0Y2ggaXMgbm90IGNvbnNpc3RlbnQKPiB3aXRoIHRoZSB1YXBpLiAgQWRkaW5nIHRoZSBp bnRlcm5hbCBmYiB0byBmaWxlX3ByaXYtPmZicyBpcyBhbm90aGVyCj4gYXBwcm9hY2gsIHRob3Vn aCBJIGhhdmVuJ3QgZ290dGVuIGl0IHRvIHdvcmsgaW4gMTAwJSBvZiBhbGwgY2FzZXMuICBXaGF0 IGRvCj4geW91IHJlY29tbWVuZCAoaWYgYW55dGhpbmcgYXQgYWxsKT8KCkRlZmluaXRlbHkgZG9u J3QgZG8gdGhhdCAtIHVzZXJzcGFjZSBkb2Vzbid0IGtub3cgdG8gY2xlYW4gdGhhdCB1cC4gQW5k CndlJ2QgbmVlZCB0byB0aGVuIHRyYWNrIHRoaXMgZmFrZSBjdXJzb3IgaW50ZXJuYWxseSBpbiB0 aGUga2VybmVsIHNvIHRoYXQKZS5nLiBhIGN1cnNvciBhbmltYXRpb24gZG9lc24ndCByZXN1bHQg aW4gYW4gZW5kbGVzcyBzdHJlYW0gb2YgbGVha2VkIGZicwood2hpY2ggd2lsbCBnZXQgY2xlYW5l ZCB1cCBvbmNlIHlvdSBjbG9zZSB0aGUgZmIsIGJ1dCB0aGVyZSdzIHBlb3BsZSB3aG8KZWFzaWx5 IGRvbid0IHJlc3RhcnQgdGhlaXIgY29tcG9zaXRvciBmb3Igd2Vla3MgLSBubyB3YXkgd2UgY2Fu IGp1c3QgbGVhawpmb3IgdGhhdCBsb25nKS4KClNvIHRoZSB1YXBpIGlzIHRoYXQgdGhlIGN1cnNv ciBzdGF5cyBvbiB3aGVuIHRoZSBmYiBjbG9zZXMuIEhhcyBiZWVuIGxpa2UKdGhhdCBzaW5jZSBm b3JldmVyIChjdXJzb3Igb24gZmJjb24gaXMgZmFtb3VzISksIGFuZCB1bml2ZXJzYWwgY3Vyc29y cwpzaW1wbHkgZW11bGF0ZSB0aGF0LiBJZiB5b3UgZGlzYWJsZSB0aGUgY3Vyc29yLCB5b3VyIGxl YWsgd2lsbCBiZSBnb25lCnRvby4KCkJhY2t3YXJkcyBjb21wYXQgdWFwaSBmb3JldmVyIGhhcyBz b21lIGxvbHMgc29tZXRpbWVzIDotKQoKSW1vIGp1c3QgZml4IG1vZGV0ZXN0IHRvIG5vdCBiZSB0 aGlzIGJyb2tlbi4KLURhbmllbAoKPiAKPiBPbiBUaHUsIERlYyA3LCAyMDE3IGF0IDE6MTYgQU0s IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4gCj4gPiBPbiBXZWQsIERl YyAwNiwgMjAxNyBhdCAwNzowMTo1OVBNIC0wODAwLCBHdXJjaGV0YW4gU2luZ2ggd3JvdGU6Cj4g PiA+IFdoZW4gYSBDUlRDIGlzIGRpc2FibGVkIGFuZCB3ZSB1c2VkIGFuIGludGVybmFsbHkgY3Jl YXRlZCBmcmFtZWJ1ZmZlciwKPiA+ID4gdGhpcyBwYXRjaCBkaXNhYmxlcyB0aGUgY3Vyc29yIHBs YW5lIGFuZCBkcm9wcyB0aGUgcmVmZXJlbmNlIHRoYXQgd2FzCj4gPiA+IGludHJvZHVjZWQgd2hl biB3ZSBjYWxsZWQgZHJtX2ludGVybmFsX2ZyYW1lYnVmZmVyX2NyZWF0ZS4KPiA+ID4KPiA+ID4g U2lnbmVkLW9mZi1ieTogR3VyY2hldGFuIFNpbmdoIDxndXJjaGV0YW5zaW5naEBjaHJvbWl1bS5v cmc+Cj4gPgo+ID4gV2hhdCBraW5kIG9mIGJ1ZyBhcmUgeW91IHRyeWluZyB0byBmaXggaGVyZT8g cGxhbmUgYW5kIGN1cnNvciB1YXBpIGlzIHRoYXQKPiA+IHdoZW4geW91IHJlLWVuYWJsZSB0aGUg Y3J0YywgYWxsIHRoZSBwbGFuZXMgd2lsbCBiZSB0aGVyZSBhZ2Fpbi4gT25seQo+ID4gZXhjZXB0 aW9uIGlzIHRoZSBwcmltYXJ5IHBsYW5lLCBidXQgdGhhdCdzIG9ubHkgYmVjYXVzZSBzZXRfY29u ZmlnIGJvdGgKPiA+IGRpc2FibGVzIHRoZSBjcnRjIF9hbmRfIHRoZSBwcmltYXJ5IHBsYW5lLgo+ ID4KPiA+IFdpdGhvdXQgbW9yZSBkZXRhaWwgb2Ygd2hhdCdzIGdvaW5nIG9uIEkgaGF2ZSBubyBp ZGVhIHdoYXQgZXhhY3RseSB5b3UncmUKPiA+IHRyeWluZyB0byBhY2hpZXZlIGhlcmUuCj4gPiAt RGFuaWVsCj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgfCA3ICsr KysrKysKPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKPiA+ID4KPiA+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJt L2RybV9jcnRjLmMKPiA+ID4gaW5kZXggZjA1NTZlNjU0MTE2Li5kNzMyY2NhNDg3OWYgMTAwNjQ0 Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPiA+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPiA+IEBAIC0xMDEsMTIgKzEwMSwxOSBAQCBFWFBPUlRf U1lNQk9MKGRybV9jcnRjX2Zyb21faW5kZXgpOwo+ID4gPiAgICovCj4gPiA+ICBpbnQgZHJtX2Ny dGNfZm9yY2VfZGlzYWJsZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gPiA+ICB7Cj4gPiA+ICsg ICAgIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+ID4gPiAgICAgICBzdHJ1Y3QgZHJtX21v ZGVfc2V0IHNldCA9IHsKPiA+ID4gICAgICAgICAgICAgICAuY3J0YyA9IGNydGMsCj4gPiA+ICAg ICAgIH07Cj4gPiA+Cj4gPiA+ICAgICAgIFdBUk5fT04oZHJtX2Rydl91c2VzX2F0b21pY19tb2Rl c2V0KGNydGMtPmRldikpOwo+ID4gPgo+ID4gPiArICAgICBpZiAoY3J0Yy0+Y3Vyc29yICYmIGNy dGMtPmN1cnNvci0+ZmIgJiYKPiA+IGNydGMtPmN1cnNvci0+ZmItPmludGVybmFsKSB7Cj4gPiA+ ICsgICAgICAgICAgICAgZmIgPSBjcnRjLT5jdXJzb3ItPmZiOwo+ID4gPiArICAgICAgICAgICAg IGRybV9wbGFuZV9mb3JjZV9kaXNhYmxlKGNydGMtPmN1cnNvcik7Cj4gPiA+ICsgICAgICAgICAg ICAgZHJtX2ZyYW1lYnVmZmVyX3VucmVmZXJlbmNlKGZiKTsKPiA+ID4gKyAgICAgfQo+ID4gPiAr Cj4gPiA+ICAgICAgIHJldHVybiBkcm1fbW9kZV9zZXRfY29uZmlnX2ludGVybmFsKCZzZXQpOwo+ ID4gPiAgfQo+ID4gPiAgRVhQT1JUX1NZTUJPTChkcm1fY3J0Y19mb3JjZV9kaXNhYmxlKTsKPiA+ ID4gLS0KPiA+ID4gMi4xMy41Cj4gPiA+Cj4gPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4gPiA+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiA+ID4g ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+ID4KPiA+IC0tCj4gPiBEYW5p ZWwgVmV0dGVyCj4gPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiA+IGh0 dHA6Ly9ibG9nLmZmd2xsLmNoCj4gPgoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5l ZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=