From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752702AbdLKKVW (ORCPT ); Mon, 11 Dec 2017 05:21:22 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:39121 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307AbdLKKVT (ORCPT ); Mon, 11 Dec 2017 05:21:19 -0500 X-Google-Smtp-Source: AGs4zMYamEja4LXcyYRv57w2MFDv6OX0EYP6m2oBGT5/M/DA5IdjSdGIM0ycOnLWc2xAD3B4kWqmYw== Date: Mon, 11 Dec 2017 11:21:21 +0100 From: Johan Hovold To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable , Peter Ujfalusi , Marek Belisko Subject: Re: [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup Message-ID: <20171211102121.GJ5672@localhost> References: <20171111154339.16875-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171111154339.16875-1-johan@kernel.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 11, 2017 at 04:43:37PM +0100, Johan Hovold wrote: > A helper purported to look up a child node based on its name was using > the wrong of-helper and ended up prematurely freeing the parent of-node > while searching the whole device tree depth-first starting at the parent > node. > > Fixes: 64b9e4d803b1 ("input: twl4030-vibra: Support for DT booted kernel") > Fixes: e661d0a04462 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning") > Cc: stable # 3.7 > Cc: Peter Ujfalusi > Cc: Marek Belisko > Signed-off-by: Johan Hovold > --- Just wanted to send a reminder about this series. I believe these bugs need to be fixes regardless of whether MFD-core eventually provides some means of avoiding such lookups in cell drivers (i.e. the discussion which appears to have stalled). Thanks, Johan