From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbdLKL2V (ORCPT ); Mon, 11 Dec 2017 06:28:21 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:49153 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbdLKL2S (ORCPT ); Mon, 11 Dec 2017 06:28:18 -0500 From: Arnd Bergmann To: Mathias Nyman , Greg Kroah-Hartman Cc: Arnd Bergmann , Lu Baolu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: xhci: fix incorrect memset() Date: Mon, 11 Dec 2017 12:27:45 +0100 Message-Id: <20171211112806.3415781-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:tIYDqZ/STbK5xDcqOP+iQHnWPx4cZNShptHVLxzZrgclE6wJysJ r2q3KVPAA7LdzGCqEE9OuFfeDr6TWRYT6bnxhQbSR8OS2ICpRW2wBSyypAFwTxDkMqHv3E2 D958PT+jP/AjOonmyA5v+uq3vGscO4mWdFYlENvHZQ8Up/fARIgH0niBp8VXSoINZNkY3g5 io1UAPcNoPDgY5+YZuxJA== X-UI-Out-Filterresults: notjunk:1;V01:K0:LTTwTEa95uo=:cVvTuhDZzQvrsYkkL0cYQh LbQ0VJqq6S77D/XsKb8mx/m6SCEYtCHQ9Xe9Jhd2IUDkMSHEprixA0ZXkGP+Fz4Z8D/fsJ8uM n21nGZwVeZgkYP6KCQksFbQO4k/UiO5hWzWmA6YsJ82OrkE49ly13DqVrEY5qljqHuiWjoLGk 3qkxywQk21YO4UcDsySb0zVX3ansoBSU/HWhF+JnWGITciikpjKUmmnP+BqmRpuTcESSlz+dX vkppwH8RPG96kTQQf8t+B6NQcWYo9HzKyTzQRbCSzGUFTgBOM7HbrZWqnSE1IaLMMRKpi1IF3 v2NEHm5fuLJzUl1T1nFxFh0RMqRKFzjUEo2a8F2L7lZh92O+aUJ3XnY7mNck34onK29UIShjy 5suz/qZbZsrsh/tl5RgNDx5D2d8nyXiJZnLHoM0ALQL/zEDJ+o5UE7v6btwAdvFk2J6h3gWVy sEOXwhhdiVo8PHuGbaL2PTjVTZWVDPPLKW1x+wZjT86OIR+WFSoWw7/K9g0nRotGS5YXzh5bg OzlxlxrrsfdVGLLkss/dwGJuNCWEl53/1ri6qIACF3ta8hFn+RkuxYhv/Sh6s41I4NHLw9Wyf W15ktBeyOStDrQ9rFPxgVhtLxVUclHENcoFvRFsk0gaEYiorSFJHtjDvKqczf3iHRnc23wQIZ 3848wV43DvAtemjOqPQjb3BDSJQTgf+3taDCMSBZZ6eBX6lp2GO2Uin9jhFto05CBNFNg3MRk KJfKk6hWJKm5r2W7wqb6BB4Dldz30NQCdB8yIw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-8 warnings about the new driver using a memset with a bogus length: drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_eps_exit': drivers/usb/host/xhci-dbgcap.c:369:2: error: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size] It looks like the author meant to use sizeof() rather than ARRAY_SIZE() here, so use that. Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver") Signed-off-by: Arnd Bergmann --- drivers/usb/host/xhci-dbgcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-dbgcap.c b/drivers/usb/host/xhci-dbgcap.c index 671e5023e683..1e535bd2be01 100644 --- a/drivers/usb/host/xhci-dbgcap.c +++ b/drivers/usb/host/xhci-dbgcap.c @@ -366,7 +366,7 @@ static void xhci_dbc_eps_exit(struct xhci_hcd *xhci) { struct xhci_dbc *dbc = xhci->dbc; - memset(dbc->eps, 0, ARRAY_SIZE(dbc->eps)); + memset(dbc->eps, 0, sizeof(dbc->eps)); } static int xhci_dbc_mem_init(struct xhci_hcd *xhci, gfp_t flags) -- 2.9.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: xhci: fix incorrect memset() From: Arnd Bergmann Message-Id: <20171211112806.3415781-1-arnd@arndb.de> Date: Mon, 11 Dec 2017 12:27:45 +0100 To: Mathias Nyman , Greg Kroah-Hartman Cc: Arnd Bergmann , Lu Baolu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: Z2NjLTggd2FybmluZ3MgYWJvdXQgdGhlIG5ldyBkcml2ZXIgdXNpbmcgYSBtZW1zZXQgd2l0aCBh IGJvZ3VzIGxlbmd0aDoKCmRyaXZlcnMvdXNiL2hvc3QveGhjaS1kYmdjYXAuYzogSW4gZnVuY3Rp b24gJ3hoY2lfZGJjX2Vwc19leGl0JzoKZHJpdmVycy91c2IvaG9zdC94aGNpLWRiZ2NhcC5jOjM2 OToyOiBlcnJvcjogJ21lbXNldCcgdXNlZCB3aXRoIGxlbmd0aCBlcXVhbCB0byBudW1iZXIgb2Yg ZWxlbWVudHMgd2l0aG91dCBtdWx0aXBsaWNhdGlvbiBieSBlbGVtZW50IHNpemUgWy1XZXJyb3I9 bWVtc2V0LWVsdC1zaXplXQoKSXQgbG9va3MgbGlrZSB0aGUgYXV0aG9yIG1lYW50IHRvIHVzZSBz aXplb2YoKSByYXRoZXIgdGhhbiBBUlJBWV9TSVpFKCkKaGVyZSwgc28gdXNlIHRoYXQuCgpGaXhl czogZGZiYTIxNzRkYzQyICgidXNiOiB4aGNpOiBBZGQgRGJDIHN1cHBvcnQgaW4geEhDSSBkcml2 ZXIiKQpTaWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgotLS0KIGRy aXZlcnMvdXNiL2hvc3QveGhjaS1kYmdjYXAuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2hvc3Qv eGhjaS1kYmdjYXAuYyBiL2RyaXZlcnMvdXNiL2hvc3QveGhjaS1kYmdjYXAuYwppbmRleCA2NzFl NTAyM2U2ODMuLjFlNTM1YmQyYmUwMSAxMDA2NDQKLS0tIGEvZHJpdmVycy91c2IvaG9zdC94aGNp LWRiZ2NhcC5jCisrKyBiL2RyaXZlcnMvdXNiL2hvc3QveGhjaS1kYmdjYXAuYwpAQCAtMzY2LDcg KzM2Niw3IEBAIHN0YXRpYyB2b2lkIHhoY2lfZGJjX2Vwc19leGl0KHN0cnVjdCB4aGNpX2hjZCAq eGhjaSkKIHsKIAlzdHJ1Y3QgeGhjaV9kYmMJCSpkYmMgPSB4aGNpLT5kYmM7CiAKLQltZW1zZXQo ZGJjLT5lcHMsIDAsIEFSUkFZX1NJWkUoZGJjLT5lcHMpKTsKKwltZW1zZXQoZGJjLT5lcHMsIDAs IHNpemVvZihkYmMtPmVwcykpOwogfQogCiBzdGF0aWMgaW50IHhoY2lfZGJjX21lbV9pbml0KHN0 cnVjdCB4aGNpX2hjZCAqeGhjaSwgZ2ZwX3QgZmxhZ3MpCg==