All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 4/6] efi_loader: comments for dp_part_fill()
Date: Mon, 11 Dec 2017 12:56:42 +0100	[thread overview]
Message-ID: <20171211115644.14015-5-xypron.glpk@gmx.de> (raw)
In-Reply-To: <20171211115644.14015-1-xypron.glpk@gmx.de>

Add a description for dp_part_fill().
Reword a comment in the function.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
v3
	new patch
---
 lib/efi_loader/efi_device_path.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/lib/efi_loader/efi_device_path.c b/lib/efi_loader/efi_device_path.c
index 6461ea9abc..31cdd38773 100644
--- a/lib/efi_loader/efi_device_path.c
+++ b/lib/efi_loader/efi_device_path.c
@@ -384,6 +384,13 @@ static unsigned dp_part_size(struct blk_desc *desc, int part)
 	return dpsize;
 }
 
+/*
+ * Create a device path for a block device or one of its partitions.
+ *
+ * @buf		buffer to which the device path is wirtten
+ * @desc	block device descriptor
+ * @part	partition number, 0 identifies a block device
+ */
 static void *dp_part_fill(void *buf, struct blk_desc *desc, int part)
 {
 	disk_partition_t info;
@@ -396,7 +403,7 @@ static void *dp_part_fill(void *buf, struct blk_desc *desc, int part)
 	 * and handling all the different cases like we do for non-
 	 * legacy (ie CONFIG_BLK=y) case.  But most important thing
 	 * is just to have a unique device-path for if_type+devnum.
-	 * So map things to a fictional USB device:
+	 * So map things to a fictitious USB device.
 	 */
 	struct efi_device_path_usb *udp;
 
-- 
2.15.1

  parent reply	other threads:[~2017-12-11 11:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 11:56 [U-Boot] [PATCH v3 0/6] efi_loader: correct media device paths Heinrich Schuchardt
2017-12-11 11:56 ` [U-Boot] [PATCH v3 1/6] efi_loader: correctly determine if an MMC device is an SD-card Heinrich Schuchardt
2017-12-11 11:56 ` [U-Boot] [PATCH v3 2/6] efi_loader: correctly setup device paths for block devices Heinrich Schuchardt
2017-12-11 11:56 ` [U-Boot] [PATCH v3 3/6] efi_loader: correct DeviceNodeToText for media types Heinrich Schuchardt
2017-12-11 11:56 ` Heinrich Schuchardt [this message]
2017-12-11 11:56 ` [U-Boot] [PATCH v3 5/6] efi_loader: create full device path for block devices Heinrich Schuchardt
2017-12-11 11:56 ` [U-Boot] [PATCH v3 6/6] efi_loader: support device path for IDE and SCSI disks Heinrich Schuchardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211115644.14015-5-xypron.glpk@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.