All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: gage.eads@intel.com, jerin.jacob@caviumnetworks.com,
	bruce.richardson@intel.com, nipun.gupta@nxp.com,
	santosh.shukla@caviumnetworks.com, harry.van.haaren@intel.com,
	hemant.agrawal@nxp.com
Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: [PATCH] eventdev: use links_map to unlink queues
Date: Mon, 11 Dec 2017 20:35:28 +0530	[thread overview]
Message-ID: <20171211150528.13236-1-pbhagavatula@caviumnetworks.com> (raw)

The octeontx event device doesn't store the queues to port mapping as a result
it cannot return the exact number of queues unlinked from a port when
application wants to unlink all the queues mapped (supplies queues param as
NULL).

Using links_map we can determine the exact queues mapped to a specific port and
unlink them.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 lib/librte_eventdev/rte_eventdev.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c
index e0c2a78..e17f8fc 100644
--- a/lib/librte_eventdev/rte_eventdev.c
+++ b/lib/librte_eventdev/rte_eventdev.c
@@ -888,7 +888,8 @@ rte_event_port_unlink(uint8_t dev_id, uint8_t port_id,
 {
 	struct rte_eventdev *dev;
 	uint8_t all_queues[RTE_EVENT_MAX_QUEUES_PER_DEV];
-	int i, diag;
+	uint8_t linked_queues[RTE_EVENT_MAX_QUEUES_PER_DEV];
+	int i, diag, j;
 	uint16_t *links_map;
 
 	RTE_EVENTDEV_VALID_DEVID_OR_ERRNO_RET(dev_id, -EINVAL, 0);
@@ -918,6 +919,18 @@ rte_event_port_unlink(uint8_t dev_id, uint8_t port_id,
 			rte_errno = -EINVAL;
 			return 0;
 		}
+	j = 0;
+	links_map = dev->data->links_map;
+	links_map += (port_id * RTE_EVENT_MAX_QUEUES_PER_DEV);
+	for (i = 0; i < nb_unlinks; i++) {
+		if (links_map[queues[i]] !=
+				EVENT_QUEUE_SERVICE_PRIORITY_INVALID) {
+			linked_queues[j] = queues[i];
+			j++;
+		}
+	}
+	queues = linked_queues;
+	nb_unlinks = j;
 
 	diag = (*dev->dev_ops->port_unlink)(dev, dev->data->ports[port_id],
 					queues, nb_unlinks);
-- 
2.7.4

             reply	other threads:[~2017-12-11 15:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 15:05 Pavan Nikhilesh [this message]
2017-12-11 17:24 ` [PATCH] eventdev: use links_map to unlink queues Eads, Gage
2017-12-12  7:23   ` Pavan Nikhilesh Bhagavatula
2017-12-12  9:33 ` [PATCH v2] eventdev: use links map " Pavan Nikhilesh
2017-12-12 16:08   ` Eads, Gage
2017-12-12 17:22     ` Pavan Nikhilesh Bhagavatula
2017-12-12 18:58 ` [PATCH v3] " Pavan Nikhilesh
2017-12-16  9:16   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211150528.13236-1-pbhagavatula@caviumnetworks.com \
    --to=pbhagavatula@caviumnetworks.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=nipun.gupta@nxp.com \
    --cc=santosh.shukla@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.