From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eryu Guan Subject: Re: [PATCH v3 3/3] generic/471: add syncfs test Date: Tue, 12 Dec 2017 17:24:19 +0800 Message-ID: <20171212092419.GR2749@eguan.usersys.redhat.com> References: <1513048179-151065-1-git-send-email-cgxu519@icloud.com> <1513048179-151065-3-git-send-email-cgxu519@icloud.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50783 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbdLLJYU (ORCPT ); Tue, 12 Dec 2017 04:24:20 -0500 Content-Disposition: inline In-Reply-To: <1513048179-151065-3-git-send-email-cgxu519@icloud.com> Sender: linux-unionfs-owner@vger.kernel.org List-Id: linux-unionfs@vger.kernel.org To: Chengguang Xu Cc: amir73il@gmail.com, fstests@vger.kernel.org, linux-unionfs@vger.kernel.org On Tue, Dec 12, 2017 at 11:09:39AM +0800, Chengguang Xu wrote: > Inspired by syncfs bug of overlayfs which does not sync dirtyinodes in > underlying filesystem. > Run syncfs and shutdown filesystem(or underlying filesystem of overlayfs) > to check syncfs result. > > Signed-off-by: Chengguang Xu > --- > > Changes since v2: > 1. Modify multiple test files to single small test file. > 2. Use fssum to check result instead of diff. > 3. Add comment for why running sync before test. > 4. Add option explanation of fssum. > > Changes since v1: > Use fs shutdown and fssum to check syncfs result instead of > checking delalloc state of extents. > > tests/generic/471 | 102 ++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/generic/471.out | 2 + > tests/generic/group | 1 + > 3 files changed, 105 insertions(+) > create mode 100755 tests/generic/471 > create mode 100644 tests/generic/471.out > > diff --git a/tests/generic/471 b/tests/generic/471 > new file mode 100755 > index 0000000..9d6c37a > --- /dev/null > +++ b/tests/generic/471 > @@ -0,0 +1,102 @@ > +#! /bin/bash > +# FS QA Test 471 > +# > +# Inspired by syncfs bug of overlayfs which does not sync dirty inodes in > +# underlying filesystem. > +# > +# Create a small file then run syncfs and shutdown filesystem(or underlying > +# filesystem of overlayfs) to check syncfs result. > +# > +# Test will be skipped if filesystem(or underlying filesystem of overlayfs) > +# does not support shutdown. > +# > +#----------------------------------------------------------------------- > +# Copyright (c) 2017 Chengguang Xu > +# All Rights Reserved. > +# > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU General Public License as > +# published by the Free Software Foundation. > +# > +# This program is distributed in the hope that it would be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write the Free Software Foundation, > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > +#----------------------------------------------------------------------- > +# > + > +seq=`basename $0` > +seqres=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here=`pwd` > +tmp=/tmp/$$ > +status=1 > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + cd / > + rm -f $tmp.* > +} > + > +# get standard environment, filters and checks > +. ./common/rc > +. ./common/filter > + > +# remove previous $seqres.full before test > +rm -f $seqres.full > + > +# real QA test starts here > + > +_supported_fs generic > +_supported_os Linux > +_require_fssum > +_require_scratch > +_require_scratch_shutdown > +_require_xfs_io_command "syncfs" > + > +_scratch_mkfs >/dev/null 2>&1 Need "_require_metadata_journaling $SCRATCH_DEV" after _scratch_mkfs, so filesystems like no-journal mode ext4 or ext2 (driven by ext4 module) won't run this test. > +_scratch_mount > + > +# Background writeback will flush dirty inode by dirty ratio and dirty time > +# period(default 30 seconds), in order to avoid interference from it, > +# run sync before test to make all dirty inodes clean, and it also > +# accelerates syncfs on testing filesystem so that test case can finish > +# in 30 seconds. > + > +sync > + > +$XFS_IO_PROG -f -c "pwrite 0 4K" $SCRATCH_MNT/testfile >/dev/null 2>&1 > + > +# fssum used for comparing checksum of test file(data & metedata). > +# option explanation: > +# -f : write out a full manifest file > +# -w : send output to file > +# -r : read checksum or manifest from file > +# > +# -[ugoamcde] : specify which fields to include in checksum calculation. > +# u : include uid > +# g : include gid > +# o : include mode > +# m : include mtime > +# a : include atime > +# c : include ctime > +# d : include file data > +# e : include open errors (aborts otherwise) > +# s : include block structure (holes) > +# -[UGOAMCDES]: exclude respective field from calculation > + > +$FSSUM_PROG -ugomAcdES -f -w $tmp.fssum $SCRATCH_MNT > +$XFS_IO_PROG -c "syncfs" $SCRATCH_MNT/testfile >/dev/null 2>&1 > +_scratch_shutdown > +_scratch_cycle_mount > +$FSSUM_PROG -r $tmp.fssum $SCRATCH_MNT >/dev/null 2>&1 No need to throw away the fssum -r output, just dump its output and let it match the golden image. On failure, fssum reports something like: metadata and data mismatch in /testfile FAIL and on success, it prints a "OK". So the code can be: ... $FSSUM_PROG -r $tmp.fssum $SCRATCH_MNT status=0 exit > +status=$? > + > +echo "Silence is golden" > +exit > diff --git a/tests/generic/471.out b/tests/generic/471.out > new file mode 100644 > index 0000000..79fb532 > --- /dev/null > +++ b/tests/generic/471.out > @@ -0,0 +1,2 @@ > +QA output created by 471 > +Silence is golden And update .out file as: QA output created by 471 OK This way, it's clearer in which way test fails on failure: --- tests/generic/471.out 2017-12-12 15:37:59.011005399 +0800 +++ /root/xfstests/results//xfs_4k/generic/471.out.bad 2017-12-12 17:19:54.043896626 +0800 @@ -1,2 +1,3 @@ QA output created by 471 -OK +metadata and data mismatch in /testfile +FAIL Thanks, Eryu > diff --git a/tests/generic/group b/tests/generic/group > index 6c3bb03..493a44c 100644 > --- a/tests/generic/group > +++ b/tests/generic/group > @@ -472,3 +472,4 @@ > 468 shutdown auto quick metadata > 469 auto quick > 470 auto quick dax > +471 auto quick shutdown sync > -- > 1.8.3.1 >