From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752326AbdLLKgq (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 05:36:46 -0500
Received: from mail-wr0-f174.google.com ([209.85.128.174]:37752 "EHLO
        mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752265AbdLLKgo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 05:36:44 -0500
X-Google-Smtp-Source: ACJfBosKfuEghI3X1a8eNCl6jZbzZlebwU7PrVzGzVhs1xxOMPzBaRPbXzaxQTW7bK17b0Mr5qI0eg==
Date: Tue, 12 Dec 2017 11:36:40 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com,
        xen-devel <xen-devel@lists.xenproject.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>, sds@tycho.nsa.gov,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: consider effective protection attributes in W+X
 check
Message-ID: <20171212103640.qcpyj7wxuimfkvjp@gmail.com>
References: <5A2FBC570200007800196B3E@prv-mh.provo.novell.com>
 <5A2FBE0A0200007800196B4F@prv-mh.provo.novell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5A2FBE0A0200007800196B4F@prv-mh.provo.novell.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Jan Beulich <JBeulich@suse.com> wrote:

> Using just the leaf page table entry flags would cause a false warning
> in case _PAGE_RW is clear or _PAGE_NX is set in a higher level entry.

Good find - I assume this bug can cause both false positives and false negatives 
as well, right?

Thanks,

	Ingo