From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752119AbdLNDeh (ORCPT ); Wed, 13 Dec 2017 22:34:37 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:50594 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbdLNDeg (ORCPT ); Wed, 13 Dec 2017 22:34:36 -0500 Date: Wed, 13 Dec 2017 22:34:32 -0500 (EST) Message-Id: <20171213.223432.393103915049464102.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: perex@perex.cz, floeff@mathematik.uni-stuttgart.de, acme@conectiva.com.br, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub From: David Miller In-Reply-To: <18472c42-4eaf-7189-a16f-489a706cba3e@gmail.com> References: <1513158468-14382-1-git-send-email-baijiaju1990@gmail.com> <20171213.162032.129766742729458957.davem@davemloft.net> <18472c42-4eaf-7189-a16f-489a706cba3e@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Dec 2017 19:34:35 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai Date: Thu, 14 Dec 2017 11:13:15 +0800 > Thanks for reply :) > I think I should use "udelay(100000/HZ)" instead, do you think it is > right? The delay is too long, please do not ignore that part of my critique of your change. You cannot delay so long under a lock, that's why the code is trying to use a sleeping delay. I'm not going to explain this problem another time.