From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbdLMLN4 (ORCPT ); Wed, 13 Dec 2017 06:13:56 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36589 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751933AbdLMLNv (ORCPT ); Wed, 13 Dec 2017 06:13:51 -0500 X-Google-Smtp-Source: ACJfBosQMtLKbXpg1UbiB8Hmzk768W57pZRYot11fnd4cbKMtOcH/GisD5RS+q9EBpAd5XyJmO3ppw== Date: Wed, 13 Dec 2017 12:13:46 +0100 From: Juri Lelli To: Viresh Kumar Cc: Rafael Wysocki , Ingo Molnar , Peter Zijlstra , linux-pm@vger.kernel.org, Vincent Guittot , dietmar.eggemann@arm.com, morten.rasmussen@arm.com, tkjos@android.com, joelaf@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] cpufreq: schedutil: Initialize sg_cpu->flags to 0 Message-ID: <20171213111346.GC30887@localhost.localdomain> References: <763feda6424ced8486b25a0c52979634e6104478.1513158452.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <763feda6424ced8486b25a0c52979634e6104478.1513158452.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Viresh, On 13/12/17 15:23, Viresh Kumar wrote: > Initializing sg_cpu->flags to SCHED_CPUFREQ_RT has no obvious benefit. > The flags field wouldn't be used until the utilization update handler is > called for the first time, and once that is called we will overwrite > flags anyway. > > Initialize it to 0. > > Change-Id: I028dbb40c5c242cff52fe1b14aeaff37f29a2f8d Without ^ > Signed-off-by: Viresh Kumar Reviewed-by: Juri Lelli Best, - Juri