From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752714AbdLMLxB (ORCPT ); Wed, 13 Dec 2017 06:53:01 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49276 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbdLMLxA (ORCPT ); Wed, 13 Dec 2017 06:53:00 -0500 Date: Wed, 13 Dec 2017 12:53:04 +0100 From: Greg KH To: Peter Johennecken Cc: linux@Wolf-Entwicklungen.de, linux-kernel@vger.kernel.org, Peter Johennecken Subject: Re: [PATCH] staging: pi433: fixed coding style issues Message-ID: <20171213115304.GA11023@kroah.com> References: <20171208233135.22800-1-peter.johennecken@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208233135.22800-1-peter.johennecken@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 09, 2017 at 12:31:35AM +0100, Peter Johennecken wrote: > Fixed braces, double empty lines, tabs and spaces > and a macro with checkpatch. > > Signed-off-by: Peter Johennecken > --- > drivers/staging/pi433/pi433_if.c | 242 +++++++++++-------------- > drivers/staging/pi433/pi433_if.h | 13 +- > drivers/staging/pi433/rf69.c | 66 ++++--- > drivers/staging/pi433/rf69.h | 5 +- > drivers/staging/pi433/rf69_enum.h | 314 +++++++++++++++------------------ > drivers/staging/pi433/rf69_registers.h | 4 - > 6 files changed, 286 insertions(+), 358 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot