From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752942AbdLMMZi (ORCPT ); Wed, 13 Dec 2017 07:25:38 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:55526 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbdLMMZe (ORCPT ); Wed, 13 Dec 2017 07:25:34 -0500 Date: Wed, 13 Dec 2017 04:25:33 -0800 From: Matthew Wilcox To: Michal Hocko Cc: linux-api@vger.kernel.org, Khalid Aziz , Michael Ellerman , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , linux-mm@kvack.org, LKML , linux-arch@vger.kernel.org, Florian Weimer , John Hubbard , Abdul Haleem , Joel Stanley , Kees Cook , Michal Hocko Subject: Re: [PATCH v2 0/2] mm: introduce MAP_FIXED_SAFE Message-ID: <20171213122533.GA2384@bombadil.infradead.org> References: <20171213092550.2774-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213092550.2774-1-mhocko@kernel.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 13, 2017 at 10:25:48AM +0100, Michal Hocko wrote: > I am afraid we can bikeshed this to death and there will still be > somebody finding yet another better name. Therefore I've decided to > stick with my original MAP_FIXED_SAFE. Why? Well, because it keeps the > MAP_FIXED prefix which should be recognized by developers and _SAFE > suffix should also be clear that all dangerous side effects of the old > MAP_FIXED are gone. I liked basically every other name suggested more than MAP_FIXED_SAFE. "Safe against what?" was an important question. MAP_AT_ADDR was the best suggestion I saw that wasn't one of mine. Of my suggestions, I liked MAP_STATIC the best. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH v2 0/2] mm: introduce MAP_FIXED_SAFE Date: Wed, 13 Dec 2017 04:25:33 -0800 Message-ID: <20171213122533.GA2384@bombadil.infradead.org> References: <20171213092550.2774-1-mhocko@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171213092550.2774-1-mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michal Hocko Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Khalid Aziz , Michael Ellerman , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, LKML , linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Florian Weimer , John Hubbard , Abdul Haleem , Joel Stanley , Kees Cook , Michal Hocko List-Id: linux-api@vger.kernel.org On Wed, Dec 13, 2017 at 10:25:48AM +0100, Michal Hocko wrote: > I am afraid we can bikeshed this to death and there will still be > somebody finding yet another better name. Therefore I've decided to > stick with my original MAP_FIXED_SAFE. Why? Well, because it keeps the > MAP_FIXED prefix which should be recognized by developers and _SAFE > suffix should also be clear that all dangerous side effects of the old > MAP_FIXED are gone. I liked basically every other name suggested more than MAP_FIXED_SAFE. "Safe against what?" was an important question. MAP_AT_ADDR was the best suggestion I saw that wasn't one of mine. Of my suggestions, I liked MAP_STATIC the best. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f199.google.com (mail-pf0-f199.google.com [209.85.192.199]) by kanga.kvack.org (Postfix) with ESMTP id 074566B0253 for ; Wed, 13 Dec 2017 07:25:43 -0500 (EST) Received: by mail-pf0-f199.google.com with SMTP id y62so1712726pfd.3 for ; Wed, 13 Dec 2017 04:25:42 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [65.50.211.133]) by mx.google.com with ESMTPS id e22si1303815plj.568.2017.12.13.04.25.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Dec 2017 04:25:42 -0800 (PST) Date: Wed, 13 Dec 2017 04:25:33 -0800 From: Matthew Wilcox Subject: Re: [PATCH v2 0/2] mm: introduce MAP_FIXED_SAFE Message-ID: <20171213122533.GA2384@bombadil.infradead.org> References: <20171213092550.2774-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213092550.2774-1-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-api@vger.kernel.org, Khalid Aziz , Michael Ellerman , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , linux-mm@kvack.org, LKML , linux-arch@vger.kernel.org, Florian Weimer , John Hubbard , Abdul Haleem , Joel Stanley , Kees Cook , Michal Hocko On Wed, Dec 13, 2017 at 10:25:48AM +0100, Michal Hocko wrote: > I am afraid we can bikeshed this to death and there will still be > somebody finding yet another better name. Therefore I've decided to > stick with my original MAP_FIXED_SAFE. Why? Well, because it keeps the > MAP_FIXED prefix which should be recognized by developers and _SAFE > suffix should also be clear that all dangerous side effects of the old > MAP_FIXED are gone. I liked basically every other name suggested more than MAP_FIXED_SAFE. "Safe against what?" was an important question. MAP_AT_ADDR was the best suggestion I saw that wasn't one of mine. Of my suggestions, I liked MAP_STATIC the best. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org