From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753074AbdLMPBE (ORCPT ); Wed, 13 Dec 2017 10:01:04 -0500 Received: from merlin.infradead.org ([205.233.59.134]:44302 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886AbdLMPBC (ORCPT ); Wed, 13 Dec 2017 10:01:02 -0500 Date: Wed, 13 Dec 2017 16:00:07 +0100 From: Peter Zijlstra To: "Kirill A. Shutemov" Cc: Dan Williams , Dave Hansen , Andy Lutomirski , Thomas Gleixner , LKML , X86 ML , Linus Torvalds , Borislav Petkov , Greg KH , Kees Cook , Hugh Dickins , Brian Gerst , Josh Poimboeuf , Denys Vlasenko , Boris Ostrovsky , Juergen Gross , David Laight , Eduardo Valentin , aliguori@amazon.com, Will Deacon , "linux-mm@kvack.org" , kirill.shutemov@linux.intel.com, aneesh.kumar@linux.vnet.ibm.com Subject: Re: [patch 05/16] mm: Allow special mappings with user access cleared Message-ID: <20171213150007.fonxub6yzjh2iu2c@hirez.programming.kicks-ass.net> References: <20171212173221.496222173@linutronix.de> <20171212173333.669577588@linutronix.de> <20171213122211.bxcb7xjdwla2bqol@hirez.programming.kicks-ass.net> <20171213125739.fllckbl3o4nonmpx@node.shutemov.name> <20171213143455.oqigy6m53qhuu7k4@hirez.programming.kicks-ass.net> <20171213144339.ii5gk2arwg5ivr6b@node.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213144339.ii5gk2arwg5ivr6b@node.shutemov.name> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 13, 2017 at 05:43:39PM +0300, Kirill A. Shutemov wrote: > > am I perchance looking at the wrong tee? > > I'm looking at Linus' tree. Clearly I'm not synced up enough... :/ > It was changed recently: > 5c9d2d5c269c ("mm: replace pte_write with pte_access_permitted in fault + gup paths") > Indeed. So FOLL_GET should also get these tests and, as you said, the other levels too. I would like FOLL_POPULATE (doesn't have FOLL_GET) to be allowed 'access'. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f200.google.com (mail-io0-f200.google.com [209.85.223.200]) by kanga.kvack.org (Postfix) with ESMTP id DA01C6B0033 for ; Wed, 13 Dec 2017 10:00:41 -0500 (EST) Received: by mail-io0-f200.google.com with SMTP id k190so2409009iok.2 for ; Wed, 13 Dec 2017 07:00:41 -0800 (PST) Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id c189si1712220ith.5.2017.12.13.07.00.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Dec 2017 07:00:40 -0800 (PST) Date: Wed, 13 Dec 2017 16:00:07 +0100 From: Peter Zijlstra Subject: Re: [patch 05/16] mm: Allow special mappings with user access cleared Message-ID: <20171213150007.fonxub6yzjh2iu2c@hirez.programming.kicks-ass.net> References: <20171212173221.496222173@linutronix.de> <20171212173333.669577588@linutronix.de> <20171213122211.bxcb7xjdwla2bqol@hirez.programming.kicks-ass.net> <20171213125739.fllckbl3o4nonmpx@node.shutemov.name> <20171213143455.oqigy6m53qhuu7k4@hirez.programming.kicks-ass.net> <20171213144339.ii5gk2arwg5ivr6b@node.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213144339.ii5gk2arwg5ivr6b@node.shutemov.name> Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Dan Williams , Dave Hansen , Andy Lutomirski , Thomas Gleixner , LKML , X86 ML , Linus Torvalds , Borislav Petkov , Greg KH , Kees Cook , Hugh Dickins , Brian Gerst , Josh Poimboeuf , Denys Vlasenko , Boris Ostrovsky , Juergen Gross , David Laight , Eduardo Valentin , aliguori@amazon.com, Will Deacon , "linux-mm@kvack.org" , kirill.shutemov@linux.intel.com, aneesh.kumar@linux.vnet.ibm.com On Wed, Dec 13, 2017 at 05:43:39PM +0300, Kirill A. Shutemov wrote: > > am I perchance looking at the wrong tee? > > I'm looking at Linus' tree. Clearly I'm not synced up enough... :/ > It was changed recently: > 5c9d2d5c269c ("mm: replace pte_write with pte_access_permitted in fault + gup paths") > Indeed. So FOLL_GET should also get these tests and, as you said, the other levels too. I would like FOLL_POPULATE (doesn't have FOLL_GET) to be allowed 'access'. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org