From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eP9Or-0002kc-Gd for qemu-devel@nongnu.org; Wed, 13 Dec 2017 10:56:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eP9On-0008CD-L6 for qemu-devel@nongnu.org; Wed, 13 Dec 2017 10:56:49 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:27643) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eP9On-0008Bg-CS for qemu-devel@nongnu.org; Wed, 13 Dec 2017 10:56:45 -0500 Date: Wed, 13 Dec 2017 15:04:55 +0000 From: Anthony PERARD Message-ID: <20171213150455.GG2216@perard.uk.xensource.com> References: <20171212141044.2582-1-berrange@redhat.com> <20171212141044.2582-2-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171212141044.2582-2-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 1/4] hw: convert virtio-input-hid device to keycodemapdb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Paolo Bonzini , Stefano Stabellini , xen-devel@lists.xenproject.org On Tue, Dec 12, 2017 at 02:10:41PM +0000, Daniel P. Berrange wrote: > diff --git a/Makefile b/Makefile > index ab0354c153..5aaff5fe1e 100644 > --- a/Makefile > +++ b/Makefile > @@ -227,6 +227,7 @@ KEYCODEMAP_CSV = $(SRC_PATH)/ui/keycodemapdb/data/keymaps.csv > > KEYCODEMAP_FILES = \ > ui/input-keymap-linux-to-qcode.c \ > + ui/input-keymap-qcode-to-linux.c \ > ui/input-keymap-qcode-to-qnum.c \ > ui/input-keymap-qnum-to-qcode.c \ > $(NULL) FYI, there is a patch on the mailing list that does just generate the new keymap: <20171103115631.15175-2-owen.smith@citrix.com> ([PATCH v5 1/4] ui: generate qcode to linux mappings) > diff --git a/include/ui/input.h b/include/ui/input.h > index f8cee43f65..6f56d868c7 100644 > --- a/include/ui/input.h > +++ b/include/ui/input.h > @@ -71,6 +71,9 @@ void qemu_remove_mouse_mode_change_notifier(Notifier *notify); > extern const guint qemu_input_map_linux_to_qcode_len; > extern const guint16 qemu_input_map_linux_to_qcode[]; > > +extern const guint qemu_input_map_qcode_to_linux_len; > +extern const guint16 qemu_input_map_qcode_to_linux[]; > + > extern const guint qemu_input_map_qcode_to_qnum_len; > extern const guint16 qemu_input_map_qcode_to_qnum[]; > > diff --git a/ui/input-keymap.c b/ui/input-keymap.c > index 3a19a169f5..6e543d651f 100644 > --- a/ui/input-keymap.c > +++ b/ui/input-keymap.c > @@ -6,6 +6,7 @@ > #include "standard-headers/linux/input.h" > > #include "ui/input-keymap-linux-to-qcode.c" > +#include "ui/input-keymap-qcode-to-linux.c" > #include "ui/input-keymap-qcode-to-qnum.c" > #include "ui/input-keymap-qnum-to-qcode.c" -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH v6 1/4] hw: convert virtio-input-hid device to keycodemapdb Date: Wed, 13 Dec 2017 15:04:55 +0000 Message-ID: <20171213150455.GG2216@perard.uk.xensource.com> References: <20171212141044.2582-1-berrange@redhat.com> <20171212141044.2582-2-berrange@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eP8gJ-0004mV-Ad for xen-devel@lists.xenproject.org; Wed, 13 Dec 2017 15:10:47 +0000 Content-Disposition: inline In-Reply-To: <20171212141044.2582-2-berrange@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: "Daniel P. Berrange" Cc: Paolo Bonzini , Stefano Stabellini , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, Gerd Hoffmann List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBEZWMgMTIsIDIwMTcgYXQgMDI6MTA6NDFQTSArMDAwMCwgRGFuaWVsIFAuIEJlcnJh bmdlIHdyb3RlOgo+IGRpZmYgLS1naXQgYS9NYWtlZmlsZSBiL01ha2VmaWxlCj4gaW5kZXggYWIw MzU0YzE1My4uNWFhZmY1ZmUxZSAxMDA2NDQKPiAtLS0gYS9NYWtlZmlsZQo+ICsrKyBiL01ha2Vm aWxlCj4gQEAgLTIyNyw2ICsyMjcsNyBAQCBLRVlDT0RFTUFQX0NTViA9ICQoU1JDX1BBVEgpL3Vp L2tleWNvZGVtYXBkYi9kYXRhL2tleW1hcHMuY3N2Cj4gIAo+ICBLRVlDT0RFTUFQX0ZJTEVTID0g XAo+ICAJCSB1aS9pbnB1dC1rZXltYXAtbGludXgtdG8tcWNvZGUuYyBcCj4gKwkJIHVpL2lucHV0 LWtleW1hcC1xY29kZS10by1saW51eC5jIFwKPiAgCQkgdWkvaW5wdXQta2V5bWFwLXFjb2RlLXRv LXFudW0uYyBcCj4gIAkJIHVpL2lucHV0LWtleW1hcC1xbnVtLXRvLXFjb2RlLmMgXAo+ICAJCSAk KE5VTEwpCgpGWUksIHRoZXJlIGlzIGEgcGF0Y2ggb24gdGhlIG1haWxpbmcgbGlzdCB0aGF0IGRv ZXMganVzdCBnZW5lcmF0ZSB0aGUKbmV3IGtleW1hcDoKPDIwMTcxMTAzMTE1NjMxLjE1MTc1LTIt b3dlbi5zbWl0aEBjaXRyaXguY29tPgooW1BBVENIIHY1IDEvNF0gdWk6IGdlbmVyYXRlIHFjb2Rl IHRvIGxpbnV4IG1hcHBpbmdzKQoKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS91aS9pbnB1dC5oIGIv aW5jbHVkZS91aS9pbnB1dC5oCj4gaW5kZXggZjhjZWU0M2Y2NS4uNmY1NmQ4NjhjNyAxMDA2NDQK PiAtLS0gYS9pbmNsdWRlL3VpL2lucHV0LmgKPiArKysgYi9pbmNsdWRlL3VpL2lucHV0LmgKPiBA QCAtNzEsNiArNzEsOSBAQCB2b2lkIHFlbXVfcmVtb3ZlX21vdXNlX21vZGVfY2hhbmdlX25vdGlm aWVyKE5vdGlmaWVyICpub3RpZnkpOwo+ICBleHRlcm4gY29uc3QgZ3VpbnQgcWVtdV9pbnB1dF9t YXBfbGludXhfdG9fcWNvZGVfbGVuOwo+ICBleHRlcm4gY29uc3QgZ3VpbnQxNiBxZW11X2lucHV0 X21hcF9saW51eF90b19xY29kZVtdOwo+ICAKPiArZXh0ZXJuIGNvbnN0IGd1aW50IHFlbXVfaW5w dXRfbWFwX3Fjb2RlX3RvX2xpbnV4X2xlbjsKPiArZXh0ZXJuIGNvbnN0IGd1aW50MTYgcWVtdV9p bnB1dF9tYXBfcWNvZGVfdG9fbGludXhbXTsKPiArCj4gIGV4dGVybiBjb25zdCBndWludCBxZW11 X2lucHV0X21hcF9xY29kZV90b19xbnVtX2xlbjsKPiAgZXh0ZXJuIGNvbnN0IGd1aW50MTYgcWVt dV9pbnB1dF9tYXBfcWNvZGVfdG9fcW51bVtdOwo+ICAKPiBkaWZmIC0tZ2l0IGEvdWkvaW5wdXQt a2V5bWFwLmMgYi91aS9pbnB1dC1rZXltYXAuYwo+IGluZGV4IDNhMTlhMTY5ZjUuLjZlNTQzZDY1 MWYgMTAwNjQ0Cj4gLS0tIGEvdWkvaW5wdXQta2V5bWFwLmMKPiArKysgYi91aS9pbnB1dC1rZXlt YXAuYwo+IEBAIC02LDYgKzYsNyBAQAo+ICAjaW5jbHVkZSAic3RhbmRhcmQtaGVhZGVycy9saW51 eC9pbnB1dC5oIgo+ICAKPiAgI2luY2x1ZGUgInVpL2lucHV0LWtleW1hcC1saW51eC10by1xY29k ZS5jIgo+ICsjaW5jbHVkZSAidWkvaW5wdXQta2V5bWFwLXFjb2RlLXRvLWxpbnV4LmMiCj4gICNp bmNsdWRlICJ1aS9pbnB1dC1rZXltYXAtcWNvZGUtdG8tcW51bS5jIgo+ICAjaW5jbHVkZSAidWkv aW5wdXQta2V5bWFwLXFudW0tdG8tcWNvZGUuYyIKCi0tIApBbnRob255IFBFUkFSRAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==