From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 2/2] gro: support VxLAN GRO
Date: Wed, 13 Dec 2017 18:58:01 -0800
Message-ID: <20171213185801.2add4e46@xeon-e3>
References: <1511579860-37020-1-git-send-email-jiayu.hu@intel.com>
 <1513219779-100115-1-git-send-email-jiayu.hu@intel.com>
 <1513219779-100115-3-git-send-email-jiayu.hu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, jianfeng.tan@intel.com,
 junjie.j.chen@intel.com, john.mcnamara@intel.com, matvejchikov@gmail.com
To: Jiayu Hu <jiayu.hu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com
 [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id 83A5B1B00E
 for <dev@dpdk.org>; Thu, 14 Dec 2017 03:58:04 +0100 (CET)
Received: by mail-pf0-f195.google.com with SMTP id m26so2646121pfj.11
 for <dev@dpdk.org>; Wed, 13 Dec 2017 18:58:04 -0800 (PST)
In-Reply-To: <1513219779-100115-3-git-send-email-jiayu.hu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 14 Dec 2017 10:49:39 +0800
Jiayu Hu <jiayu.hu@intel.com> wrote:

> +
> +static inline int
> +is_same_vxlan_tcp4_flow(struct vxlan_tcp4_flow_key k1,
> +		struct vxlan_tcp4_flow_key k2)
> +{
> +	return (is_same_ether_addr(&k1.outer_eth_saddr, &k2.outer_eth_saddr) &&
> +			is_same_ether_addr(&k1.outer_eth_daddr,
> +				&k2.outer_eth_daddr) &&
> +			(k1.outer_ip_src_addr == k2.outer_ip_src_addr) &&
> +			(k1.outer_ip_dst_addr == k2.outer_ip_dst_addr) &&
> +			(k1.outer_src_port == k2.outer_src_port) &&
> +			(k1.outer_dst_port == k2.outer_dst_port) &&
> +			(k1.vxlan_hdr.vx_flags == k2.vxlan_hdr.vx_flags) &&
> +			(k1.vxlan_hdr.vx_vni == k2.vxlan_hdr.vx_vni) &&
> +			is_same_tcp4_flow(k1.inner_key, k2.inner_key));

Maybe this could be optimized with memcmp because many of the fields are contiguous.