All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Alistair Francis <alistair.francis@xilinx.com>,
	"Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
	Prasad J Pandit <pjp@fedoraproject.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	Andrew Baumann <Andrew.Baumann@microsoft.com>,
	Andrey Smirnov <andrew.smirnov@gmail.com>,
	Andrey Yurovsky <yurovsky@gmail.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Sai Pavan Boddu" <saipava@xilinx.com>
Subject: [Qemu-devel] [PATCH 05/14] sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h"
Date: Wed, 13 Dec 2017 16:58:43 -0300	[thread overview]
Message-ID: <20171213195852.30439-6-f4bug@amsat.org> (raw)
In-Reply-To: <20171213195852.30439-1-f4bug@amsat.org>

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/sd/sdhci-internal.h | 1 +
 hw/sd/sdhci.c          | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h
index 248fd027f9..e941bc2386 100644
--- a/hw/sd/sdhci-internal.h
+++ b/hw/sd/sdhci-internal.h
@@ -43,6 +43,7 @@
 #define SDHC_TRNS_ACMD12               0x0004
 #define SDHC_TRNS_READ                 0x0010
 #define SDHC_TRNS_MULTI                0x0020
+#define SDHC_TRNMOD_MASK               0x0037
 
 /* R/W Command Register 0x0 */
 #define SDHC_CMDREG                    0x0E
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 295a89e5d3..a56c0c273e 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -120,7 +120,6 @@
     (SDHC_CAPAB_BASECLKFREQ << 8) | (SDHC_CAPAB_TOUNIT << 7) | \
     (SDHC_CAPAB_TOCLKFREQ))
 
-#define MASK_TRNMOD     0x0037
 #define MASKED_WRITE(reg, mask, val)  (reg = (reg & (mask)) | (val))
 
 static uint8_t sdhci_slotint(SDHCIState *s)
@@ -1043,7 +1042,7 @@ sdhci_write(void *opaque, hwaddr offset, uint64_t val, unsigned size)
         if (!(s->capareg & SDHC_CAN_DO_DMA)) {
             value &= ~SDHC_TRNS_DMA;
         }
-        MASKED_WRITE(s->trnmod, mask, value & MASK_TRNMOD);
+        MASKED_WRITE(s->trnmod, mask, value & SDHC_TRNMOD_MASK);
         MASKED_WRITE(s->cmdreg, mask >> 16, value >> 16);
 
         /* Writing to the upper byte of CMDREG triggers SD command generation */
-- 
2.15.1

  parent reply	other threads:[~2017-12-13 19:59 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 19:58 [Qemu-devel] [PATCH 00/14] SDHCI housekeeping Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 01/14] sd: split "sd-internal.h" of "hw/sd/sd.h" Philippe Mathieu-Daudé
2017-12-14 17:50   ` Alistair Francis
2017-12-14 17:59     ` Philippe Mathieu-Daudé
2017-12-14 19:33       ` Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 02/14] sdhci: clean up includes Philippe Mathieu-Daudé
2017-12-14 17:17   ` Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 03/14] sdhci: use the ldst_le_dma() API Philippe Mathieu-Daudé
2017-12-14 17:23   ` Alistair Francis
2017-12-14 23:21     ` Philippe Mathieu-Daudé
2017-12-14 23:25       ` Alistair Francis
2017-12-15  0:38         ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 04/14] sdhci: use deposit64() Philippe Mathieu-Daudé
2017-12-14 17:28   ` Alistair Francis
2017-12-14 23:25     ` Philippe Mathieu-Daudé
2017-12-14 23:41       ` Alistair Francis
2017-12-15  0:07         ` Philippe Mathieu-Daudé
2017-12-15  1:14           ` Alistair Francis
2017-12-15  1:51             ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` Philippe Mathieu-Daudé [this message]
2017-12-14 17:29   ` [Qemu-devel] [PATCH 05/14] sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h" Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/pci properties into a common one Philippe Mathieu-Daudé
2017-12-14 17:32   ` Alistair Francis
2017-12-14 18:40     ` Philippe Mathieu-Daudé
2017-12-14 19:36       ` Alistair Francis
2017-12-15  4:42       ` Kevin O'Connor
2017-12-15  8:10       ` Paolo Bonzini
2017-12-13 19:58 ` [Qemu-devel] [PATCH 07/14] sdhci: refactor common sysbus/pci realize() into sdhci_realizefn() Philippe Mathieu-Daudé
2017-12-14 17:42   ` Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 08/14] sdhci: refactor common sysbus/pci class_init() into sdhci_class_init() Philippe Mathieu-Daudé
2017-12-14 17:44   ` Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 09/14] sdhci: refactor common sysbus/pci unrealize() into sdhci_unrealizefn() Philippe Mathieu-Daudé
2017-12-14 17:46   ` Alistair Francis
2017-12-14 18:07     ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 10/14] sdhci: use qemu_log_mask(UNIMP) instead of fprintf() Philippe Mathieu-Daudé
2017-12-14 17:47   ` Alistair Francis
2017-12-14 18:14     ` Philippe Mathieu-Daudé
2017-12-14 19:38       ` Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 11/14] sdhci: convert the DPRINT() calls into trace events Philippe Mathieu-Daudé
2017-12-14 17:54   ` Alistair Francis
2017-12-14 18:19     ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 12/14] sdhci: add a trace event for the LED control Philippe Mathieu-Daudé
2017-12-14 17:55   ` Alistair Francis
2017-12-14 23:32     ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 13/14] sdhci: add sdhci_init_capareg() to initialize the CAPAB register Philippe Mathieu-Daudé
2017-12-14 17:51   ` Alistair Francis
2017-12-14 18:02     ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 14/14] sdhci: add a "dma-memory" property Philippe Mathieu-Daudé
2017-12-14 17:49   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213195852.30439-6-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=Andrew.Baumann@microsoft.com \
    --cc=alistair.francis@xilinx.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=pjp@fedoraproject.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=saipava@xilinx.com \
    --cc=yurovsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.