From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753929AbdLMVr7 (ORCPT ); Wed, 13 Dec 2017 16:47:59 -0500 Received: from erebus.the-tk.com ([109.74.205.187]:40600 "EHLO erebus.the-tk.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753878AbdLMVr4 (ORCPT ); Wed, 13 Dec 2017 16:47:56 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=the-tk.com; h=date:from:to :cc:subject:message-id:references:mime-version:content-type :in-reply-to; q=dns; s=sel0; b=C2BbFcgg1se5HVISgxyzknRBvsk3+6aah igATVQKnjyI/2x7gyAcnaiE5DeENHxj/HmyKDjRF5r+cDH77dvGnoEcXSrtWPmSU a8Q0UGwbtzqP92mcpYMOemCI/DYUX4GK9OGkrrMEWj3jScFFgh6h0y0WRbfMOjCa aTMKC0PxRw= Date: Wed, 13 Dec 2017 21:47:46 +0000 From: Tomasz Kramkowski To: Alex Manoussakis Cc: Jiri Kosina , Benjamin Tissoires , Yuxuan Shui , Diego Elio =?iso-8859-1?Q?Petten=F2?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice Message-ID: <20171213214746.GA23615@gaia.local> References: <20171204205550.2621-1-tk@the-tk.com> <20171205201307.GA13831@gaia.local> <20171209172311.GA5570@gaia.local> <20171211173116.GA9941@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171211173116.GA9941@gnu.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 11, 2017 at 12:31:16PM -0500, Alex Manoussakis wrote: > Tomasz please add the wireless version in your next patch, a web search > shows it's called M-XT3DRBK and the USB ID is 0x00fc. M-XT3DRBK is the full model number for the wireless EX-G but since the HUGE and DEFT both use their short names in the hid-ids macros then I'll call this one EX_G_WIRELESS so that it matches the naming style of everything else. However, I'm a bit apprehensive about sending in a patch for a device I can't test. Even if it's most likely going to work. Do you know of anyone who can test this wireless EX-G variant? I guess Jiri can chip in if he thinks this is not necessary. Technically this patch should sit in linux-next for a while (but reportedly few people actually run on that iirc) and the worst that could happen is that the checks in the report fixup function don't match the expected report and don't apply the fix, or (unlikely) some padding bits get exposed as buttons with no function. Either way, I've made this change locally and will be submitting v2 when I have a bit more time later this week. > Thanks, > Alex -- Tomasz Kramkowski | GPG: 40B037BA0A5B8680 | Web: https://the-tk.com/