All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Ben Widawsky <ben@bwidawsk.net>, Dave Airlie <airlied@gmail.com>,
	Sean Paul <seanpaul@chromium.org>,
	stable@vger.kernel.org, Daniel Vetter <daniel.vetter@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Gustavo Padovan <gustavo@padovan.org>,
	David Airlie <airlied@linux.ie>,
	Javier Martinez Canillas <javier@dowhile0.org>,
	Shuah Khan <shuahkh@osg.samsung.com>,
	Guillaume Tucker <guillaume.tucker@collabora.com>,
	Mark Brown <broonie@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Matt Hart <matthew.hart@linaro.org>,
	Thierry Escande <thierry.escande@collabora.co.uk>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH] drm: rework delayed connector cleanup in connector_iter
Date: Wed, 13 Dec 2017 22:59:51 +0100	[thread overview]
Message-ID: <20171213215951.GE26573@phenom.ffwll.local> (raw)
In-Reply-To: <20171213133515.GB26573@phenom.ffwll.local>

On Wed, Dec 13, 2017 at 02:35:16PM +0100, Daniel Vetter wrote:
> On Wed, Dec 13, 2017 at 01:05:49PM +0000, Chris Wilson wrote:
> > Quoting Daniel Vetter (2017-12-13 12:49:36)
> > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
> > > index 6ffe952142e6..7681269abe41 100644
> > > --- a/drivers/gpu/drm/drm_mode_config.c
> > > +++ b/drivers/gpu/drm/drm_mode_config.c
> > > @@ -382,6 +382,8 @@ void drm_mode_config_init(struct drm_device *dev)
> > >         ida_init(&dev->mode_config.connector_ida);
> > >         spin_lock_init(&dev->mode_config.connector_list_lock);
> > >  
> > > +       INIT_WORK(&dev->mode_config.connector_free_work, drm_connector_free_work_fn);
> > 
> > A init_llist_head(&dev->mode_config.connector_free_list) wouldn't go
> > amiss here. So perhaps push the connectors init into its own exported
> > function from drm_connector.c as opposed to exposing the free_fn.
> 
> Imo it doesn't matter much how we go about drm.ko internals. But I'll
> stick the init_llist_head in there when applying, somehow I dind't find it
> (why is every kernel data type slightly different in this).
> 
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

And applied with init_llist_head added.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Ben Widawsky <ben@bwidawsk.net>, Dave Airlie <airlied@gmail.com>,
	Sean Paul <seanpaul@chromium.org>,
	stable@vger.kernel.org, Daniel Vetter <daniel.vetter@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Gustavo Padovan <gustavo@padovan.org>,
	David Airlie <airlied@linux.ie>,
	Javier Martinez Canillas <javier@dowhile0.org>,
	Shuah Khan <shuahkh@osg.samsung.com>,
	Guillaume Tucker <guillaume.tucker@collabora.com>,
	Mark Brown <broonie@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Matt Hart <matthew.hart@linaro.org>,
	Thierry Escande <thierry.escande@collabora.co.uk>,
	Tomeu Vizoso <tomeu.vizoso@coll>
Subject: Re: [PATCH] drm: rework delayed connector cleanup in connector_iter
Date: Wed, 13 Dec 2017 22:59:51 +0100	[thread overview]
Message-ID: <20171213215951.GE26573@phenom.ffwll.local> (raw)
In-Reply-To: <20171213133515.GB26573@phenom.ffwll.local>

On Wed, Dec 13, 2017 at 02:35:16PM +0100, Daniel Vetter wrote:
> On Wed, Dec 13, 2017 at 01:05:49PM +0000, Chris Wilson wrote:
> > Quoting Daniel Vetter (2017-12-13 12:49:36)
> > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
> > > index 6ffe952142e6..7681269abe41 100644
> > > --- a/drivers/gpu/drm/drm_mode_config.c
> > > +++ b/drivers/gpu/drm/drm_mode_config.c
> > > @@ -382,6 +382,8 @@ void drm_mode_config_init(struct drm_device *dev)
> > >         ida_init(&dev->mode_config.connector_ida);
> > >         spin_lock_init(&dev->mode_config.connector_list_lock);
> > >  
> > > +       INIT_WORK(&dev->mode_config.connector_free_work, drm_connector_free_work_fn);
> > 
> > A init_llist_head(&dev->mode_config.connector_free_list) wouldn't go
> > amiss here. So perhaps push the connectors init into its own exported
> > function from drm_connector.c as opposed to exposing the free_fn.
> 
> Imo it doesn't matter much how we go about drm.ko internals. But I'll
> stick the init_llist_head in there when applying, somehow I dind't find it
> (why is every kernel data type slightly different in this).
> 
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

And applied with init_llist_head added.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2017-12-13 21:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171213104607epcas4p420c1a7a83a19c1924318207c0bb2e8e2@epcas4p4.samsung.com>
2017-12-13 10:45 ` [PATCH] drm: rework delayed connector cleanup in connector_iter Daniel Vetter
2017-12-13 10:45   ` Daniel Vetter
2017-12-13 11:04   ` Chris Wilson
2017-12-13 11:04     ` Chris Wilson
2017-12-13 11:48   ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-12-13 12:27   ` [PATCH] " Marek Szyprowski
2017-12-13 12:49   ` Daniel Vetter
2017-12-13 12:49     ` Daniel Vetter
2017-12-13 13:01     ` Marek Szyprowski
2017-12-13 13:05     ` Chris Wilson
2017-12-13 13:05       ` Chris Wilson
2017-12-13 13:35       ` Daniel Vetter
2017-12-13 13:35         ` Daniel Vetter
2017-12-13 21:59         ` Daniel Vetter [this message]
2017-12-13 21:59           ` Daniel Vetter
2017-12-13 14:48   ` ✓ Fi.CI.BAT: success for drm: rework delayed connector cleanup in connector_iter (rev2) Patchwork
2017-12-13 17:30   ` ✗ Fi.CI.IGT: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213215951.GE26573@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@gmail.com \
    --cc=airlied@linux.ie \
    --cc=ben@bwidawsk.net \
    --cc=broonie@kernel.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=enric.balletbo@collabora.com \
    --cc=guillaume.tucker@collabora.com \
    --cc=gustavo@padovan.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=javier@dowhile0.org \
    --cc=khilman@baylibre.com \
    --cc=matthew.hart@linaro.org \
    --cc=seanpaul@chromium.org \
    --cc=shuahkh@osg.samsung.com \
    --cc=stable@vger.kernel.org \
    --cc=thierry.escande@collabora.co.uk \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.