From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:43476 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753215AbdLMV74 (ORCPT ); Wed, 13 Dec 2017 16:59:56 -0500 Received: by mail-wm0-f65.google.com with SMTP id n138so7780701wmg.2 for ; Wed, 13 Dec 2017 13:59:55 -0800 (PST) Date: Wed, 13 Dec 2017 22:59:51 +0100 From: Daniel Vetter To: Chris Wilson Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Ben Widawsky , Dave Airlie , Sean Paul , stable@vger.kernel.org, Daniel Vetter , Jani Nikula , Gustavo Padovan , David Airlie , Javier Martinez Canillas , Shuah Khan , Guillaume Tucker , Mark Brown , Kevin Hilman , Matt Hart , Thierry Escande , Tomeu Vizoso , Enric Balletbo i Serra Subject: Re: [PATCH] drm: rework delayed connector cleanup in connector_iter Message-ID: <20171213215951.GE26573@phenom.ffwll.local> References: <20171213104553.30821-1-daniel.vetter@ffwll.ch> <20171213124936.17914-1-daniel.vetter@ffwll.ch> <151317034976.11713.13410850976946373368@mail.alporthouse.com> <20171213133515.GB26573@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213133515.GB26573@phenom.ffwll.local> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Dec 13, 2017 at 02:35:16PM +0100, Daniel Vetter wrote: > On Wed, Dec 13, 2017 at 01:05:49PM +0000, Chris Wilson wrote: > > Quoting Daniel Vetter (2017-12-13 12:49:36) > > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > > > index 6ffe952142e6..7681269abe41 100644 > > > --- a/drivers/gpu/drm/drm_mode_config.c > > > +++ b/drivers/gpu/drm/drm_mode_config.c > > > @@ -382,6 +382,8 @@ void drm_mode_config_init(struct drm_device *dev) > > > ida_init(&dev->mode_config.connector_ida); > > > spin_lock_init(&dev->mode_config.connector_list_lock); > > > > > > + INIT_WORK(&dev->mode_config.connector_free_work, drm_connector_free_work_fn); > > > > A init_llist_head(&dev->mode_config.connector_free_list) wouldn't go > > amiss here. So perhaps push the connectors init into its own exported > > function from drm_connector.c as opposed to exposing the free_fn. > > Imo it doesn't matter much how we go about drm.ko internals. But I'll > stick the init_llist_head in there when applying, somehow I dind't find it > (why is every kernel data type slightly different in this). > > > Reviewed-by: Chris Wilson And applied with init_llist_head added. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: rework delayed connector cleanup in connector_iter Date: Wed, 13 Dec 2017 22:59:51 +0100 Message-ID: <20171213215951.GE26573@phenom.ffwll.local> References: <20171213104553.30821-1-daniel.vetter@ffwll.ch> <20171213124936.17914-1-daniel.vetter@ffwll.ch> <151317034976.11713.13410850976946373368@mail.alporthouse.com> <20171213133515.GB26573@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171213133515.GB26573@phenom.ffwll.local> Sender: stable-owner@vger.kernel.org To: Chris Wilson Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Ben Widawsky , Dave Airlie , Sean Paul , stable@vger.kernel.org, Daniel Vetter , Jani Nikula , Gustavo Padovan , David Airlie , Javier Martinez Canillas , Shuah Khan , Guillaume Tucker , Mark Brown , Kevin Hilman , Matt Hart , Thierry Escande , Tomeu Vizoso List-Id: dri-devel@lists.freedesktop.org On Wed, Dec 13, 2017 at 02:35:16PM +0100, Daniel Vetter wrote: > On Wed, Dec 13, 2017 at 01:05:49PM +0000, Chris Wilson wrote: > > Quoting Daniel Vetter (2017-12-13 12:49:36) > > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > > > index 6ffe952142e6..7681269abe41 100644 > > > --- a/drivers/gpu/drm/drm_mode_config.c > > > +++ b/drivers/gpu/drm/drm_mode_config.c > > > @@ -382,6 +382,8 @@ void drm_mode_config_init(struct drm_device *dev) > > > ida_init(&dev->mode_config.connector_ida); > > > spin_lock_init(&dev->mode_config.connector_list_lock); > > > > > > + INIT_WORK(&dev->mode_config.connector_free_work, drm_connector_free_work_fn); > > > > A init_llist_head(&dev->mode_config.connector_free_list) wouldn't go > > amiss here. So perhaps push the connectors init into its own exported > > function from drm_connector.c as opposed to exposing the free_fn. > > Imo it doesn't matter much how we go about drm.ko internals. But I'll > stick the init_llist_head in there when applying, somehow I dind't find it > (why is every kernel data type slightly different in this). > > > Reviewed-by: Chris Wilson And applied with init_llist_head added. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch