From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mahesh Bandewar Subject: [PATCH next 0/2] ipvlan: packet scrub Date: Wed, 13 Dec 2017 14:40:12 -0800 Message-ID: <20171213224012.202819-1-mahesh@bandewar.net> Cc: Eric Dumazet , Mahesh Bandewar , Mahesh Bandewar To: David Miller , Netdev Return-path: Received: from mail-it0-f65.google.com ([209.85.214.65]:43623 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530AbdLMWkX (ORCPT ); Wed, 13 Dec 2017 17:40:23 -0500 Received: by mail-it0-f65.google.com with SMTP id u62so6849975ita.2 for ; Wed, 13 Dec 2017 14:40:23 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: From: Mahesh Bandewar While crossing namespace boundary IPvlan aggressively scrubs packets. This is creating problems. First thing is that scrubbing changes the packet type in skb meta-data to PACKET_HOST. This causes erroneous packet delivery when dev_forward_skb() has already marked the packet type as OTHER_HOST. On the egress side scrubbing just before calling dev_queue_xmit() creates another set of problems. Scrubbing remove skb->sk so the prio update gets missed and more seriously, socket back-pressure fails making TSQ not function correctly. The first patch in the series just reverts the earlier change which was adding a mac-check, but that is unnecessary if packet_type that dev_forward_skb() has set is honored. The second path removes two of the scrubs which are causing problems described above. Mahesh Bandewar (2): Revert "ipvlan: add L2 check for packets arriving via virtual devices" ipvlan: remove excessive packet scrubbing drivers/net/ipvlan/ipvlan_core.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.15.1.424.g9478a66081-goog