From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751625AbdLNBbP (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Dec 2017 20:31:15 -0500
Received: from mailout4.samsung.com ([203.254.224.34]:50635 "EHLO
        mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751464AbdLNBbN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2017 20:31:13 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20171214013111epoutp045944728b009e5bdc2b3cbb166e4b7941~ABRb41DCQ2068620686epoutp04E
X-AuditID: b6c32a36-3d5ff7000000117d-f4-5a31d45e7f55
Date: Thu, 14 Dec 2017 10:31:09 +0900
From: Andi Shyti <andi.shyti@samsung.com>
To: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>,
        Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH v2] spi: s3c64xx: add SPDX identifier
Message-id: <20171214013109.GC11657@gangnam.samsung>
MIME-version: 1.0
Content-type: text/plain; charset="us-ascii"
Content-disposition: inline
In-reply-to: <CAOFm3uHP-4UN+gzXzZc1ptptFm5f9uhafKyE963+DiamzdRTdw@mail.gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDKsWRmVeSWpSXmKPExsWy7bCmrm7cFcMog0M/tCwW/3jOZDH14RM2
        i/7Hr5ktzp/fwG5xedccNosZ5/cxWTR+vMlu8f/3OVYHDo/rSz4xe2xa1cnmsXynicfnTXIB
        LFGpNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAVygp
        lCXmlAKFAhKLi5X07WyK8ktLUhUy8otLbJWiDQ2N9AwNzPWMjIz0TIxjrYxMgUoSUjO2z5jB
        WNDBU7FytW8D4zzOLkZODgkBE4knjw8ydjFycQgJ7GCUmLN1LxtIQkjgO6PEqsuVMEVbFkyE
        im9glPh7Ig/C/sQo8W6+KIjNIqAqMaP9JguIzSagKdF0+wdYvYiAnsS6pV/ZQRYwC3xklDhw
        dx1YkbCApcSd/oXMXYwcHLxACz53poKEeQUEJX5MvgdWwiygI3H22DpGCFta4tHfGewgNqdA
        sMSkM/tZQWxRAWWJvX2HwOZLCOxhk9iw/D8zxNEuEmtunYGyhSVeHd/CDrJLAmjQpaO2EOFm
        Roltt5MheicwSnza+5UJImEs8WxhFxPEYj6Jd197WCF6eSU62oQgSjwkPs88xw5hO0rMvfqK
        DRKI1xgllt7+yjSBUXYWkn9mIflnFpJ/FjAyr2IUSy0ozk1PLTYsMNIrTswtLs1L10vOz93E
        CE5pWmY7GBed8znEKMDBqMTDu0HXMEqINbGsuDL3EKMEB7OSCK/aRKAQb0piZVVqUX58UWlO
        avEhRlNgnExklhJNzgem27ySeEMTSwMTMyNggrI0NFQS5xVdfy1CSCA9sSQ1OzW1ILUIpo+J
        g1OqgZEh38RLkK9i2vyPSYpb5i69HrR7xU2ZNM9NJx5yHFA13rNiqQ9f2W7baadiwloa9RbN
        OaHU5day6vzCx0uX3pj7nbvSf5mgwA9V1ftv+RcamNSonvxhvqBNuFjOdR6n06UDjHOrk5ZU
        Kr+KWayc/r99Zrk7tzFfQGhw0VTpLatnrXQ3LH2lvESJpTgj0VCLuag4EQCQ3dmffwMAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t9jQd24K4ZRBqufSFss/vGcyWLqwyds
        Fv2PXzNbnD+/gd3i8q45bBYzzu9jsmj8eJPd4v/vc6wOHB7Xl3xi9ti0qpPNY/lOE4/Pm+QC
        WKK4bFJSczLLUov07RK4MrbPmMFY0MFTsXK1bwPjPM4uRk4OCQETiS0LJrJ1MXJxCAmsY5Q4
        NekTG0hCSOATo0TP0ioQm0VAVWJG+00WEJtNQFOi6fYPsBoRAT2JdUu/soM0Mwt8BGq+8Z4d
        JCEsYClxp38hcxcjBwcv0IbPnakQC24wSlxfdRhsEK+AoMSPyffAbGYBLYn1O48zQdjSEo/+
        zgCbwykQLHHn+SmwuKiAssTevkPsExj5ZyFpn4WkfRaS9gWMzKsYJVMLinPTc4uNCgzzUsv1
        ihNzi0vz0vWS83M3MQJDetthrb4djPeXxB9iFOBgVOLh5TAwjBJiTSwrrsw9xCjBwawkwqs2
        ESjEm5JYWZValB9fVJqTWnyIUZqDRUmc93besUghgfTEktTs1NSC1CKYLBMHp1QDI2OX9oWU
        yn+9034qtMa56BlaFae+0z0QsfSgqG9qRdmmis8z0xSXVrRo75jmdrehz7Dn/yU5g/P7dDm0
        NNjvnjCeXCOx97j43h9XfzeHzv8T09d5JvwWyxvT97OTFF9t3rcp+FLN+bXq+4J4FkYXbeq9
        p/zxVonF9Cu7TXXvCoRpCVzf8/TtRCWW4oxEQy3mouJEAIdq9ExlAgAA
X-CMS-MailID: 20171214013110epcas1p28da0f30d68bdb1ba81a62e6319314172
X-Msg-Generator: CA
CMS-TYPE: 101P
DLP-Filter: Pass
X-CFilter-Loop: Reflected
X-CMS-RootMailID: 20171213080544epcas2p29731b6c65f760ab1b9ac71d530fcaf77
X-RootMTR: 20171213080544epcas2p29731b6c65f760ab1b9ac71d530fcaf77
References: <CGME20171213080544epcas2p29731b6c65f760ab1b9ac71d530fcaf77@epcas2p2.samsung.com>
        <20171213080530.12724-1-andi.shyti@samsung.com>
        <CAOFm3uHP-4UN+gzXzZc1ptptFm5f9uhafKyE963+DiamzdRTdw@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Philippe,

> > diff --git a/include/linux/platform_data/spi-s3c64xx.h b/include/linux/platform_data/spi-s3c64xx.h
> > index da79774078a7..8917f38c97c5 100644
> > --- a/include/linux/platform_data/spi-s3c64xx.h
> > +++ b/include/linux/platform_data/spi-s3c64xx.h
> > @@ -2,9 +2,7 @@
> >   * Copyright (C) 2009 Samsung Electronics Ltd.
> >   *     Jaswinder Singh <jassi.brar@samsung.com>
> >   *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2 as
> > - * published by the Free Software Foundation.
> > + * SPDX-License-Identifier: GPL-2.0
> >   */
> >
> >  #ifndef __SPI_S3C64XX_H
> > --
> > 2.15.1
> >
> 
> 
> You still need to put this line at the very top of the file, first
> line. That's the convention for the SPDX tags as documented by Thomas
> Gleixner.

I had some doubts on this one, indeed. How should it be done in
this case:

1. Strictly by Thomas documentation:

  /* SPDX-License-Identifier: GPL-2.0 */

  /*
   * Copyright (C) 2009 Samsung Electronics Ltd.
   *     Jaswinder Singh <jassi.brar@samsung.com>
   */

or

2. with a little interpretation

  /*
   * SPDX-License-Identifier: GPL-2.0
   *
   * Copyright (C) 2009 Samsung Electronics Ltd.
   *     Jaswinder Singh <jassi.brar@samsung.com>
   */

(I opted for the one with the least number of changes)

Thanks,
Andi

> > + * SPDX-License-Identifier: GPL-2.0
> 
> 
> -- 
> Cordially
> Philippe Ombredanne
>