All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Peter Hutterer <peter.hutterer@who-t.net>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH 0/2] input - leds: fix bugs found by fuzzing
Date: Thu, 14 Dec 2017 14:25:20 +0100	[thread overview]
Message-ID: <20171214132522.20346-1-benjamin.tissoires@redhat.com> (raw)

Hi,

Peter wrote a fuzzing uinput program[1] to check on libinput,
and the result is that the kernel fails more often than
libinput :)

These 2 patches allow to fix the early failures.

I marked them as stable as I believe eventhough not many
people discovered those and reported them, they should
still be fixed in current kernels.

The fuzzing process still manages to crash the kernel,
bu I have the feeling those crashes are now related
to some races between other userspace process that attempt
to handle the spurious events injected in those random
devices. For instance, the KEY_BLUETOOTH or RF_KILL seem
to manage to mess up my network driver.

Cheers,
Benjamin

[1] https://github.com/whot/fuzzydevice

Benjamin Tissoires (2):
  input - leds: do not iterate over non initialized leds
  input - leds: fix input_led_disconnect path

 drivers/input/input-leds.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.14.3

             reply	other threads:[~2017-12-14 13:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 13:25 Benjamin Tissoires [this message]
2017-12-14 13:25 ` [PATCH 1/2] input - leds: do not iterate over non initialized leds Benjamin Tissoires
2017-12-14 13:25 ` [PATCH 2/2] input - leds: fix input_led_disconnect path Benjamin Tissoires
2017-12-15  0:19   ` Samuel Thibault
2017-12-16  0:48   ` Dmitry Torokhov
2017-12-20 15:11     ` Benjamin Tissoires
2017-12-20 18:20       ` Dmitry Torokhov
2017-12-20 18:42         ` Benjamin Tissoires
2017-12-15  0:16 ` [PATCH 0/2] input - leds: fix bugs found by fuzzing Samuel Thibault
2017-12-15  8:04   ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214132522.20346-1-benjamin.tissoires@redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.