From: Jiri Olsa <jolsa@redhat.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf report: Fix regression when decoding intelPT traces
Date: Thu, 14 Dec 2017 16:28:15 +0100 [thread overview]
Message-ID: <20171214152815.GA3987@krava> (raw)
In-Reply-To: <1513213074-25173-1-git-send-email-mathieu.poirier@linaro.org>
On Wed, Dec 13, 2017 at 05:57:54PM -0700, Mathieu Poirier wrote:
> Commit (93d10af26bb7 perf tools: Optimize sample parsing for ordered
> events) breaks intelPT trace decoding by invariably returning an error if
> the event type isn't a PERF_SAMPLE_TIME.
right, thanks for catchng that
>
> With this patch the timestamp is initialised and processing is allowed to
> continue even if an error is returned by function
> perf_evlist__parse_sample_timestamp().
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> tools/perf/util/session.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 54e30f1bcbd7..20cdcf14232b 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1512,7 +1512,7 @@ static s64 perf_session__process_event(struct perf_session *session,
>
> ret = perf_evlist__parse_sample_timestamp(evlist, event, ×tamp);
> if (ret)
> - return ret;
> + timestamp = -1ULL;
we still have some -EFAULT error codes in there that we
want to catch.. should it be more like in below?
thanks,
jirka
---
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 54e30f1bcbd7..9498aa0efe39 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1508,10 +1508,10 @@ static s64 perf_session__process_event(struct perf_session *session,
return perf_session__process_user_event(session, event, file_offset);
if (tool->ordered_events) {
- u64 timestamp;
+ u64 timestamp = -1ULL
ret = perf_evlist__parse_sample_timestamp(evlist, event, ×tamp);
- if (ret)
+ if (ret != -1)
return ret;
ret = perf_session__queue_event(session, event, timestamp, file_offset);
next prev parent reply other threads:[~2017-12-14 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 0:57 [PATCH] perf report: Fix regression when decoding intelPT traces Mathieu Poirier
2017-12-14 15:28 ` Jiri Olsa [this message]
2017-12-14 16:03 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214152815.GA3987@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.