All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, sandeen@sandeen.net
Subject: Re: [PATCH v7] generic: initial fiemap range query test
Date: Fri, 15 Dec 2017 16:41:12 +0800	[thread overview]
Message-ID: <20171215084112.GK2749@eguan.usersys.redhat.com> (raw)
In-Reply-To: <e0093be7-fbbc-de22-4dd1-429e9f1734d0@suse.com>

On Fri, Dec 15, 2017 at 10:33:16AM +0200, Nikolay Borisov wrote:
> 
> 
> On 30.11.2017 18:05, Nikolay Borisov wrote:
> > Fiemap gained support for passing in optional offset len
> > which denote the range requested, so this patch adds
> > testcases for this functionality. Aditionally, a special "ranged"
> > argument is added to the require_xfs_io_command which checks
> > for the presence of fiemap range support.
> > 
> > Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> 
> SO what's the final verdit, even though to be honest I got a bit annoyed
> at the way the whole situation with fiemap untangled and dunno if I have
> the willpower to make any more adjustments to this test.

I tend to take the patch as-is for now, and let it fail on XFS with the
hope that the failure will drive further discussions and fixes on the
test or kernel when we have a final conclusion.

Please let me know if I should drop the patch.

Thanks,
Eryu

      reply	other threads:[~2017-12-15  8:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 16:05 [PATCH v7] generic: initial fiemap range query test Nikolay Borisov
2017-12-05  8:24 ` Eryu Guan
2017-12-05 16:51   ` Darrick J. Wong
2017-12-06  8:28     ` Eryu Guan
2017-12-06 17:45 ` Darrick J. Wong
2017-12-06 20:51   ` Nikolay Borisov
2017-12-06 21:06     ` Darrick J. Wong
2017-12-06 21:57       ` Dave Chinner
2017-12-06 22:01         ` Eric Sandeen
2017-12-06 22:16           ` Dave Chinner
2017-12-06 22:22             ` Eric Sandeen
2017-12-06 22:46             ` Darrick J. Wong
2017-12-06 23:01               ` Eric Sandeen
2017-12-07  6:55               ` Nikolay Borisov
2017-12-15  8:33 ` Nikolay Borisov
2017-12-15  8:41   ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215084112.GK2749@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.